X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;f=tools%2Fccanlint%2Fcompulsory_tests%2Fcheck_depends_exist.c;h=e2437083e018d2dc52d70e64e09971b406b06e1b;hb=f76c68579cb445177b9957814ba8623a73e5d60e;hp=656901e74c65054eec3c3ffae255ff0a0e564393;hpb=747a69435d9f83c0968d9689c4951bc0233ffc5e;p=ccan

diff --git a/tools/ccanlint/compulsory_tests/check_depends_exist.c b/tools/ccanlint/compulsory_tests/check_depends_exist.c
index 656901e7..e2437083 100644
--- a/tools/ccanlint/compulsory_tests/check_depends_exist.c
+++ b/tools/ccanlint/compulsory_tests/check_depends_exist.c
@@ -14,29 +14,24 @@
 #include <string.h>
 #include <ctype.h>
 
-static char *add_dep(char *sofar, struct manifest *m, const char *dep)
+static void add_dep(struct manifest *m, const char *dep, struct score *score)
 {
-	char *dir;
 	struct stat st;
 	struct ccan_file *f;
 
-	dir = talloc_asprintf(m, "%s/%s", ccan_dir, dep);
-	if (stat(dir, &st) != 0) {
-		return talloc_asprintf_append(sofar,
-					      "ccan/%s: expected it in"
-					      " directory %s\n",
-					      dep, dir);
-	}
-
-	f = new_ccan_file(m, "", dir);
-	list_add_tail(&m->dep_dirs, &f->list);
-	return sofar;
+	f = new_ccan_file(m, ccan_dir, talloc_strdup(m, dep));
+	if (stat(f->fullname, &st) != 0) {
+		score->error = "Depends don't exist";
+		score_file_error(score, f, 0, "could not stat");
+	} else
+		list_add_tail(&m->dep_dirs, &f->list);
 }
 
-static void *check_depends_exist(struct manifest *m)
+static void check_depends_exist(struct manifest *m,
+				bool keep,
+				unsigned int *timeleft, struct score *score)
 {
 	unsigned int i;
-	char *report = NULL;
 	char **deps;
 	char *updir = talloc_strdup(m, m->dir);
 
@@ -52,24 +47,18 @@ static void *check_depends_exist(struct manifest *m)
 		if (!strstarts(deps[i], "ccan/"))
 			continue;
 
-		report = add_dep(report, m, deps[i]);
+		add_dep(m, deps[i], score);
+	}
+	if (!score->error) {
+		score->pass = true;
+		score->score = score->total;
 	}
-	return report;
-}
-
-static const char *describe_depends_exist(struct manifest *m,
-					  void *check_result)
-{
-	return talloc_asprintf(check_result,
-			       "The following dependencies are are expected:\n"
-			       "%s", (char *)check_result);
 }
 
 struct ccanlint depends_exist = {
-	.name = "CCAN dependencies are present",
-	.total_score = 1,
+	.key = "depends-exist",
+	.name = "Module's CCAN dependencies are present",
 	.check = check_depends_exist,
-	.describe = describe_depends_exist,
 };
 
 REGISTER_TEST(depends_exist, NULL);