X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;f=templates%2Fpatchwork%2Ffilters.html;h=36981014f07123b47cb5594e67d1062643d0211e;hb=8f69dd50bb88b7c296a231213c45114541851e44;hp=482bc9890a6effbe59c85d73e262f0fa7363aa73;hpb=c561ebe710d6e6a43aa4afc6c2036a215378ce87;p=patchwork

diff --git a/templates/patchwork/filters.html b/templates/patchwork/filters.html
index 482bc98..3698101 100644
--- a/templates/patchwork/filters.html
+++ b/templates/patchwork/filters.html
@@ -3,7 +3,7 @@
 var filterform_displayed = false;
 function filter_click()
 {
-    form = document.getElementById('filterform');
+    var form = document.getElementById('filterform');
     if (!form) {
         return;
     }
@@ -27,8 +27,8 @@ function filter_form_submit(form)
 {
     var i;
 
-    submitter_select = document.getElementById("submitter_select");
-    submitter_input = document.getElementById("submitter_input");
+    var submitter_select = document.getElementById("submitter_select");
+    var submitter_input = document.getElementById("submitter_input");
     if (!submitter_select || !submitter_input) {
         req = null;
         return;
@@ -92,15 +92,13 @@ function submitter_complete_response()
         return;
     }
 
-    submitter_select = document.getElementById("submitter_select");
-    submitter_input = document.getElementById("submitter_input");
+    var submitter_select = document.getElementById("submitter_select");
+    var submitter_input = document.getElementById("submitter_input");
     if (!submitter_select || !submitter_input) {
         req = null;
         return;
     }
 
-    submitter_select.options = [];
-
     for (i = 0; i < completions.length; i++) {
         name = completions[i]['fields']['name'];
         if (name) {
@@ -112,6 +110,12 @@ function submitter_complete_response()
         o = new Option(name, completions[i]['pk']);
         submitter_select.options[i] = o;
     }
+
+    /* remove remaining options */
+    for (; i < submitter_select.length; i++) {
+        submitter_select.options[i] = null;
+    }
+
     submitter_select.disabled = false;
     req = null;
 }
@@ -143,13 +147,16 @@ function submitter_field_change(field)
    {{ filter.name }} = {{ filter.condition }}
     {% if not filter.forced %}
      <a href="{{ filter.url_without_me }}"><img
-      src="/images/filter-remove.png"></a>
+      width="16" height="16" alt="remove filter" title="remove filter"
+      src="/images/16-circle-blue-remove.png"></a>
     {% endif %}
    {% if not forloop.last %}&nbsp;&nbsp;&nbsp;|&nbsp;&nbsp;&nbsp;{% endif %}
   {% endfor %}
  {% else %}
   none
-  <a href="javascript:filter_click()"><img src="/images/filter-add.png"></a>
+  <a href="javascript:filter_click()"><img
+  width="16" height="16" alt="add filter" title="add filter"
+  src="/images/16-circle-blue-add.png"></a>
  {% endif %}
  </div>
  <div id="filterform" style="padding-top: 1em; display: none">