X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;f=pppd%2Fplugins%2Fradius%2Futil.c;h=740131e8377c51f326b1f465ca94a12526563712;hb=HEAD;hp=6f976a712951947217977c57e8606b1cbafec597;hpb=4abe4296f0eddbb2b6ff11dbbd27100156c85f87;p=ppp.git

diff --git a/pppd/plugins/radius/util.c b/pppd/plugins/radius/util.c
index 6f976a7..4065724 100644
--- a/pppd/plugins/radius/util.c
+++ b/pppd/plugins/radius/util.c
@@ -73,12 +73,12 @@ void rc_mdelay(int msecs)
 char *
 rc_mksid (void)
 {
-  static char buf[15];
+  static char buf[32];
   static unsigned short int cnt = 0;
-  sprintf (buf, "%08lX%04X%02hX",
+  snprintf(buf, sizeof(buf), "%08lX%04X%02hX",
 	   (unsigned long int) time (NULL),
 	   (unsigned int) getpid (),
-	   cnt & 0xFF);
+	   (unsigned short) (cnt & 0xFF));
   cnt++;
   return buf;
 }