X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;f=discover%2Fdevice-handler.c;h=7a84302b71314104b74309c3167abe5314d017b2;hb=c109a4d1bfbe3016c1380c7b0a836a319aa0cf23;hp=8e71310ef5e614b38e9475478a117e7fed66f18d;hpb=aed58c439015f7f7372d9ee70c767ed9dd366dd7;p=petitboot diff --git a/discover/device-handler.c b/discover/device-handler.c index 8e71310..7a84302 100644 --- a/discover/device-handler.c +++ b/discover/device-handler.c @@ -7,11 +7,13 @@ #include #include +#include #include #include #include #include #include +#include #include #include "device-handler.h" @@ -30,6 +32,12 @@ struct device_handler { struct discover_device **devices; unsigned int n_devices; + struct waitset *waitset; + struct waiter *timeout_waiter; + bool autoboot_enabled; + unsigned int sec_to_boot; + + struct discover_boot_option *default_boot_option; struct list unresolved_boot_options; }; @@ -78,11 +86,6 @@ struct discover_boot_option *discover_boot_option_create( return opt; } -static int device_match_path(struct discover_device *dev, const char *path) -{ - return dev->device_path && !strcmp(dev->device_path, path); -} - static int device_match_uuid(struct discover_device *dev, const char *uuid) { return dev->uuid && !strcmp(dev->uuid, uuid); @@ -122,26 +125,10 @@ static struct discover_device *device_lookup( struct discover_device *device_lookup_by_name(struct device_handler *handler, const char *name) { - struct discover_device *dev; - char *path; - - if (strncmp(name, "/dev/", strlen("/dev/"))) - path = talloc_asprintf(NULL, "/dev/%s", name); - else - path = talloc_strdup(NULL, name); - - dev = device_lookup_by_path(handler, path); + if (!strncmp(name, "/dev/", strlen("/dev/"))) + name += strlen("/dev/"); - talloc_free(path); - - return dev; -} - -struct discover_device *device_lookup_by_path( - struct device_handler *device_handler, - const char *path) -{ - return device_lookup(device_handler, device_match_path, path); + return device_lookup_by_id(handler, name); } struct discover_device *device_lookup_by_uuid( @@ -176,6 +163,7 @@ void device_handler_destroy(struct device_handler *handler) * to keep struct device_handler opaque. */ struct device_handler *device_handler_init( struct discover_server *server __attribute__((unused)), + struct waitset *waitset __attribute__((unused)), int dry_run __attribute__((unused))) { struct device_handler *handler; @@ -199,7 +187,7 @@ void device_handler_add_device(struct device_handler *handler, static int mount_device(struct discover_device *dev) { - const char *argv[6]; + int rc; if (!dev->device_path) return -1; @@ -212,29 +200,20 @@ static int mount_device(struct discover_device *dev) pb_log("couldn't create mount directory %s: %s\n", dev->mount_path, strerror(errno)); - argv[0] = pb_system_apps.mount; - argv[1] = dev->device_path; - argv[2] = dev->mount_path; - argv[3] = "-o"; - argv[4] = "ro"; - argv[5] = NULL; - - if (pb_run_cmd(argv, 1, 0)) { - - /* Retry mount without ro option. */ + rc = process_run_simple(dev, pb_system_apps.mount, + dev->device_path, dev->mount_path, + "-o", "ro", NULL); - argv[0] = pb_system_apps.mount; - argv[1] = dev->device_path; - argv[2] = dev->mount_path; - argv[3] = NULL; + if (!rc) + return 0; - if (pb_run_cmd(argv, 1, 0)) - goto out_rmdir; - } + /* Retry mount without ro option. */ + rc = process_run_simple(dev, pb_system_apps.mount, + dev->device_path, dev->mount_path, NULL); - return 0; + if (!rc) + return 0; -out_rmdir: pb_rmdir_recursive(mount_base(), dev->mount_path); return -1; } @@ -242,28 +221,12 @@ out_rmdir: static int umount_device(struct discover_device *dev) { int status; - pid_t pid; if (!dev->mount_path) return 0; - pid = fork(); - if (pid == -1) { - pb_log("%s: fork failed: %s\n", __func__, strerror(errno)); - return -1; - } - - if (pid == 0) { - execl(pb_system_apps.umount, pb_system_apps.umount, - dev->mount_path, NULL); - exit(EXIT_FAILURE); - } - - if (waitpid(pid, &status, 0) == -1) { - pb_log("%s: waitpid failed: %s\n", __func__, - strerror(errno)); - return -1; - } + status = process_run_simple(dev, pb_system_apps.umount, + dev->mount_path, NULL); if (!WIFEXITED(status) || WEXITSTATUS(status) != 0) return -1; @@ -274,7 +237,7 @@ static int umount_device(struct discover_device *dev) } struct device_handler *device_handler_init(struct discover_server *server, - int dry_run) + struct waitset *waitset, int dry_run) { struct device_handler *handler; @@ -282,7 +245,10 @@ struct device_handler *device_handler_init(struct discover_server *server, handler->devices = NULL; handler->n_devices = 0; handler->server = server; + handler->waitset = waitset; handler->dry_run = dry_run; + handler->default_boot_option = NULL; + handler->autoboot_enabled = config_get()->autoboot_enabled; list_init(&handler->unresolved_boot_options); /* set up our mount point base */ @@ -317,13 +283,34 @@ static struct discover_device *find_device(struct device_handler *handler, return NULL; } +static enum device_type event_device_type(struct device *device, + struct event *event) +{ + const char *param; + + param = event_get_param(event, "type"); + if (!param) { + pb_log("%s: empty type\n", device->id); + return DEVICE_TYPE_UNKNOWN; + } + + if (!strcmp(param, "disk") || !strcmp(param, "partition")) + return DEVICE_TYPE_DISK; + + if (!strcmp(param, "net")) + return DEVICE_TYPE_NETWORK; + + pb_log("%s: unknown type '%s'\n", device->id, param); + return DEVICE_TYPE_UNKNOWN; +} + static struct discover_device *discover_device_create( struct device_handler *handler, struct discover_context *ctx, struct event *event) { struct discover_device *dev; - const char *devname; + const char *devnode; dev = find_device(handler, event->device); if (dev) @@ -333,11 +320,12 @@ static struct discover_device *discover_device_create( dev->device = talloc_zero(dev, struct device); list_init(&dev->boot_options); - devname = event_get_param(ctx->event, "DEVNAME"); - if (devname) - dev->device_path = talloc_strdup(dev, devname); + devnode = event_get_param(ctx->event, "node"); + if (devnode) + dev->device_path = talloc_strdup(dev, devnode); dev->device->id = talloc_strdup(dev, event->device); + dev->device->type = event_device_type(dev->device, event); talloc_set_destructor(dev, destroy_device); @@ -373,6 +361,73 @@ static void device_handler_remove(struct device_handler *handler, talloc_free(device); } +static void boot_status(void *arg, struct boot_status *status) +{ + struct device_handler *handler = arg; + + discover_server_notify_boot_status(handler->server, status); +} + +static void countdown_status(struct device_handler *handler, + struct discover_boot_option *opt, unsigned int sec) +{ + struct boot_status status; + + status.type = BOOT_STATUS_INFO; + status.progress = -1; + status.detail = NULL; + status.message = talloc_asprintf(handler, + "Booting %s in %u sec", opt->option->name, sec); + + discover_server_notify_boot_status(handler->server, &status); + + talloc_free(status.message); +} + +static int default_timeout(void *arg) +{ + struct device_handler *handler = arg; + struct discover_boot_option *opt; + + if (!handler->default_boot_option) + return 0; + + opt = handler->default_boot_option; + + if (handler->sec_to_boot) { + countdown_status(handler, opt, handler->sec_to_boot); + handler->sec_to_boot--; + handler->timeout_waiter = waiter_register_timeout( + handler->waitset, 1000, + default_timeout, handler); + return 0; + } + + pb_log("Timeout expired, booting default option %s\n", opt->option->id); + + boot(handler, handler->default_boot_option, NULL, + handler->dry_run, boot_status, handler); + return 0; +} + +static void set_default(struct device_handler *handler, + struct discover_boot_option *opt) +{ + if (handler->default_boot_option) + return; + + if (!handler->autoboot_enabled) + return; + + handler->default_boot_option = opt; + handler->sec_to_boot = config_get()->autoboot_timeout_sec; + + pb_log("Boot option %s set as default, timeout %u sec.\n", + opt->option->id, handler->sec_to_boot); + + default_timeout(handler); +} + static bool resource_is_resolved(struct resource *res) { return !res || res->resolved; @@ -385,15 +440,21 @@ static bool __attribute__((used)) boot_option_is_resolved( { return resource_is_resolved(opt->boot_image) && resource_is_resolved(opt->initrd) && + resource_is_resolved(opt->dtb) && resource_is_resolved(opt->icon); } -static bool resource_resolve(struct resource *res, struct parser *parser, +static bool resource_resolve(struct resource *res, const char *name, + struct discover_boot_option *opt, struct device_handler *handler) { + struct parser *parser = opt->source; + if (resource_is_resolved(res)) return true; + pb_log("Attempting to resolve resource %s->%s with parser %s\n", + opt->option->id, name, parser->name); parser->resolve_resource(handler, res); return res->resolved; @@ -402,18 +463,21 @@ static bool resource_resolve(struct resource *res, struct parser *parser, static bool boot_option_resolve(struct discover_boot_option *opt, struct device_handler *handler) { - return resource_resolve(opt->boot_image, opt->source, handler) && - resource_resolve(opt->initrd, opt->source, handler) && - resource_resolve(opt->icon, opt->source, handler); + return resource_resolve(opt->boot_image, "boot_image", opt, handler) && + resource_resolve(opt->initrd, "initrd", opt, handler) && + resource_resolve(opt->dtb, "dtb", opt, handler) && + resource_resolve(opt->icon, "icon", opt, handler); } -static void boot_option_finalise(struct discover_boot_option *opt) +static void boot_option_finalise(struct device_handler *handler, + struct discover_boot_option *opt) { assert(boot_option_is_resolved(opt)); /* check that the parsers haven't set any of the final data */ assert(!opt->option->boot_image_file); assert(!opt->option->initrd_file); + assert(!opt->option->dtb_file); assert(!opt->option->icon_file); assert(!opt->option->device_id); @@ -421,10 +485,15 @@ static void boot_option_finalise(struct discover_boot_option *opt) opt->option->boot_image_file = opt->boot_image->url->full; if (opt->initrd) opt->option->initrd_file = opt->initrd->url->full; + if (opt->dtb) + opt->option->dtb_file = opt->dtb->url->full; if (opt->icon) opt->option->icon_file = opt->icon->url->full; opt->option->device_id = opt->device->device->id; + + if (opt->option->is_default) + set_default(handler, opt); } static void process_boot_option_queue(struct device_handler *handler) @@ -434,13 +503,18 @@ static void process_boot_option_queue(struct device_handler *handler) list_for_each_entry_safe(&handler->unresolved_boot_options, opt, tmp, list) { + pb_log("queue: attempting resolution for %s\n", + opt->option->id); + if (!boot_option_resolve(opt, handler)) continue; + pb_log("\tresolved!\n"); + list_remove(&opt->list); - list_add(&opt->device->boot_options, &opt->list); + list_add_tail(&opt->device->boot_options, &opt->list); talloc_steal(opt->device, opt); - boot_option_finalise(opt); + boot_option_finalise(handler, opt); discover_server_notify_boot_option_add(handler->server, opt->option); } @@ -477,6 +551,7 @@ static void context_commit(struct device_handler *handler, /* this new device might be able to resolve existing boot * options */ + pb_log("New device %s, processing queue\n", dev->device->id); process_boot_option_queue(handler); } @@ -486,9 +561,12 @@ static void context_commit(struct device_handler *handler, list_remove(&opt->list); if (boot_option_resolve(opt, handler)) { - list_add(&dev->boot_options, &opt->list); + pb_log("boot option %s is resolved, " + "sending to clients\n", + opt->option->id); + list_add_tail(&dev->boot_options, &opt->list); talloc_steal(dev, opt); - boot_option_finalise(opt); + boot_option_finalise(handler, opt); discover_server_notify_boot_option_add(handler->server, opt->option); } else { @@ -690,13 +768,6 @@ int device_handler_event(struct device_handler *handler, return handlers[event->type][event->action](handler, event); } -static void boot_status(void *arg, struct boot_status *status) -{ - struct device_handler *handler = arg; - - discover_server_notify_boot_status(handler->server, status); -} - static struct discover_boot_option *find_boot_option_by_id( struct device_handler *handler, const char *id) { @@ -723,4 +794,30 @@ void device_handler_boot(struct device_handler *handler, boot(handler, opt, cmd, handler->dry_run, boot_status, handler); } + +void device_handler_cancel_default(struct device_handler *handler) +{ + struct boot_status status; + + if (handler->timeout_waiter) + waiter_remove(handler->timeout_waiter); + + handler->timeout_waiter = NULL; + handler->autoboot_enabled = false; + + /* we only send status if we had a default boot option queued */ + if (!handler->default_boot_option) + return; + + pb_log("Cancelling default boot option\n"); + + handler->default_boot_option = NULL; + + status.type = BOOT_STATUS_INFO; + status.progress = -1; + status.detail = NULL; + status.message = "Default boot cancelled"; + + discover_server_notify_boot_status(handler->server, &status); +} #endif