X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;f=apps%2Fpatchwork%2Fmodels.py;h=fa213dc03e8dfa9a068e11f780d581a358acdb4d;hb=487b53576fb71be3d675605efa41e118e4993f32;hp=bb0b52c165e979ed9f482290ecb1e0680b3ad25c;hpb=ab0062c77d1fd7d1ed583d3db6528a06bface822;p=patchwork diff --git a/apps/patchwork/models.py b/apps/patchwork/models.py index bb0b52c..fa213dc 100644 --- a/apps/patchwork/models.py +++ b/apps/patchwork/models.py @@ -178,7 +178,7 @@ class PatchMbox(MIMENonMultipart): class Patch(models.Model): project = models.ForeignKey(Project) - msgid = models.CharField(max_length=255, unique = True) + msgid = models.CharField(max_length=255) name = models.CharField(max_length=255) date = models.DateTimeField(default=datetime.datetime.now) submitter = models.ForeignKey(Person) @@ -227,6 +227,8 @@ class Patch(models.Model): return str.strip('-') + '.patch' def mbox(self): + postscript_re = re.compile('\n-{2,3} ?\n') + comment = None try: comment = Comment.objects.get(patch = self, msgid = self.msgid) @@ -237,6 +239,14 @@ class Patch(models.Model): if comment: body = comment.content.strip() + "\n" + parts = postscript_re.split(body, 1) + if len(parts) == 2: + (body, postscript) = parts + body = body.strip() + "\n" + postscript = postscript.strip() + "\n" + else: + postscript = '' + responses = False for comment in Comment.objects.filter(patch = self) \ .exclude(msgid = self.msgid): @@ -245,7 +255,10 @@ class Patch(models.Model): if body: body += '\n' - body += self.content + if postscript: + body += '---\n' + postscript.strip() + '\n' + + body += '\n' + self.content mail = PatchMbox(body) mail['Subject'] = self.name @@ -265,16 +278,17 @@ class Patch(models.Model): class Meta: verbose_name_plural = 'Patches' ordering = ['date'] + unique_together = [('msgid', 'project')] class Comment(models.Model): patch = models.ForeignKey(Patch) - msgid = models.CharField(max_length=255, unique = True) + msgid = models.CharField(max_length=255) submitter = models.ForeignKey(Person) date = models.DateTimeField(default = datetime.datetime.now) headers = models.TextField(blank = True) content = models.TextField() - response_re = re.compile('^(Acked|Signed-off|Nacked)-by: .*$', re.M) + response_re = re.compile('^(Tested|Reviewed|Acked|Signed-off|Nacked)-by: .*$', re.M | re.I) def patch_responses(self): return ''.join([ match.group(0) + '\n' for match in \ @@ -282,17 +296,39 @@ class Comment(models.Model): class Meta: ordering = ['date'] + unique_together = [('msgid', 'patch')] class Bundle(models.Model): owner = models.ForeignKey(User) project = models.ForeignKey(Project) name = models.CharField(max_length = 50, null = False, blank = False) - patches = models.ManyToManyField(Patch) + patches = models.ManyToManyField(Patch, through = 'BundlePatch') public = models.BooleanField(default = False) def n_patches(self): return self.patches.all().count() + def ordered_patches(self): + return self.patches.order_by('bundlepatch__order'); + + def append_patch(self, patch): + # todo: use the aggregate queries in django 1.1 + orders = BundlePatch.objects.filter(bundle = self).order_by('-order') \ + .values('order') + + if len(orders) > 0: + max_order = orders[0]['order'] + else: + max_order = 0 + + # see if the patch is already in this bundle + if BundlePatch.objects.filter(bundle = self, patch = patch).count(): + raise Exception("patch is already in bundle") + + bp = BundlePatch.objects.create(bundle = self, patch = patch, + order = max_order + 1) + bp.save() + class Meta: unique_together = [('owner', 'name')] @@ -309,7 +345,16 @@ class Bundle(models.Model): def mbox(self): return '\n'.join([p.mbox().as_string(True) \ - for p in self.patches.all()]) + for p in self.ordered_patches()]) + +class BundlePatch(models.Model): + patch = models.ForeignKey(Patch) + bundle = models.ForeignKey(Bundle) + order = models.IntegerField() + + class Meta: + unique_together = [('bundle', 'patch')] + ordering = ['order'] class UserPersonConfirmation(models.Model): user = models.ForeignKey(User) @@ -323,7 +368,7 @@ class UserPersonConfirmation(models.Model): return person = None try: - person = Person.objects.get(email = self.email) + person = Person.objects.get(email__iexact = self.email) except Exception: pass if not person: