X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;f=apps%2Fpatchwork%2Fforms.py;fp=apps%2Fpatchwork%2Fforms.py;h=dc7a46443fa4179171044d1bb8ad6aa29824cc8a;hb=8639b526494afbe41d27c60e69ce26513c7d3c37;hp=4c811f547c439dd924db58bb5c8a496b497e78e5;hpb=479a6a88c41203aca1a1f44253554a4f28d2e248;p=patchwork

diff --git a/apps/patchwork/forms.py b/apps/patchwork/forms.py
index 4c811f5..dc7a464 100644
--- a/apps/patchwork/forms.py
+++ b/apps/patchwork/forms.py
@@ -176,6 +176,24 @@ class MultipleBooleanField(forms.ChoiceField):
     def is_no_change(self, value):
         return value == self.no_change_choice[0]
 
+    # TODO: Check whether it'd be worth to use a TypedChoiceField here; I
+    # think that'd allow us to get rid of the custom valid_value() and
+    # to_python() methods.
+    def valid_value(self, value):
+        if value in [v1 for (v1, v2) in self.choices]:
+            return True
+        return False
+
+    def to_python(self, value):
+        if self.is_no_change(value):
+            return value
+        elif value == 'True':
+            return True
+        elif value == 'False':
+            return False
+        else:
+            raise ValueError('Unknown value: %s' % value)
+
 class MultiplePatchForm(forms.Form):
     state = OptionalModelChoiceField(queryset = State.objects.all())
     archived = MultipleBooleanField()