X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;ds=sidebyside;f=tools%2Fccanlint%2Fcompulsory_tests%2Fhas_tests.c;h=f6ef496843f51c95528c67973ef433b762cc05bf;hb=09fde153ba7a68715dcad3b53cbbb8804c3d2356;hp=cd31d2229cca047d41c758c7702d58bf1c7f725c;hpb=0c532d80a73cae44360595c762dddefcd7e0a4ec;p=ccan

diff --git a/tools/ccanlint/compulsory_tests/has_tests.c b/tools/ccanlint/compulsory_tests/has_tests.c
index cd31d222..f6ef4968 100644
--- a/tools/ccanlint/compulsory_tests/has_tests.c
+++ b/tools/ccanlint/compulsory_tests/has_tests.c
@@ -12,13 +12,16 @@
 
 static char test_is_not_dir[] = "test is not a directory";
 
-static void *check_has_tests(struct manifest *m)
+static void *check_has_tests(struct manifest *m,
+			     bool keep,
+			     unsigned int *timeleft)
 {
 	struct stat st;
+	char *test_dir = talloc_asprintf(m, "%s/test", m->dir);
 
-	if (lstat("test", &st) != 0) {
+	if (lstat(test_dir, &st) != 0) {
 		if (errno != ENOENT)
-			err(1, "statting test/");
+			err(1, "statting %s", test_dir);
 		return "You have no test directory";
 	}
 
@@ -48,7 +51,8 @@ static const char *describe_has_tests(struct manifest *m, void *check_result)
 	"warnings, and then run: it is expected to use libtap to report its\n"
 	"results in a simple and portable format.  It should #include the C\n"
 	"files from the module directly (so it can probe the internals): the\n"
-	"module will not be linked in.\n\n"
+	"module will not be linked in.  The test will be run in a temporary\n"
+	"directory, with the test directory symlinked under test/.\n\n"
 
 	"api tests are just like a run test, except it is a guarantee of API\n"
 	"stability: this test should pass on all future versions of the\n"
@@ -123,7 +127,8 @@ static void handle_no_tests(struct manifest *m, void *check_result)
 }	
 
 struct ccanlint has_tests = {
-	.name = "Has tests",
+	.key = "has-tests",
+	.name = "Module has tests",
 	.check = check_has_tests,
 	.describe = describe_has_tests,
 	.handle = handle_no_tests,