X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;ds=sidebyside;f=patchwork%2Fviews%2F__init__.py;h=8df8920ce991f104a0e783b69c46ba861272770a;hb=HEAD;hp=cb05a8ec7dc9e0ea619b9952eaf99744f8ea2d43;hpb=7a39d75859c4ee908573726f0a82df85cdb8b845;p=patchwork diff --git a/patchwork/views/__init__.py b/patchwork/views/__init__.py index cb05a8e..8df8920 100644 --- a/patchwork/views/__init__.py +++ b/patchwork/views/__init__.py @@ -26,20 +26,11 @@ from patchwork.models import Comment import re import datetime -try: - from email.mime.nonmultipart import MIMENonMultipart - from email.encoders import encode_7or8bit - from email.parser import HeaderParser - from email.header import Header - import email.utils -except ImportError: - # Python 2.4 compatibility - from email.MIMENonMultipart import MIMENonMultipart - from email.Encoders import encode_7or8bit - from email.Parser import HeaderParser - from email.Header import Header - import email.Utils - email.utils = email.Utils +from email.mime.nonmultipart import MIMENonMultipart +from email.encoders import encode_7or8bit +from email.parser import HeaderParser +from email.header import Header +import email.utils def generic_list(request, project, view, view_args = {}, filter_settings = [], patches = None, @@ -50,15 +41,19 @@ def generic_list(request, project, view, list_view_params = view_args) context.project = project - order = Order(request.REQUEST.get('order'), editable = editable_order) + data = {} + if request.method == 'GET': + data = request.GET + elif request.method == 'POST': + data = request.POST + order = Order(data.get('order'), editable=editable_order) # Explicitly set data to None because request.POST will be an empty dict # when the form is not submitted, but passing a non-None data argument to # a forms.Form will make it bound and we don't want that to happen unless # there's been a form submission. - data = None - if request.method == 'POST': - data = request.POST + if request.method != 'POST': + data = None user = request.user properties_form = None if project.is_editable(user):