X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;ds=sidebyside;f=discover%2Fboot.c;h=2f381a7d0e069619120ccc234a4f2f33ba1effae;hb=227620704107a19c03824ae146249fff4a939839;hp=f9b0223bdf43c42adc30ba439b71ee156eb59a30;hpb=b9c9da2c9fa23040870dff975a3ccd2beda6b297;p=petitboot

diff --git a/discover/boot.c b/discover/boot.c
index f9b0223..2f381a7 100644
--- a/discover/boot.c
+++ b/discover/boot.c
@@ -11,6 +11,7 @@
 
 #include <log/log.h>
 #include <pb-protocol/pb-protocol.h>
+#include <process/process.h>
 #include <system/system.h>
 #include <talloc/talloc.h>
 #include <url/url.h>
@@ -26,13 +27,25 @@ enum {
 	BOOT_HOOK_EXIT_UPDATE	= 2,
 };
 
+enum boot_process_state {
+	BOOT_STATE_INITIAL,
+	BOOT_STATE_IMAGE_LOADING,
+	BOOT_STATE_INITRD_LOADING,
+	BOOT_STATE_DTB_LOADING,
+	BOOT_STATE_FINISH,
+	BOOT_STATE_UNKNOWN,
+};
 
-struct boot_task {
-	char *local_image;
-	char *local_initrd;
-	char *local_dtb;
-	char *args;
 
+struct boot_task {
+	struct load_url_result *image;
+	struct load_url_result *initrd;
+	struct load_url_result *dtb;
+	const char *args;
+	struct pb_url *image_url, *initrd_url, *dtb_url;
+	boot_status_fn status_fn;
+	void *status_arg;
+	enum boot_process_state state;
 	bool dry_run;
 };
 
@@ -52,16 +65,16 @@ static int kexec_load(struct boot_task *boot_task)
 	*p++ = pb_system_apps.kexec;	/* 1 */
 	*p++ = "-l";			/* 2 */
 
-	if (boot_task->local_initrd) {
+	if (boot_task->initrd) {
 		s_initrd = talloc_asprintf(boot_task, "--initrd=%s",
-				boot_task->local_initrd);
+				boot_task->initrd->local);
 		assert(s_initrd);
 		*p++ = s_initrd;	 /* 3 */
 	}
 
-	if (boot_task->local_dtb) {
+	if (boot_task->dtb) {
 		s_dtb = talloc_asprintf(boot_task, "--dtb=%s",
-						boot_task->local_dtb);
+						boot_task->dtb->local);
 		assert(s_dtb);
 		*p++ = s_dtb;		 /* 4 */
 	}
@@ -73,10 +86,10 @@ static int kexec_load(struct boot_task *boot_task)
 		*p++ = s_args;		/* 5 */
 	}
 
-	*p++ = boot_task->local_image;	/* 6 */
+	*p++ = boot_task->image->local;	/* 6 */
 	*p++ = NULL;			/* 7 */
 
-	result = pb_run_cmd(argv, 1, boot_task->dry_run);
+	result = process_run_simple_argv(boot_task, argv);
 
 	if (result)
 		pb_log("%s: failed: (%d)\n", __func__, result);
@@ -90,31 +103,18 @@ static int kexec_load(struct boot_task *boot_task)
  * Must only be called after a successful call to kexec_load().
  */
 
-static int kexec_reboot(bool dry_run)
+static int kexec_reboot(struct boot_task *task)
 {
-	int result = 0;
-	const char *argv[4];
-	const char **p;
+	int result;
 
 	/* First try running shutdown.  Init scripts should run 'exec -e' */
-
-	p = argv;
-	*p++ = pb_system_apps.shutdown;	/* 1 */
-	*p++ =  "-r";			/* 2 */
-	*p++ =  "now";			/* 3 */
-	*p++ =  NULL;			/* 4 */
-
-	result = pb_run_cmd(argv, 1, dry_run);
+	result = process_run_simple(task, pb_system_apps.shutdown, "-r",
+			"now", NULL);
 
 	/* On error, force a kexec with the -e option */
-
 	if (result) {
-		p = argv;
-		*p++ = pb_system_apps.kexec;	/* 1 */
-		*p++ = "-e";			/* 2 */
-		*p++ = NULL;			/* 3 */
-
-		result = pb_run_cmd(argv, 1, 0);
+		result = process_run_simple(task, pb_system_apps.kexec,
+						"-e", NULL);
 	}
 
 	if (result)
@@ -122,13 +122,8 @@ static int kexec_reboot(bool dry_run)
 
 	/* okay, kexec -e -f */
 	if (result) {
-		p = argv;
-		*p++ = pb_system_apps.kexec;	/* 1 */
-		*p++ = "-e";			/* 2 */
-		*p++ = "-f";			/* 3 */
-		*p++ = NULL;			/* 4 */
-
-		result = pb_run_cmd(argv, 1, 0);
+		result = process_run_simple(task, pb_system_apps.kexec,
+						"-e", "-f", NULL);
 	}
 
 	if (result)
@@ -138,17 +133,23 @@ static int kexec_reboot(bool dry_run)
 	return result;
 }
 
-static void update_status(boot_status_fn fn, void *arg, int type,
-		char *message)
+static void __attribute__((format(__printf__, 4, 5))) update_status(
+		boot_status_fn fn, void *arg, int type, char *fmt, ...)
 {
 	struct boot_status status;
+	va_list ap;
+
+	va_start(ap, fmt);
+	status.message = talloc_vasprintf(NULL, fmt, ap);
+	va_end(ap);
 
 	status.type = type;
-	status.message = message;
 	status.progress = -1;
 	status.detail = NULL;
 
 	fn(arg, &status);
+
+	talloc_free(status.message);
 }
 
 static void boot_hook_update_param(void *ctx, struct boot_task *task,
@@ -156,11 +157,11 @@ static void boot_hook_update_param(void *ctx, struct boot_task *task,
 {
 	struct p {
 		const char *name;
-		char **p;
+		const char **p;
 	} *param, params[] = {
-		{ "boot_image",		&task->local_image },
-		{ "boot_initrd",	&task->local_initrd },
-		{ "boot_dtb",		&task->local_dtb },
+		{ "boot_image",		&task->image->local },
+		{ "boot_initrd",	&task->initrd->local },
+		{ "boot_dtb",		&task->dtb->local },
 		{ "boot_args",		&task->args },
 		{ NULL, NULL },
 	};
@@ -208,11 +209,11 @@ static void boot_hook_setenv(struct boot_task *task)
 	unsetenv("boot_dtb");
 	unsetenv("boot_args");
 
-	setenv("boot_image", task->local_image, 1);
-	if (task->local_initrd)
-		setenv("boot_initrd", task->local_initrd, 1);
-	if (task->local_dtb)
-		setenv("boot_dtb", task->local_dtb, 1);
+	setenv("boot_image", task->image->local, 1);
+	if (task->initrd)
+		setenv("boot_initrd", task->initrd->local, 1);
+	if (task->dtb)
+		setenv("boot_dtb", task->dtb->local, 1);
 	if (task->args)
 		setenv("boot_args", task->args, 1);
 }
@@ -227,8 +228,7 @@ static int hook_cmp(const struct dirent **a, const struct dirent **b)
 	return strcmp((*a)->d_name, (*b)->d_name);
 }
 
-static void run_boot_hooks(struct boot_task *task, boot_status_fn status_fn,
-		void *status_arg)
+static void run_boot_hooks(struct boot_task *task)
 {
 	struct dirent **hooks;
 	int i, n;
@@ -237,78 +237,230 @@ static void run_boot_hooks(struct boot_task *task, boot_status_fn status_fn,
 	if (n < 1)
 		return;
 
-	update_status(status_fn, status_arg, BOOT_STATUS_INFO,
+	update_status(task->status_fn, task->status_arg, BOOT_STATUS_INFO,
 			"running boot hooks");
 
 	boot_hook_setenv(task);
 
 	for (i = 0; i < n; i++) {
 		const char *argv[2] = { NULL, NULL };
-		char *path, *buf;
-		int buf_len, rc;
+		struct process *process;
+		char *path;
+		int rc;
 
 		path = join_paths(task, boot_hook_dir, hooks[i]->d_name);
 
-		if (access(path, X_OK))
+		if (access(path, X_OK)) {
+			talloc_free(path);
 			continue;
+		}
 
-		pb_log("running boot hook %s\n", hooks[i]->d_name);
+		process = process_create(task);
 
 		argv[0] = path;
-		rc = pb_run_cmd_pipe(argv, 1, task->dry_run, task,
-				&buf, &buf_len);
-
-		/* if the hook returned with BOOT_HOOK_EXIT_UPDATE,
-		 * then we process stdout to look for updated params
-		 */
-		if (rc == BOOT_HOOK_EXIT_UPDATE) {
-			boot_hook_update(task, hooks[i]->d_name, buf);
-			boot_hook_setenv(task);
+		process->path = path;
+		process->argv = argv;
+		process->keep_stdout = true;
+
+		pb_log("running boot hook %s\n", hooks[i]->d_name);
+
+		rc = process_run_sync(process);
+		if (rc) {
+			pb_log("boot hook exec failed!\n");
+
+		} else if (WIFEXITED(process->exit_status) &&
+			   WEXITSTATUS(process->exit_status)
+				== BOOT_HOOK_EXIT_UPDATE) {
+			/* if the hook returned with BOOT_HOOK_EXIT_UPDATE,
+			 * then we process stdout to look for updated params
+			 */
+			if (rc == BOOT_HOOK_EXIT_UPDATE) {
+				boot_hook_update(task, hooks[i]->d_name,
+						process->stdout_buf);
+				boot_hook_setenv(task);
+			}
 		}
 
-		talloc_free(buf);
+		process_release(process);
 		talloc_free(path);
 	}
 
 	free(hooks);
 }
 
+static void cleanup_load(struct load_url_result *result)
+{
+	if (!result)
+		return;
+	if (result->status != LOAD_OK)
+		return;
+	if (!result->cleanup_local)
+		return;
+	unlink(result->local);
+}
+
+static void boot_process(struct load_url_result *result, void *data)
+{
+	struct boot_task *task = data;
+	int rc = -1;
+
+	if (task->state == BOOT_STATE_INITIAL) {
+		update_status(task->status_fn, task->status_arg,
+				BOOT_STATUS_INFO, "loading kernel");
+		task->image = load_url_async(task, task->image_url,
+						boot_process, task);
+		if (!task->image) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_ERROR,
+					"Couldn't load kernel image");
+			goto no_load;
+		}
+		task->state = BOOT_STATE_IMAGE_LOADING;
+		return;
+	}
+
+	if (task->state == BOOT_STATE_IMAGE_LOADING) {
+		if (result->status == LOAD_ERROR) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_ERROR,
+					"Error loading kernel image");
+			goto no_load;
+		}
+		task->state = BOOT_STATE_INITRD_LOADING;
+
+		if (task->initrd_url) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_INFO, "loading initrd");
+			task->initrd = load_url_async(task, task->initrd_url,
+							boot_process, task);
+			if (!task->initrd) {
+				update_status(task->status_fn, task->status_arg,
+						BOOT_STATUS_ERROR,
+						"Couldn't load initrd image");
+				goto no_load;
+			}
+			return;
+		}
+	}
+
+	if (task->state == BOOT_STATE_INITRD_LOADING) {
+		if (result->status) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_ERROR,
+					"Error loading initrd");
+			goto no_load;
+		}
+		task->state = BOOT_STATE_DTB_LOADING;
+
+		if (task->dtb_url) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_INFO,
+					"loading device tree");
+			task->dtb = load_url_async(task, task->dtb_url,
+							boot_process, task);
+			if (!task->dtb) {
+				update_status(task->status_fn, task->status_arg,
+						BOOT_STATUS_ERROR,
+						"Couldn't load device tree");
+				goto no_load;
+			}
+			return;
+		}
+	}
+
+	if (task->state == BOOT_STATE_DTB_LOADING) {
+		if (result->status) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_ERROR,
+					"Error loading dtb");
+			goto no_load;
+		}
+		task->state = BOOT_STATE_FINISH;
+	}
+
+
+	if (task->state != BOOT_STATE_FINISH) {
+		task->state = BOOT_STATE_UNKNOWN;
+		return;
+	}
+
+	run_boot_hooks(task);
+
+	update_status(task->status_fn, task->status_arg, BOOT_STATUS_INFO,
+			"performing kexec_load");
+
+	rc = kexec_load(task);
+	if (rc) {
+		update_status(task->status_fn, task->status_arg,
+				BOOT_STATUS_ERROR, "kexec load failed");
+	}
+
+no_load:
+	cleanup_load(task->image);
+	cleanup_load(task->initrd);
+	cleanup_load(task->dtb);
+
+	if (!rc) {
+		update_status(task->status_fn, task->status_arg,
+				BOOT_STATUS_INFO,
+				"performing kexec reboot");
+
+		rc = kexec_reboot(task);
+		if (rc) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_ERROR,
+					"kexec reboot failed");
+		}
+	}
+
+	talloc_free(task);
+}
+
 int boot(void *ctx, struct discover_boot_option *opt, struct boot_command *cmd,
 		int dry_run, boot_status_fn status_fn, void *status_arg)
 {
 	struct boot_task *boot_task;
-	struct pb_url *image, *initrd, *dtb;
-	unsigned int clean_image = 0;
-	unsigned int clean_initrd = 0;
-	unsigned int clean_dtb = 0;
-	int result;
+	struct pb_url *image = NULL;
+	const char *boot_desc;
+
+	if (opt && opt->option->name)
+		boot_desc = opt->option->name;
+	else if (cmd && cmd->boot_image_file)
+		boot_desc = cmd->boot_image_file;
+	else
+		boot_desc = "(unknown)";
 
-	image = NULL;
-	initrd = NULL;
-	dtb = NULL;
+	update_status(status_fn, status_arg, BOOT_STATUS_INFO,
+			"Booting %s.", boot_desc);
 
 	if (cmd && cmd->boot_image_file) {
 		image = pb_url_parse(opt, cmd->boot_image_file);
 	} else if (opt && opt->boot_image) {
 		image = opt->boot_image->url;
 	} else {
-		pb_log("%s: no image specified", __func__);
+		pb_log("%s: no image specified\n", __func__);
+		update_status(status_fn, status_arg, BOOT_STATUS_INFO,
+				"Boot failed: no image specified");
 		return -1;
 	}
 
 	boot_task = talloc_zero(ctx, struct boot_task);
+	boot_task->image_url = image;
 	boot_task->dry_run = dry_run;
+	boot_task->status_fn = status_fn;
+	boot_task->status_arg = status_arg;
+	boot_task->state = BOOT_STATE_INITIAL;
 
 	if (cmd && cmd->initrd_file) {
-		initrd = pb_url_parse(opt, cmd->initrd_file);
+		boot_task->initrd_url = pb_url_parse(opt, cmd->initrd_file);
 	} else if (opt && opt->initrd) {
-		initrd = opt->initrd->url;
+		boot_task->initrd_url = opt->initrd->url;
 	}
 
 	if (cmd && cmd->dtb_file) {
-		dtb = pb_url_parse(opt, cmd->dtb_file);
+		boot_task->dtb_url = pb_url_parse(opt, cmd->dtb_file);
 	} else if (opt && opt->dtb) {
-		dtb = opt->dtb->url;
+		boot_task->dtb_url = opt->dtb->url;
 	}
 
 	if (cmd && cmd->boot_args) {
@@ -320,72 +472,7 @@ int boot(void *ctx, struct discover_boot_option *opt, struct boot_command *cmd,
 		boot_task->args = NULL;
 	}
 
-	result = -1;
-
-	update_status(status_fn, status_arg, BOOT_STATUS_INFO,
-			"loading kernel");
-	boot_task->local_image = load_url(NULL, image, &clean_image);
-	if (!boot_task->local_image) {
-		update_status(status_fn, status_arg, BOOT_STATUS_ERROR,
-				"Couldn't load kernel image");
-		goto no_load;
-	}
-
-	if (initrd) {
-		update_status(status_fn, status_arg, BOOT_STATUS_INFO,
-				"loading initrd");
-		boot_task->local_initrd = load_url(NULL, initrd, &clean_initrd);
-		if (!boot_task->local_initrd) {
-			update_status(status_fn, status_arg, BOOT_STATUS_ERROR,
-					"Couldn't load initrd image");
-			goto no_load;
-		}
-	}
-
-	if (dtb) {
-		update_status(status_fn, status_arg, BOOT_STATUS_INFO,
-				"loading device tree");
-		boot_task->local_dtb = load_url(NULL, dtb, &clean_dtb);
-		if (!boot_task->local_dtb) {
-			update_status(status_fn, status_arg, BOOT_STATUS_ERROR,
-					"Couldn't load device tree");
-			goto no_load;
-		}
-	}
-
-	run_boot_hooks(boot_task, status_fn, status_arg);
-
-	update_status(status_fn, status_arg, BOOT_STATUS_INFO,
-			"performing kexec_load");
-
-	result = kexec_load(boot_task);
-
-	if (result) {
-		update_status(status_fn, status_arg, BOOT_STATUS_ERROR,
-				"kexec load failed");
-	}
+	boot_process(NULL, boot_task);
 
-no_load:
-	if (clean_image)
-		unlink(boot_task->local_image);
-	if (clean_initrd)
-		unlink(boot_task->local_initrd);
-	if (clean_dtb)
-		unlink(boot_task->local_dtb);
-
-	talloc_free(boot_task);
-
-	if (!result) {
-		update_status(status_fn, status_arg, BOOT_STATUS_INFO,
-				"performing kexec reboot");
-
-		result = kexec_reboot(boot_task->dry_run);
-
-		if (result) {
-			update_status(status_fn, status_arg, BOOT_STATUS_ERROR,
-					"kexec reboot failed");
-		}
-	}
-
-	return result;
+	return 0;
 }