if (strncmp(boot_console, "/dev/", strlen("/dev/")) != 0) {
/* We already have the full path */
stdout_path = talloc_strdup(ctx, boot_console);
- } else if (strstr(boot_console, "tty") != NULL) {
+ /* Check for a tty* console but don't accidentally catch
+ * ttyS* consoles */
+ } else if (strstr(boot_console, "tty") != NULL &&
+ strstr(boot_console, "ttyS") == NULL) {
fprintf(stderr, "TTY recognised: %s\n", boot_console);
stdout_path = get_vga_path(ctx);
} else {
return rc;
}
-
-int main(void)
+static int set_offb(struct offb_ctx *ctx)
{
- struct offb_ctx *ctx;
int rc;
- ctx = talloc_zero(NULL, struct offb_ctx);
-
- ctx->dtb_name = getenv("boot_dtb");
- if (!ctx->dtb_name) {
- talloc_free(ctx);
- return EXIT_SUCCESS;
- }
-
rc = load_dtb(ctx);
if (rc)
goto out;
rc = populate_devicetree(ctx);
if (rc)
goto out;
+out:
+ return rc;
+}
- rc = set_stdout(ctx);
- if (rc)
- goto out;
- rc = write_devicetree(ctx);
+int main(void)
+{
+ struct offb_ctx *ctx;
+ int rc;
+
+ ctx = talloc_zero(NULL, struct offb_ctx);
+
+ ctx->dtb_name = getenv("boot_dtb");
+ if (!ctx->dtb_name) {
+ talloc_free(ctx);
+ return EXIT_SUCCESS;
+ }
+
+ if (set_offb(ctx)) {
+ warn("Failed offb setup step");
+ rc = -1;
+ }
+
+ if (set_stdout(ctx)) {
+ warn("Failed stdout setup step\n");
+ rc = -1;
+ }
+
+ if (write_devicetree(ctx)) {
+ warn("Failed to write back device tree\n");
+ rc = -1;
+ }
-out:
talloc_free(ctx);
return rc ? EXIT_FAILURE : EXIT_SUCCESS;
}