pb-protocol: Don't allocate in deserialise functions

[petitboot] / ui / common / discover-client.c

diff --git a/ui/common/discover-client.c b/ui/common/discover-client.c
index f75cfb71822949d9f5533a2bd303519592a8b301..c0cfea0fe19a8ddae06d5b0546a2f6f504d6c369 100644 (file)
--- a/ui/common/discover-client.c
+++ b/ui/common/discover-client.c
@@ -83,6 +83,7 @@ static int discover_client_process(void *arg)
        struct pb_protocol_message *message;
        struct device *dev;
        char *dev_id;
+       int rc;
 
        message = pb_protocol_read_message(client, client->fd);
 
@@ -91,8 +92,10 @@ static int discover_client_process(void *arg)
 
        switch (message->action) {
        case PB_PROTOCOL_ACTION_ADD:
-               dev = pb_protocol_deserialise_device(client, message);
-               if (!dev) {
+               dev = talloc(client, struct device);
+
+               rc = pb_protocol_deserialise_device(dev, message);
+               if (rc) {
                        pb_log("%s: no device?\n", __func__);
                        return 0;
                }