Make submitter filter AJAX work in Firefox

[patchwork] / templates / patchwork / filters.html

diff --git a/templates/patchwork/filters.html b/templates/patchwork/filters.html
index 482bc9890a6effbe59c85d73e262f0fa7363aa73..ff4339ec5ec1d8edaf5ed7f12080c2c97f060fab 100644 (file)
--- a/templates/patchwork/filters.html
+++ b/templates/patchwork/filters.html
@@ -3,7 +3,7 @@
 var filterform_displayed = false;
 function filter_click()
 {
-    form = document.getElementById('filterform');
+    var form = document.getElementById('filterform');
     if (!form) {
         return;
     }
@@ -27,8 +27,8 @@ function filter_form_submit(form)
 {
     var i;
 
-    submitter_select = document.getElementById("submitter_select");
-    submitter_input = document.getElementById("submitter_input");
+    var submitter_select = document.getElementById("submitter_select");
+    var submitter_input = document.getElementById("submitter_input");
     if (!submitter_select || !submitter_input) {
         req = null;
         return;
@@ -92,15 +92,13 @@ function submitter_complete_response()
         return;
     }
 
-    submitter_select = document.getElementById("submitter_select");
-    submitter_input = document.getElementById("submitter_input");
+    var submitter_select = document.getElementById("submitter_select");
+    var submitter_input = document.getElementById("submitter_input");
     if (!submitter_select || !submitter_input) {
         req = null;
         return;
     }
 
-    submitter_select.options = [];
-
     for (i = 0; i < completions.length; i++) {
         name = completions[i]['fields']['name'];
         if (name) {
@@ -112,6 +110,12 @@ function submitter_complete_response()
         o = new Option(name, completions[i]['pk']);
         submitter_select.options[i] = o;
     }
+
+    /* remove remaining options */
+    for (; i < submitter_select.length; i++) {
+        submitter_select.options[i] = null;
+    }
+
     submitter_select.disabled = false;
     req = null;
 }