[sql] Perserve bundle ordering in bundle reorder migration script

[patchwork] / lib / sql / migration / 005-bundle-patch-ordering.sql

diff --git a/lib/sql/migration/005-bundle-patch-ordering.sql b/lib/sql/migration/005-bundle-patch-ordering.sql
index 9f5bcf3675807b18686491f8ec93d30faa32a7a5..238e37bcac11cca635bb86c4fd290a73c6a3adad 100644 (file)
--- a/lib/sql/migration/005-bundle-patch-ordering.sql
+++ b/lib/sql/migration/005-bundle-patch-ordering.sql
@@ -1,9 +1,32 @@
 BEGIN;
-ALTER TABLE patchwork_bundle_patches RENAME TO patchwork_bundlepatch;
-ALTER TABLE patchwork_bundlepatch ADD COLUMN "order" INTEGER NULL;
-UPDATE patchwork_bundlepatch SET "order" =
-    (SELECT COALESCE(max("order"), 0) + 1 FROM patchwork_bundlepatch AS p2
-        WHERE p2.bundle_id = patchwork_bundlepatch.bundle_id);
-ALTER TABLE patchwork_bundlepatch ALTER COLUMN "order" SET NOT NULL;
-ALTER TABLE patchwork_bundlepatch ADD UNIQUE("bundle_id", "order");
+CREATE TABLE "patchwork_bundlepatch" (                                          
+    "id" SERIAL NOT NULL PRIMARY KEY,
+    "patch_id" INTEGER NOT NULL
+        REFERENCES "patchwork_patch" ("id") DEFERRABLE INITIALLY DEFERRED,
+    "bundle_id" INTEGER NOT NULL
+        REFERENCES "patchwork_bundle" ("id") DEFERRABLE INITIALLY DEFERRED,
+    "order" SERIAL NOT NULL,
+    UNIQUE ("bundle_id", "patch_id")
+);
+
+-- we 'INSERT INTO ... SELECT' (rather than renaming and adding the order
+-- column) here so that we can order by date
+INSERT INTO patchwork_bundlepatch (id, patch_id, bundle_id)
+    SELECT patchwork_bundle_patches.id, patch_id, bundle_id
+        FROM patchwork_bundle_patches
+        INNER JOIN patchwork_patch
+            ON patchwork_patch.id = patchwork_bundle_patches.patch_id
+        ORDER BY bundle_id, patchwork_patch.date;
+COMMIT;
+
+BEGIN;
+ALTER TABLE patchwork_bundlepatch
+    ALTER COLUMN "order" TYPE INTEGER;
+
+-- normalise ordering: order should start with 1 in each bundle
+UPDATE patchwork_bundlepatch SET "order" = 1 + "order" -
+       (SELECT min("order") FROM patchwork_bundlepatch AS p2
+               WHERE p2.bundle_id = patchwork_bundlepatch.bundle_id);
+
+SELECT * FROM patchwork_bundlepatch;
 COMMIT;