From: Eivind Næss <eivnaes@yahoo.com>
Date: Mon, 20 Sep 2021 17:09:31 +0000 (-0700)
Subject: Fixing GCC unused result warning w.r.t. fchown() and fchmod() functions.
X-Git-Tag: ppp-2.5.0~56^2~14
X-Git-Url: http://git.ozlabs.org/?p=ppp.git;a=commitdiff_plain;h=6c74226a2521dbc22eb063676278473a7a9a640a

Fixing GCC unused result warning w.r.t. fchown() and fchmod() functions.

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
---

diff --git a/pppd/sys-linux.c b/pppd/sys-linux.c
index e1bb810..4c04e7e 100644
--- a/pppd/sys-linux.c
+++ b/pppd/sys-linux.c
@@ -3143,7 +3143,7 @@ int cif6addr (int unit, eui64_t our_eui64, eui64_t his_eui64)
 int
 get_pty(int *master_fdp, int *slave_fdp, char *slave_name, int uid)
 {
-    int i, mfd, sfd = -1;
+    int i, mfd, ret, sfd = -1;
     char pty_name[16];
     struct termios tios;
 
@@ -3181,8 +3181,14 @@ get_pty(int *master_fdp, int *slave_fdp, char *slave_name, int uid)
 		pty_name[5] = 't';
 		sfd = open(pty_name, O_RDWR | O_NOCTTY, 0);
 		if (sfd >= 0) {
-		    fchown(sfd, uid, -1);
-		    fchmod(sfd, S_IRUSR | S_IWUSR);
+		    ret = fchown(sfd, uid, -1);
+		    if (ret != 0) {
+			warn("Couldn't change ownership of %s, %m", pty_name);
+		    }
+		    ret = fchmod(sfd, S_IRUSR | S_IWUSR);
+		    if (ret != 0) {
+			warn("Couldn't change permissions of %s, %m", pty_name);
+		    }
 		    break;
 		}
 		close(mfd);