MD4Update takes bytes not bits! Now the regression test of the README.MSCHAP80

file works.

diff --git a/pppd/chap_ms.c b/pppd/chap_ms.c
index f58bafc15ff5117fc36bc6f58ceac0dd901c4fd3..114b951a40d936161cacde8904fcc0392a6db961 100644 (file)
--- a/pppd/chap_ms.c
+++ b/pppd/chap_ms.c
@@ -32,7 +32,7 @@
  */
 
 #ifndef lint
  */
 
 #ifndef lint

-static char rcsid[] = "$Id: chap_ms.c,v 1.10 1998/11/07 06:59:26 paulus Exp $";
+static char rcsid[] = "$Id: chap_ms.c,v 1.11 1998/11/24 19:30:38 christos Exp $";

 #endif
 
 #ifdef CHAPMS
 #endif
 
 #ifdef CHAPMS


@@ -272,7 +272,7 @@ ChapMS_NT(rchallenge, rchallenge_len, secret, secret_len, response)
        unicodePassword[i * 2] = (u_char)secret[i];
 
     MD4Init(&md4Context);
        unicodePassword[i * 2] = (u_char)secret[i];
 
     MD4Init(&md4Context);

-    MD4Update(&md4Context, unicodePassword, secret_len * 2 * 8);       /* Unicode is 2 bytes/char, *8 for bit count */
+    MD4Update(&md4Context, unicodePassword, secret_len * 2);

 
     MD4Final(hash, &md4Context);       /* Tell MD4 we're done */
 
 
     MD4Final(hash, &md4Context);       /* Tell MD4 we're done */