]> git.ozlabs.org Git - ppp.git/commit
radius: Fix list traversal in rc_avpair_insert
authorPaul Mackerras <paulus@ozlabs.org>
Sat, 18 Mar 2023 07:14:04 +0000 (18:14 +1100)
committerPaul Mackerras <paulus@ozlabs.org>
Sat, 18 Mar 2023 07:14:04 +0000 (18:14 +1100)
commitefb2667c252985004598625d357d3f4db7418964
tree1c919e48e895b779bea8464b643ced2d5206f2c7
parentacc6cd4aab0a98d090a5f239cee56c206a9be496
radius: Fix list traversal in rc_avpair_insert

In rc_avpair_insert, if the list element "p" is non-NULL but not
actually in the list "a", we can end up with this_node being NULL and
being dereferenced.

By changing the while test to this_node->next we avoid having
this_node being NULL; the loop will terminate when this_node == p or
this_node->next == NULL, which is what we want.

Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
pppd/plugins/radius/avpair.c