]> git.ozlabs.org Git - ppp.git/blobdiff - pppd/ccp.c
Support old draft rfc deflate number as well as new.
[ppp.git] / pppd / ccp.c
index 836d5064af309e9aac2eab923afeeeb944f208d0..6d328b762d3c985df5d8523cc3ee87dd00a47d07 100644 (file)
  */
 
 #ifndef lint
-static char rcsid[] = "$Id: ccp.c,v 1.13 1995/12/18 03:43:40 paulus Exp $";
+static char rcsid[] = "$Id: ccp.c,v 1.22 1998/03/25 01:25:02 paulus Exp $";
 #endif
 
+#include <string.h>
 #include <syslog.h>
 #include <sys/ioctl.h>
-#include <net/ppp-comp.h>
+#include <sys/types.h>
 
 #include "pppd.h"
 #include "fsm.h"
 #include "ccp.h"
+#include <net/ppp-comp.h>
+
+/*
+ * Protocol entry points from main code.
+ */
+static void ccp_init __P((int unit));
+static void ccp_open __P((int unit));
+static void ccp_close __P((int unit, char *));
+static void ccp_lowerup __P((int unit));
+static void ccp_lowerdown __P((int));
+static void ccp_input __P((int unit, u_char *pkt, int len));
+static void ccp_protrej __P((int unit));
+static int  ccp_printpkt __P((u_char *pkt, int len,
+                             void (*printer) __P((void *, char *, ...)),
+                             void *arg));
+static void ccp_datainput __P((int unit, u_char *pkt, int len));
 
 struct protent ccp_protent = {
-    PPP_CCP, ccp_init, ccp_input, ccp_protrej,
-    ccp_lowerup, ccp_lowerdown, ccp_open, ccp_close,
-    ccp_printpkt, NULL, 1, "CCP"
+    PPP_CCP,
+    ccp_init,
+    ccp_input,
+    ccp_protrej,
+    ccp_lowerup,
+    ccp_lowerdown,
+    ccp_open,
+    ccp_close,
+    ccp_printpkt,
+    ccp_datainput,
+    1,
+    "CCP",
+    NULL,
+    NULL,
+    NULL
 };
 
 fsm ccp_fsm[NUM_PPP];
@@ -62,7 +91,8 @@ static int  ccp_reqci __P((fsm *, u_char *, int *, int));
 static void ccp_up __P((fsm *));
 static void ccp_down __P((fsm *));
 static int  ccp_extcode __P((fsm *, int, int, u_char *, int));
-static void ccp_rack_timeout __P(());
+static void ccp_rack_timeout __P((void *));
+static char *method_name __P((ccp_options *, ccp_options *));
 
 static fsm_callbacks ccp_callbacks = {
     ccp_resetci,
@@ -102,7 +132,7 @@ static int all_rejected[NUM_PPP];   /* we rejected all peer's options */
 /*
  * ccp_init - initialize CCP.
  */
-void
+static void
 ccp_init(unit)
     int unit;
 {
@@ -118,9 +148,17 @@ ccp_init(unit)
     memset(&ccp_allowoptions[unit], 0, sizeof(ccp_options));
     memset(&ccp_hisoptions[unit],   0, sizeof(ccp_options));
 
-    ccp_wantoptions[0].bsd_compress = 1;
-    ccp_wantoptions[0].bsd_bits = 12;  /* default value */
+    ccp_wantoptions[0].deflate = 1;
+    ccp_wantoptions[0].deflate_size = DEFLATE_MAX_SIZE;
+    ccp_wantoptions[0].deflate_correct = 1;
+    ccp_wantoptions[0].deflate_draft = 1;
+    ccp_allowoptions[0].deflate = 1;
+    ccp_allowoptions[0].deflate_size = DEFLATE_MAX_SIZE;
+    ccp_allowoptions[0].deflate_correct = 1;
+    ccp_allowoptions[0].deflate_draft = 1;
 
+    ccp_wantoptions[0].bsd_compress = 1;
+    ccp_wantoptions[0].bsd_bits = BSD_MAX_BITS;
     ccp_allowoptions[0].bsd_compress = 1;
     ccp_allowoptions[0].bsd_bits = BSD_MAX_BITS;
 
@@ -130,7 +168,7 @@ ccp_init(unit)
 /*
  * ccp_open - CCP is allowed to come up.
  */
-void
+static void
 ccp_open(unit)
     int unit;
 {
@@ -138,15 +176,22 @@ ccp_open(unit)
 
     if (f->state != OPENED)
        ccp_flags_set(unit, 1, 0);
-    if (!ANY_COMPRESS(ccp_wantoptions[unit]))
+
+    /*
+     * Find out which compressors the kernel supports before
+     * deciding whether to open in silent mode.
+     */
+    ccp_resetci(f);
+    if (!ANY_COMPRESS(ccp_gotoptions[unit]))
        f->flags |= OPT_SILENT;
+
     fsm_open(f);
 }
 
 /*
  * ccp_close - Terminate CCP.
  */
-void
+static void
 ccp_close(unit, reason)
     int unit;
     char *reason;
@@ -158,7 +203,7 @@ ccp_close(unit, reason)
 /*
  * ccp_lowerup - we may now transmit CCP packets.
  */
-void
+static void
 ccp_lowerup(unit)
     int unit;
 {
@@ -168,7 +213,7 @@ ccp_lowerup(unit)
 /*
  * ccp_lowerdown - we may not transmit CCP packets.
  */
-void
+static void
 ccp_lowerdown(unit)
     int unit;
 {
@@ -178,7 +223,7 @@ ccp_lowerdown(unit)
 /*
  * ccp_input - process a received CCP packet.
  */
-void
+static void
 ccp_input(unit, p, len)
     int unit;
     u_char *p;
@@ -226,7 +271,7 @@ ccp_extcode(f, code, id, p, len)
     case CCP_RESETACK:
        if (ccp_localstate[f->unit] & RACK_PENDING && id == f->reqid) {
            ccp_localstate[f->unit] &= ~(RACK_PENDING | RREQ_REPEAT);
-           UNTIMEOUT(ccp_rack_timeout, (caddr_t) f);
+           UNTIMEOUT(ccp_rack_timeout, f);
        }
        break;
 
@@ -240,7 +285,7 @@ ccp_extcode(f, code, id, p, len)
 /*
  * ccp_protrej - peer doesn't talk CCP.
  */
-void
+static void
 ccp_protrej(unit)
     int unit;
 {
@@ -255,7 +300,6 @@ static void
 ccp_resetci(f)
     fsm *f;
 {
-    int ok;
     ccp_options *go = &ccp_gotoptions[f->unit];
     u_char opt_buf[16];
 
@@ -274,11 +318,23 @@ ccp_resetci(f)
            go->bsd_compress = 0;
     }
     if (go->deflate) {
-       opt_buf[0] = CI_DEFLATE;
-       opt_buf[1] = CILEN_DEFLATE;
-       opt_buf[2] = DEFLATE_MAKE_OPT(DEFLATE_MIN_SIZE);
-       opt_buf[3] = DEFLATE_CHK_SEQUENCE;
-       if (ccp_test(f->unit, opt_buf, CILEN_DEFLATE, 0) <= 0)
+       if (go->deflate_correct) {
+           opt_buf[0] = CI_DEFLATE;
+           opt_buf[1] = CILEN_DEFLATE;
+           opt_buf[2] = DEFLATE_MAKE_OPT(DEFLATE_MIN_SIZE);
+           opt_buf[3] = DEFLATE_CHK_SEQUENCE;
+           if (ccp_test(f->unit, opt_buf, CILEN_DEFLATE, 0) <= 0)
+               go->deflate_correct = 0;
+       }
+       if (go->deflate_draft) {
+           opt_buf[0] = CI_DEFLATE_DRAFT;
+           opt_buf[1] = CILEN_DEFLATE;
+           opt_buf[2] = DEFLATE_MAKE_OPT(DEFLATE_MIN_SIZE);
+           opt_buf[3] = DEFLATE_CHK_SEQUENCE;
+           if (ccp_test(f->unit, opt_buf, CILEN_DEFLATE, 0) <= 0)
+               go->deflate_draft = 0;
+       }
+       if (!go->deflate_correct && !go->deflate_draft)
            go->deflate = 0;
     }
     if (go->predictor_1) {
@@ -329,7 +385,7 @@ ccp_addci(f, p, lenp)
      * in case it gets Acked.
      */
     if (go->deflate) {
-       p[0] = CI_DEFLATE;
+       p[0] = go->deflate_correct? CI_DEFLATE: CI_DEFLATE_DRAFT;
        p[1] = CILEN_DEFLATE;
        p[2] = DEFLATE_MAKE_OPT(go->deflate_size);
        p[3] = DEFLATE_CHK_SEQUENCE;
@@ -346,6 +402,13 @@ ccp_addci(f, p, lenp)
            --go->deflate_size;
            p[2] = DEFLATE_MAKE_OPT(go->deflate_size);
        }
+       if (p != p0 && go->deflate_correct && go->deflate_draft) {
+           p[0] = CI_DEFLATE_DRAFT;
+           p[1] = CILEN_DEFLATE;
+           p[2] = p[2 - CILEN_DEFLATE];
+           p[3] = DEFLATE_CHK_SEQUENCE;
+           p += CILEN_DEFLATE;
+       }
     }
     if (go->bsd_compress) {
        p[0] = CI_BSD_COMPRESS;
@@ -389,6 +452,8 @@ ccp_addci(f, p, lenp)
        }
     }
 
+    go->method = (p > p0)? p0[0]: -1;
+
     *lenp = p - p0;
 }
 
@@ -407,7 +472,8 @@ ccp_ackci(f, p, len)
 
     if (go->deflate) {
        if (len < CILEN_DEFLATE
-           || p[0] != CI_DEFLATE || p[1] != CILEN_DEFLATE
+           || p[0] != (go->deflate_correct? CI_DEFLATE: CI_DEFLATE_DRAFT)
+           || p[1] != CILEN_DEFLATE
            || p[2] != DEFLATE_MAKE_OPT(go->deflate_size)
            || p[3] != DEFLATE_CHK_SEQUENCE)
            return 0;
@@ -416,6 +482,16 @@ ccp_ackci(f, p, len)
        /* XXX Cope with first/fast ack */
        if (len == 0)
            return 1;
+       if (go->deflate_correct && go->deflate_draft) {
+           if (len < CILEN_DEFLATE
+               || p[0] != CI_DEFLATE_DRAFT
+               || p[1] != CILEN_DEFLATE
+               || p[2] != DEFLATE_MAKE_OPT(go->deflate_size)
+               || p[3] != DEFLATE_CHK_SEQUENCE)
+               return 0;
+           p += CILEN_DEFLATE;
+           len -= CILEN_DEFLATE;
+       }
     }
     if (go->bsd_compress) {
        if (len < CILEN_BSD_COMPRESS
@@ -472,7 +548,8 @@ ccp_nakci(f, p, len)
     try = *go;
 
     if (go->deflate && len >= CILEN_DEFLATE
-       && p[0] == CI_DEFLATE && p[1] == CILEN_DEFLATE) {
+       && p[0] == (go->deflate_correct? CI_DEFLATE: CI_DEFLATE_DRAFT)
+       && p[1] == CILEN_DEFLATE) {
        no.deflate = 1;
        /*
         * Peer wants us to use a different code size or something.
@@ -483,9 +560,15 @@ ccp_nakci(f, p, len)
            || p[3] != DEFLATE_CHK_SEQUENCE)
            try.deflate = 0;
        else if (DEFLATE_SIZE(p[2]) < go->deflate_size)
-           go->deflate_size = DEFLATE_SIZE(p[2]);
+           try.deflate_size = DEFLATE_SIZE(p[2]);
        p += CILEN_DEFLATE;
        len -= CILEN_DEFLATE;
+       if (go->deflate_correct && go->deflate_draft
+           && len >= CILEN_DEFLATE && p[0] == CI_DEFLATE_DRAFT
+           && p[1] == CILEN_DEFLATE) {
+           p += CILEN_DEFLATE;
+           len -= CILEN_DEFLATE;
+       }
     }
 
     if (go->bsd_compress && len >= CILEN_BSD_COMPRESS
@@ -539,13 +622,29 @@ ccp_rejci(f, p, len)
        return -1;
 
     if (go->deflate && len >= CILEN_DEFLATE
-       && p[0] == CI_DEFLATE && p[1] == CILEN_DEFLATE) {
+       && p[0] == (go->deflate_correct? CI_DEFLATE: CI_DEFLATE_DRAFT)
+       && p[1] == CILEN_DEFLATE) {
        if (p[2] != DEFLATE_MAKE_OPT(go->deflate_size)
            || p[3] != DEFLATE_CHK_SEQUENCE)
            return 0;           /* Rej is bad */
-       try.deflate = 0;
+       if (go->deflate_correct)
+           try.deflate_correct = 0;
+       else
+           try.deflate_draft = 0;
        p += CILEN_DEFLATE;
        len -= CILEN_DEFLATE;
+       if (go->deflate_correct && go->deflate_draft
+           && len >= CILEN_DEFLATE && p[0] == CI_DEFLATE_DRAFT
+           && p[1] == CILEN_DEFLATE) {
+           if (p[2] != DEFLATE_MAKE_OPT(go->deflate_size)
+               || p[3] != DEFLATE_CHK_SEQUENCE)
+               return 0;               /* Rej is bad */
+           try.deflate_draft = 0;
+           p += CILEN_DEFLATE;
+           len -= CILEN_DEFLATE;
+       }
+       if (!try.deflate_correct && !try.deflate_draft)
+           try.deflate = 0;
     }
     if (go->bsd_compress && len >= CILEN_BSD_COMPRESS
        && p[0] == CI_BSD_COMPRESS && p[1] == CILEN_BSD_COMPRESS) {
@@ -600,6 +699,7 @@ ccp_reqci(f, p, lenp, dont_nak)
     len = *lenp;
 
     memset(ho, 0, sizeof(ccp_options));
+    ho->method = (len > 0)? p[0]: -1;
 
     while (len > 0) {
        newret = CONFACK;
@@ -614,7 +714,10 @@ ccp_reqci(f, p, lenp, dont_nak)
 
            switch (type) {
            case CI_DEFLATE:
-               if (!ao->deflate || clen != CILEN_DEFLATE) {
+           case CI_DEFLATE_DRAFT:
+               if (!ao->deflate || clen != CILEN_DEFLATE
+                   || (!ao->deflate_correct && type == CI_DEFLATE)
+                   || (!ao->deflate_draft && type == CI_DEFLATE_DRAFT)) {
                    newret = CONFREJ;
                    break;
                }
@@ -623,38 +726,35 @@ ccp_reqci(f, p, lenp, dont_nak)
                ho->deflate_size = nb = DEFLATE_SIZE(p[2]);
                if (DEFLATE_METHOD(p[2]) != DEFLATE_METHOD_VAL
                    || p[3] != DEFLATE_CHK_SEQUENCE
-                   || nb > ao->deflate_size) {
+                   || nb > ao->deflate_size || nb < DEFLATE_MIN_SIZE) {
                    newret = CONFNAK;
-                   nb = ao->deflate_size;
-               } else {
-                   /*
-                    * Check whether we can do Deflate with the window
-                    * size they want.  If the window is too big, reduce
-                    * it until the kernel can cope and nak with that.
-                    */
+                   if (!dont_nak) {
+                       p[2] = DEFLATE_MAKE_OPT(ao->deflate_size);
+                       p[3] = DEFLATE_CHK_SEQUENCE;
+                       /* fall through to test this #bits below */
+                   } else
+                       break;
+               }
+
+               /*
+                * Check whether we can do Deflate with the window
+                * size they want.  If the window is too big, reduce
+                * it until the kernel can cope and nak with that.
+                * We only check this for the first option.
+                */
+               if (p == p0) {
                    for (;;) {
-                       if (nb < DEFLATE_MIN_SIZE) {
+                       res = ccp_test(f->unit, p, CILEN_DEFLATE, 1);
+                       if (res > 0)
+                           break;              /* it's OK now */
+                       if (res < 0 || nb == DEFLATE_MIN_SIZE || dont_nak) {
                            newret = CONFREJ;
                            p[2] = DEFLATE_MAKE_OPT(ho->deflate_size);
                            break;
                        }
-                       p[2] = DEFLATE_MAKE_OPT(nb);
-                       res = ccp_test(f->unit, p, CILEN_DEFLATE, 1);
-                       if (res != 0) {
-                           if (res < 0)
-                               newret = CONFREJ;
-                           break;
-                       }
                        newret = CONFNAK;
                        --nb;
-                   }
-               }
-               if (newret == CONFNAK && !dont_nak) {
-                   if (nb >= DEFLATE_MIN_SIZE) {
                        p[2] = DEFLATE_MAKE_OPT(nb);
-                       p[3] = DEFLATE_CHK_SEQUENCE;
-                   } else {
-                       newret = CONFREJ;
                    }
                }
                break;
@@ -668,38 +768,35 @@ ccp_reqci(f, p, lenp, dont_nak)
                ho->bsd_compress = 1;
                ho->bsd_bits = nb = BSD_NBITS(p[2]);
                if (BSD_VERSION(p[2]) != BSD_CURRENT_VERSION
-                   || nb > ao->bsd_bits) {
+                   || nb > ao->bsd_bits || nb < BSD_MIN_BITS) {
                    newret = CONFNAK;
-                   nb = ao->bsd_bits;
-               } else {
-                   /*
-                    * Check whether we can do BSD_Compress with the code
-                    * size they want.  If the code size is too big, reduce
-                    * it until the kernel can cope and nak with that.
-                    */
+                   if (!dont_nak) {
+                       p[2] = BSD_MAKE_OPT(BSD_CURRENT_VERSION, ao->bsd_bits);
+                       /* fall through to test this #bits below */
+                   } else
+                       break;
+               }
+
+               /*
+                * Check whether we can do BSD-Compress with the code
+                * size they want.  If the code size is too big, reduce
+                * it until the kernel can cope and nak with that.
+                * We only check this for the first option.
+                */
+               if (p == p0) {
                    for (;;) {
-                       if (nb < BSD_MIN_BITS) {
+                       res = ccp_test(f->unit, p, CILEN_BSD_COMPRESS, 1);
+                       if (res > 0)
+                           break;
+                       if (res < 0 || nb == BSD_MIN_BITS || dont_nak) {
                            newret = CONFREJ;
                            p[2] = BSD_MAKE_OPT(BSD_CURRENT_VERSION,
                                                ho->bsd_bits);
                            break;
                        }
-                       p[2] = BSD_MAKE_OPT(BSD_CURRENT_VERSION, nb);
-                       res = ccp_test(f->unit, p, CILEN_BSD_COMPRESS, 1);
-                       if (res != 0) {
-                           if (res < 0)
-                               newret = CONFREJ;
-                           break;
-                       }
                        newret = CONFNAK;
                        --nb;
-                   }
-               }
-               if (newret == CONFNAK && !dont_nak) {
-                   if (nb >= BSD_MIN_BITS) {
                        p[2] = BSD_MAKE_OPT(BSD_CURRENT_VERSION, nb);
-                   } else {
-                       newret = CONFREJ;
                    }
                }
                break;
@@ -711,7 +808,8 @@ ccp_reqci(f, p, lenp, dont_nak)
                }
 
                ho->predictor_1 = 1;
-               if (ccp_test(f->unit, p, CILEN_PREDICTOR_1, 1) <= 0) {
+               if (p == p0
+                   && ccp_test(f->unit, p, CILEN_PREDICTOR_1, 1) <= 0) {
                    newret = CONFREJ;
                }
                break;
@@ -723,7 +821,8 @@ ccp_reqci(f, p, lenp, dont_nak)
                }
 
                ho->predictor_2 = 1;
-               if (ccp_test(f->unit, p, CILEN_PREDICTOR_2, 1) <= 0) {
+               if (p == p0
+                   && ccp_test(f->unit, p, CILEN_PREDICTOR_2, 1) <= 0) {
                    newret = CONFREJ;
                }
                break;
@@ -735,7 +834,7 @@ ccp_reqci(f, p, lenp, dont_nak)
 
        if (newret == CONFNAK && dont_nak)
            newret = CONFREJ;
-       if (!(newret == CONFACK || newret == CONFNAK && ret == CONFREJ)) {
+       if (!(newret == CONFACK || (newret == CONFNAK && ret == CONFREJ))) {
            /* we're returning this option */
            if (newret == CONFREJ && ret == CONFNAK)
                retp = p0;
@@ -759,7 +858,47 @@ ccp_reqci(f, p, lenp, dont_nak)
 }
 
 /*
- * CCP has come up - inform the kernel driver.
+ * Make a string name for a compression method (or 2).
+ */
+static char *
+method_name(opt, opt2)
+    ccp_options *opt, *opt2;
+{
+    static char result[64];
+
+    if (!ANY_COMPRESS(*opt))
+       return "(none)";
+    switch (opt->method) {
+    case CI_DEFLATE:
+    case CI_DEFLATE_DRAFT:
+       if (opt2 != NULL && opt2->deflate_size != opt->deflate_size)
+           sprintf(result, "Deflate%s (%d/%d)",
+                   (opt->method == CI_DEFLATE_DRAFT? "(old#)": ""),
+                   opt->deflate_size, opt2->deflate_size);
+       else
+           sprintf(result, "Deflate%s (%d)",
+                   (opt->method == CI_DEFLATE_DRAFT? "(old#)": ""),
+                   opt->deflate_size);
+       break;
+    case CI_BSD_COMPRESS:
+       if (opt2 != NULL && opt2->bsd_bits != opt->bsd_bits)
+           sprintf(result, "BSD-Compress (%d/%d)", opt->bsd_bits,
+                   opt2->bsd_bits);
+       else
+           sprintf(result, "BSD-Compress (%d)", opt->bsd_bits);
+       break;
+    case CI_PREDICTOR_1:
+       return "Predictor 1";
+    case CI_PREDICTOR_2:
+       return "Predictor 2";
+    default:
+       sprintf(result, "Method %d", opt->method);
+    }
+    return result;
+}
+
+/*
+ * CCP has come up - inform the kernel driver and log a message.
  */
 static void
 ccp_up(f)
@@ -767,12 +906,25 @@ ccp_up(f)
 {
     ccp_options *go = &ccp_gotoptions[f->unit];
     ccp_options *ho = &ccp_hisoptions[f->unit];
+    char method1[64];
 
     ccp_flags_set(f->unit, 1, 1);
-    if (ANY_COMPRESS(*go) || ANY_COMPRESS(*ho))
-       syslog(LOG_NOTICE, "%s enabled",
-              ANY_COMPRESS(*go)? ANY_COMPRESS(*ho)? "Compression":
-              "Receive compression": "Transmit compression");
+    if (ANY_COMPRESS(*go)) {
+       if (ANY_COMPRESS(*ho)) {
+           if (go->method == ho->method) {
+               syslog(LOG_NOTICE, "%s compression enabled",
+                      method_name(go, ho));
+           } else {
+               strcpy(method1, method_name(go, NULL));
+               syslog(LOG_NOTICE, "%s / %s compression enabled",
+                      method1, method_name(ho, NULL));
+           }
+       } else
+           syslog(LOG_NOTICE, "%s receive compression enabled",
+                  method_name(go, NULL));
+    } else if (ANY_COMPRESS(*ho))
+       syslog(LOG_NOTICE, "%s transmit compression enabled",
+              method_name(ho, NULL));
 }
 
 /*
@@ -783,7 +935,7 @@ ccp_down(f)
     fsm *f;
 {
     if (ccp_localstate[f->unit] & RACK_PENDING)
-       UNTIMEOUT(ccp_rack_timeout, (caddr_t) f);
+       UNTIMEOUT(ccp_rack_timeout, f);
     ccp_localstate[f->unit] = 0;
     ccp_flags_set(f->unit, 1, 0);
 }
@@ -791,14 +943,14 @@ ccp_down(f)
 /*
  * Print the contents of a CCP packet.
  */
-char *ccp_codenames[] = {
+static char *ccp_codenames[] = {
     "ConfReq", "ConfAck", "ConfNak", "ConfRej",
     "TermReq", "TermAck", "CodeRej",
     NULL, NULL, NULL, NULL, NULL, NULL,
     "ResetReq", "ResetAck",
 };
 
-int
+static int
 ccp_printpkt(p, plen, printer, arg)
     u_char *p;
     int plen;
@@ -843,8 +995,11 @@ ccp_printpkt(p, plen, printer, arg)
            optend = p + optlen;
            switch (code) {
            case CI_DEFLATE:
+           case CI_DEFLATE_DRAFT:
                if (optlen >= CILEN_DEFLATE) {
-                   printer(arg, "deflate %d", DEFLATE_SIZE(p[2]));
+                   printer(arg, "deflate%s %d",
+                           (code == CI_DEFLATE_DRAFT? "(old#)": ""),
+                           DEFLATE_SIZE(p[2]));
                    if (DEFLATE_METHOD(p[2]) != DEFLATE_METHOD_VAL)
                        printer(arg, " method %d", DEFLATE_METHOD(p[2]));
                    if (p[3] != DEFLATE_CHK_SEQUENCE)
@@ -877,6 +1032,15 @@ ccp_printpkt(p, plen, printer, arg)
            printer(arg, ">");
        }
        break;
+
+    case TERMACK:
+    case TERMREQ:
+       if (len > 0 && *p >= ' ' && *p < 0x7f) {
+           print_string(p, len, printer, arg);
+           p += len;
+           len = 0;
+       }
+       break;
     }
 
     /* dump out the rest of the packet in hex */
@@ -898,7 +1062,7 @@ ccp_printpkt(p, plen, printer, arg)
  * decompression; if it was, we take CCP down, thus disabling
  * compression :-(, otherwise we issue the reset-request.
  */
-void
+static void
 ccp_datainput(unit, pkt, len)
     int unit;
     u_char *pkt;
@@ -922,7 +1086,7 @@ ccp_datainput(unit, pkt, len)
             */
            if (!(ccp_localstate[f->unit] & RACK_PENDING)) {
                fsm_sdata(f, CCP_RESETREQ, f->reqid = ++f->id, NULL, 0);
-               TIMEOUT(ccp_rack_timeout, (caddr_t) f, RACKTIMEOUT);
+               TIMEOUT(ccp_rack_timeout, f, RACKTIMEOUT);
                ccp_localstate[f->unit] |= RACK_PENDING;
            } else
                ccp_localstate[f->unit] |= RREQ_REPEAT;
@@ -935,13 +1099,13 @@ ccp_datainput(unit, pkt, len)
  */
 static void
 ccp_rack_timeout(arg)
-    caddr_t arg;
+    void *arg;
 {
-    fsm *f = (fsm *) arg;
+    fsm *f = arg;
 
     if (f->state == OPENED && ccp_localstate[f->unit] & RREQ_REPEAT) {
        fsm_sdata(f, CCP_RESETREQ, f->reqid, NULL, 0);
-       TIMEOUT(ccp_rack_timeout, (caddr_t) f, RACKTIMEOUT);
+       TIMEOUT(ccp_rack_timeout, f, RACKTIMEOUT);
        ccp_localstate[f->unit] &= ~RREQ_REPEAT;
     } else
        ccp_localstate[f->unit] &= ~RACK_PENDING;