From 8cfcec4279b229dacfb0589bc443f8a4cbd83082 Mon Sep 17 00:00:00 2001 From: Samuel Mendoza-Jonas Date: Wed, 11 Nov 2015 16:58:59 +1100 Subject: [PATCH 1/1] discover: Skip malformed bootdev fields Fixes Coverity defect #30471 Signed-off-by: Samuel Mendoza-Jonas --- discover/platform-powerpc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/discover/platform-powerpc.c b/discover/platform-powerpc.c index 2480b8d..7370d7d 100644 --- a/discover/platform-powerpc.c +++ b/discover/platform-powerpc.c @@ -438,7 +438,6 @@ static void populate_bootdev_config(struct platform_powerpc *platform, { struct autoboot_option *opt, *new = NULL; char *pos, *end, *old_dev = NULL; - const char delim = ' '; unsigned int n_new = 0; const char *val; bool conflict; @@ -469,11 +468,9 @@ static void populate_bootdev_config(struct platform_powerpc *platform, if (read_bootdev(config, &pos, opt)) { pb_log("bootdev config is in an unknown format " - "(expected uuid:... or mac:...)"); + "(expected uuid:... or mac:...)\n"); talloc_free(opt); - if (strchr(pos, delim)) - continue; - return; + continue; } new = talloc_realloc(config, new, struct autoboot_option, -- 2.39.2