From 8c8fd93738a5d589b52a3791cd231e6661322b76 Mon Sep 17 00:00:00 2001 From: Jeremy Kerr Date: Thu, 14 Nov 2013 14:54:34 +1100 Subject: [PATCH] discover: Use mkstemp rather than tempnam We're getting warnings from some compilers about tempnam being unsafe. Signed-off-by: Jeremy Kerr --- discover/paths.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/discover/paths.c b/discover/paths.c index aa977fd..64b218e 100644 --- a/discover/paths.c +++ b/discover/paths.c @@ -46,15 +46,17 @@ char *join_paths(void *alloc_ctx, const char *a, const char *b) static char *local_name(void *ctx) { - char *tmp, *ret; + char *ret, tmp[] = "/tmp/pb-XXXXXX"; + int fd; - tmp = tempnam(NULL, "pb-"); + fd = mkstemp(tmp); - if (!tmp) + if (fd < 0) return NULL; + close(fd); + ret = talloc_strdup(ctx, tmp); - free(tmp); return ret; } -- 2.39.2