From: Jeremy Kerr Date: Wed, 30 Sep 2015 00:38:36 +0000 (+0800) Subject: discover/ipmi: Increase IPMI timeout to a reasonable value X-Git-Tag: v1.0.0~38 X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=commitdiff_plain;h=d171258160f7ed4756531f51e66fb116753bc990;hp=420f0e2c5d8338b42047c58f055cdb944685ead7 discover/ipmi: Increase IPMI timeout to a reasonable value We've seen some IPMI timeouts during testing - meaning that an IPMI bootdev setting will be ignored. This can result in a machine booting from an incorrect boot device, or missing a 'safe mode' indication, or incorrectly proceeding past petitboot. The firmware & kernel has its own timeout & retry mechanism, so we already have a little error-recovery there; the timeout in petitboot is to prevent an indefinite block if the kernel interface isn't behaving correctly. So, this change bumps the timeout to a value that suits BMCs we've seen in the field (specifying a 2 second timeout, with one retry). Signed-off-by: Jeremy Kerr --- diff --git a/discover/platform-powerpc.c b/discover/platform-powerpc.c index d45cced..23e63c1 100644 --- a/discover/platform-powerpc.c +++ b/discover/platform-powerpc.c @@ -22,7 +22,7 @@ static const char *partition = "common"; static const char *sysparams_dir = "/sys/firmware/opal/sysparams/"; static const char *devtree_dir = "/proc/device-tree/"; -static const int ipmi_timeout = 500; /* milliseconds */ +static const int ipmi_timeout = 5000; /* milliseconds. */ struct param { char *name;