From: Samuel Mendoza-Jonas Date: Tue, 6 Mar 2018 05:44:44 +0000 (+1100) Subject: discover/boot: Fix stale boot cancellation code X-Git-Tag: v1.7.1^0 X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=commitdiff_plain;h=c208aa42024fddc74682742bec12735e432a5510;hp=c208aa42024fddc74682742bec12735e432a5510 discover/boot: Fix stale boot cancellation code In dc85de97 "Allow load_async_url() to call callback for local paths" several load_url_result fields of the boot_task struct were deprecated but were accidentally left in the struct. This caused the now out of date code in cleanup_cancellations() to go unnoticed since it can return safely if these fields are NULL. However freeing the boot task can free the memory associated with each load before it is complete, resulting in a confusing segfault. This brings cleanup_cancellations() up to date and along the way implicitly includes the signature resources in cleanup which were missed originally. Signed-off-by: Samuel Mendoza-Jonas ---