From: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Date: Thu, 26 Jul 2018 01:50:33 +0000 (+1000)
Subject: discover/paths: Cleanup res after getaddrinfo
X-Git-Tag: v1.9.0~44
X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=commitdiff_plain;h=a244dded2d86be83b1c49ec5ab1343b8dc5b63f3

discover/paths: Cleanup res after getaddrinfo

Fixes Coverity defect #187192.

Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
---

diff --git a/discover/paths.c b/discover/paths.c
index 174bdae..e30f032 100644
--- a/discover/paths.c
+++ b/discover/paths.c
@@ -586,12 +586,14 @@ struct load_url_result *load_url_async(void *ctx, struct pb_url *url,
 
 	/* If the url is remote but network is not yet available queue up this
 	 * load for later */
-	if (url->scheme != pb_url_file &&
-			getaddrinfo(url->host, NULL, NULL, &res) != 0) {
-		pb_log("load task for %s queued pending network\n", url->full);
-		pending_network_jobs_add(task, flags);
-		task->result->status = LOAD_ASYNC;
-		return task->result;
+	if (url->scheme != pb_url_file) {
+		if (getaddrinfo(url->host, NULL, NULL, &res) != 0) {
+			pb_log("load task for %s queued pending network\n", url->full);
+			pending_network_jobs_add(task, flags);
+			task->result->status = LOAD_ASYNC;
+			return task->result;
+		}
+		freeaddrinfo(res);
 	}
 
 	switch (url->scheme) {