From: Samuel Mendoza-Jonas <sam.mj@au1.ibm.com>
Date: Fri, 18 Dec 2015 02:51:00 +0000 (+1100)
Subject: ui/common: Only close valid file descriptor
X-Git-Tag: v1.0.0~28
X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=commitdiff_plain;h=90cd56cb816e7045b41542c119f64b9ee349a6bc;ds=sidebyside

ui/common: Only close valid file descriptor

Fixes Coverity defect #30466

Signed-off-by: Sam Mendoza-Jonas <sam@mendozajonas.com>
---

diff --git a/ui/common/joystick.c b/ui/common/joystick.c
index 455ff19..a3d6abd 100644
--- a/ui/common/joystick.c
+++ b/ui/common/joystick.c
@@ -98,8 +98,8 @@ struct pjs *pjs_init(void *ctx, int (*map)(const struct js_event *))
 	return pjs;
 
 out_err:
-	close(pjs->fd);
-	pjs->fd = 0;
+	if (pjs->fd >= 0)
+		close(pjs->fd);
 	talloc_free(pjs);
 	return NULL;
 }