From: Jeremy Kerr <jk@ozlabs.org>
Date: Thu, 14 Nov 2013 03:54:34 +0000 (+1100)
Subject: discover: Use mkstemp rather than tempnam
X-Git-Tag: v1.0.0~332
X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=commitdiff_plain;h=8c8fd93738a5d589b52a3791cd231e6661322b76;ds=inline

discover: Use mkstemp rather than tempnam

We're getting warnings from some compilers about tempnam being unsafe.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
---

diff --git a/discover/paths.c b/discover/paths.c
index aa977fd..64b218e 100644
--- a/discover/paths.c
+++ b/discover/paths.c
@@ -46,15 +46,17 @@ char *join_paths(void *alloc_ctx, const char *a, const char *b)
 
 static char *local_name(void *ctx)
 {
-	char *tmp, *ret;
+	char *ret, tmp[] = "/tmp/pb-XXXXXX";
+	int fd;
 
-	tmp = tempnam(NULL, "pb-");
+	fd = mkstemp(tmp);
 
-	if (!tmp)
+	if (fd < 0)
 		return NULL;
 
+	close(fd);
+
 	ret = talloc_strdup(ctx, tmp);
-	free(tmp);
 
 	return ret;
 }