From: Jeremy Kerr <jk@ozlabs.org>
Date: Fri, 26 Jun 2015 03:41:46 +0000 (+0800)
Subject: discover: Fix raw string argument to talloc_asprintf_append
X-Git-Tag: v1.0.0~73
X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=commitdiff_plain;h=757d3ed67988099a279fa4f05f07ace8bb3f7596;hp=37b4861cb01bf6bd9da41aa1b311a87b0d26fc25

discover: Fix raw string argument to talloc_asprintf_append

Current builds give a warning:

  ../discover/platform-powerpc.c: In function ‘update_bootdev_config’:
  ../discover/platform-powerpc.c:667:4: warning: format not a string
  literal and no format arguments [-Wformat-security]
      tmp = val = talloc_asprintf_append(val, boot_str);
          ^

This change uses "%s" for the format string.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
---

diff --git a/discover/platform-powerpc.c b/discover/platform-powerpc.c
index b4f2a77..2b3b043 100644
--- a/discover/platform-powerpc.c
+++ b/discover/platform-powerpc.c
@@ -664,7 +664,7 @@ static void update_bootdev_config(struct platform_powerpc *platform,
 						opt->uuid, delim);
 				break;
 			}
-			tmp = val = talloc_asprintf_append(val, boot_str);
+			tmp = val = talloc_asprintf_append(val, "%s", boot_str);
 	}
 
 	update_string_config(platform, "petitboot,bootdevs", val);