From: Joel Stanley <joel@jms.id.au>
Date: Tue, 6 Mar 2018 04:02:19 +0000 (+1030)
Subject: test/parser: Fixed uninitialized variable warning
X-Git-Tag: v1.7.1~2
X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=commitdiff_plain;h=2c97f136757b5428bb68f91cfa723990dcd985c8;hp=2c97f136757b5428bb68f91cfa723990dcd985c8;ds=sidebyside

test/parser: Fixed uninitialized variable warning

Clang has a problem with list_for_each_entry:

test/parser/utils.c:290:36: error: variable 'file' is used uninitialized whenever 'for' loop exits because its condition is false [-Werror,-Wsometimes-uninitialized]
        list_for_each_entry(&test->files, f, list) {
                                          ^
./lib/list/list.h:30:3: note: expanded from macro 'list_for_each_entry'
                _pos; _pos = list_next_entry(_list, _pos, _member))
                ^~~~
test/parser/utils.c:300:7: note: uninitialized use occurs here
        if (!file) {
             ^~~~
test/parser/utils.c:290:36: note: remove the condition if it is always true
        list_for_each_entry(&test->files, f, list) {
                                          ^
./lib/list/list.h:30:3: note: expanded from macro 'list_for_each_entry'
                _pos; _pos = list_next_entry(_list, _pos, _member))
                ^
test/parser/utils.c:288:28: note: initialize the variable 'file' to silence this warning
        struct test_file *f, *file;
                                  ^
                                   = NULL

Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
---