From: Joel Stanley Date: Tue, 6 Mar 2018 04:02:19 +0000 (+1030) Subject: test/parser: Fixed uninitialized variable warning X-Git-Tag: v1.7.1~2 X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=commitdiff_plain;h=2c97f136757b5428bb68f91cfa723990dcd985c8 test/parser: Fixed uninitialized variable warning Clang has a problem with list_for_each_entry: test/parser/utils.c:290:36: error: variable 'file' is used uninitialized whenever 'for' loop exits because its condition is false [-Werror,-Wsometimes-uninitialized] list_for_each_entry(&test->files, f, list) { ^ ./lib/list/list.h:30:3: note: expanded from macro 'list_for_each_entry' _pos; _pos = list_next_entry(_list, _pos, _member)) ^~~~ test/parser/utils.c:300:7: note: uninitialized use occurs here if (!file) { ^~~~ test/parser/utils.c:290:36: note: remove the condition if it is always true list_for_each_entry(&test->files, f, list) { ^ ./lib/list/list.h:30:3: note: expanded from macro 'list_for_each_entry' _pos; _pos = list_next_entry(_list, _pos, _member)) ^ test/parser/utils.c:288:28: note: initialize the variable 'file' to silence this warning struct test_file *f, *file; ^ = NULL Signed-off-by: Joel Stanley Signed-off-by: Samuel Mendoza-Jonas --- diff --git a/test/parser/utils.c b/test/parser/utils.c index 8900bd7..47779c8 100644 --- a/test/parser/utils.c +++ b/test/parser/utils.c @@ -285,7 +285,7 @@ int parser_replace_file(struct discover_context *ctx, char *buf, int len) { struct parser_test *test = ctx->test_data; - struct test_file *f, *file; + struct test_file *f, *file = NULL; list_for_each_entry(&test->files, f, list) { if (f->dev != dev)