From: Samuel Mendoza-Jonas <sam.mj@au1.ibm.com>
Date: Wed, 11 Nov 2015 23:04:23 +0000 (+1100)
Subject: discover: Set umask before mkstemp()
X-Git-Tag: v1.0.0~34^2~1
X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=commitdiff_plain;h=2c6137dffb1518f5102170cf0eda26c83a31bc63

discover: Set umask before mkstemp()

Fixes Coverity defect #30479

Signed-off-by: Samuel Mendoza-Jonas <sam.mj@au1.ibm.com>
---

diff --git a/discover/paths.c b/discover/paths.c
index c25671b..1269dde 100644
--- a/discover/paths.c
+++ b/discover/paths.c
@@ -6,6 +6,8 @@
 #include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
+#include <sys/types.h>
+#include <sys/stat.h>
 
 #include <talloc/talloc.h>
 #include <system/system.h>
@@ -49,9 +51,12 @@ char *join_paths(void *alloc_ctx, const char *a, const char *b)
 static char *local_name(void *ctx)
 {
 	char *ret, tmp[] = "/tmp/pb-XXXXXX";
+	mode_t oldmask;
 	int fd;
 
+	oldmask = umask(0644);
 	fd = mkstemp(tmp);
+	umask(oldmask);
 
 	if (fd < 0)
 		return NULL;