discover/pxe-parser: Avoid potential null dereference

Fixes Coverity defect CID 149918

Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>

diff --git a/discover/pxe-parser.c b/discover/pxe-parser.c
index d2ebaab0e8a0f07f2f1aeef8bd262762301980b8..fd8b8e866d012ac4baeb8d6a772bd90eadbb9a03 100644 (file)
--- a/discover/pxe-parser.c
+++ b/discover/pxe-parser.c
@@ -273,12 +273,14 @@ static void pxe_conf_parse_cb(struct load_url_result *result, void *data)
 
        if (!data)
                return;
 
        if (!data)
                return;

+       if (!result)
+               goto out_clean;

 
        handler = talloc_parent(conf);
 
 
        handler = talloc_parent(conf);
 

-       if (result && result->status == LOAD_OK)
+       if (result->status == LOAD_OK)

                rc = read_file(conf, result->local, &buf, &len);
                rc = read_file(conf, result->local, &buf, &len);

-       if (!result || result->status != LOAD_OK || rc) {
+       if (result->status != LOAD_OK || rc) {

                /* This load failed so try the next available filename */
                info = conf->parser_info;
                if (!info->pxe_conf_files) {
                /* This load failed so try the next available filename */
                info = conf->parser_info;
                if (!info->pxe_conf_files) {