discover: Use snprintf() when building sysparam path

Fixes Coverity defects #30481 and #30482

Signed-off-by: Samuel Mendoza-Jonas <sam.mj@au1.ibm.com>

diff --git a/discover/platform-powerpc.c b/discover/platform-powerpc.c
index ce4eb8199ed33d01570e14aac57ce924fba3bb90..2480b8d29129fd27da866dc02e869c248c00b8b2 100644 (file)
--- a/discover/platform-powerpc.c
+++ b/discover/platform-powerpc.c
@@ -759,9 +759,8 @@ static int read_bootdev_sysparam(const char *name, uint8_t *val)
        char path[50];
        int fd, rc;
 
        char path[50];
        int fd, rc;
 

-       strcpy(path, sysparams_dir);
-       assert(strlen(name) < sizeof(path) - strlen(path));
-       strcat(path, name);
+       assert(strlen(sysparams_dir) + strlen(name) < sizeof(path));
+       snprintf(path, sizeof(path), "%s%s", sysparams_dir, name);

 
        fd = open(path, O_RDONLY);
        if (fd < 0) {
 
        fd = open(path, O_RDONLY);
        if (fd < 0) {


@@ -795,9 +794,8 @@ static int write_bootdev_sysparam(const char *name, uint8_t val)
        char path[50];
        int fd, rc;
 
        char path[50];
        int fd, rc;
 

-       strcpy(path, sysparams_dir);
-       assert(strlen(name) < sizeof(path) - strlen(path));
-       strcat(path, name);
+       assert(strlen(sysparams_dir) + strlen(name) < sizeof(path));
+       snprintf(path, sizeof(path), "%s%s", sysparams_dir, name);

 
        fd = open(path, O_WRONLY);
        if (fd < 0) {
 
        fd = open(path, O_WRONLY);
        if (fd < 0) {