X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=utils%2Fpb-udhcpc;h=252bb11d3ec1cd54ce3572e01e03e7aeb657c1f0;hp=808f12ab51ec5ab90a2fd63741c5e5468f81bb3d;hb=c24015f626b8249ba300ea311892856dc0134c2b;hpb=c3f79834be3fe862388432d01f15f727c8b7cd7c

diff --git a/utils/pb-udhcpc b/utils/pb-udhcpc
index 808f12a..252bb11 100644
--- a/utils/pb-udhcpc
+++ b/utils/pb-udhcpc
@@ -13,7 +13,7 @@ resolve_url() {
 	file="$1"
 
 	# URL? use as-is.
-	tmp=${file#://*}
+	tmp=${file%://*}
 	if [ "$tmp" != "$file" ]
 	then
 		echo "$file"
@@ -38,14 +38,14 @@ do_pxe() {
 	params="conf@/net/${interface} method=dhcp"
 
 	# first, try by MAC
-	mac=$(cat /sys/class/net/$interface/address)
-	pb-event $params url=$basedir/$mac
+	mac=$(tr ':' '-' < /sys/class/net/$interface/address)
+	pb-event $params url=$basedir/01-$mac
 
 	# try decreasing fragments of IP lease
 	ip_hex=$(printf '%02X%02X%02X%02X' $(echo $ip | tr '.' ' '))
 	for i in $(seq 8 -1 1)
 	do
-		frag=${hex_ip:0:$i}
+		frag=${ip_hex:0:$i}
 		pb-event $params url=$basedir/$frag
 	done
 
@@ -57,7 +57,7 @@ pb_add () {
 
 	# Look for an explicit config file location in the DHCP config-file
 	# parameter
-	if [ -n ${conffile} ]
+	if [ -n "${conffile}" ]
 	then
 		url=$(resolve_url ${conffile})
 		pb-event conf@/net/${interface} url=$url method=dhcp
@@ -67,7 +67,7 @@ pb_add () {
 	# Otherwise, we'll need the boot-file parameter. Looks like udhcpc
 	# will give us different names, depending if the parameter was in
 	# the header, or specified by options
-	[ -n "$bootfile" ] && bootfile=${boot_file}
+	[ -z "$bootfile" ] && bootfile=${boot_file}
 
 	if [ -z "$bootfile" ]
 	then
@@ -89,7 +89,7 @@ pb_add () {
 	k_root_dir=${rootpath#*:}
 
 	args=
-	if [ -n $rootpath ]
+	if [ -n "$rootpath" ]
 	then
 		[ ${k_server_ip} != ${rootpath} ] || k_server_ip=${serverid}
 		args="root=/dev/nfs ip=any nfsroot=${k_server_ip}:${k_root_dir}"