X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=ui%2Fcommon%2Fdiscover-client.c;h=5b42b6c4e0aa7662eb022b93a6952e6572e29a65;hp=8672ae019d54f3e2121742cdfb125908e5be3059;hb=6532debf0bd95509cff9eb8634f57aef20a696b9;hpb=8cb7063b23c1ec7a712270e6e264a3b2e0ab80a2

diff --git a/ui/common/discover-client.c b/ui/common/discover-client.c
index 8672ae0..5b42b6c 100644
--- a/ui/common/discover-client.c
+++ b/ui/common/discover-client.c
@@ -33,7 +33,7 @@ static int discover_client_destructor(void *arg)
 }
 
 struct discover_client* discover_client_init(
-	const struct discover_client_ops *ops)
+	const struct discover_client_ops *ops, void *cb_arg)
 {
 	struct discover_client *client;
 	struct sockaddr_un addr;
@@ -43,9 +43,10 @@ struct discover_client* discover_client_init(
 		return NULL;
 
 	memcpy(&client->ops, ops, sizeof(client->ops));
+	client->ops.cb_arg = cb_arg;
 
 	client->fd = socket(AF_UNIX, SOCK_STREAM, 0);
-	if (!client->fd < 0) {
+	if (client->fd < 0) {
 		pb_log("%s: socket: %s\n", __func__, strerror(errno));
 		goto out_err;
 	}
@@ -80,7 +81,7 @@ void discover_client_destroy(struct discover_client *client)
 	talloc_free(client);
 }
 
-static void add_device(struct discover_client *client, struct device *device)
+static void device_add(struct discover_client *client, struct device *device)
 {
 	client->n_devices++;
 	client->devices = talloc_realloc(client, client->devices,
@@ -89,10 +90,10 @@ static void add_device(struct discover_client *client, struct device *device)
 	client->devices[client->n_devices - 1] = device;
 	talloc_steal(client, device);
 
-	client->ops.add_device(device, client->ops.cb_arg);
+	client->ops.device_add(device, client->ops.cb_arg);
 }
 
-static void remove_device(struct discover_client *client, const char *id)
+static void device_remove(struct discover_client *client, const char *id)
 {
 	struct device *device = NULL;
 	int i;
@@ -110,12 +111,12 @@ static void remove_device(struct discover_client *client, const char *id)
 	/* remove the device from the client's device array */
 	client->n_devices--;
 	memmove(&client->devices[i], &client->devices[i+1],
-			client->n_devices - i);
+			(client->n_devices - i) * sizeof(client->devices[0]));
 	client->devices = talloc_realloc(client, client->devices,
 			struct device *, client->n_devices);
 
 	/* notify the UI */
-	client->ops.remove_device(device, client->ops.cb_arg);
+	client->ops.device_remove(device, client->ops.cb_arg);
 
 	talloc_free(device);
 }
@@ -139,7 +140,7 @@ int discover_client_process(struct discover_client *client)
 			return 0;
 		}
 
-		add_device(client, dev);
+		device_add(client, dev);
 		break;
 	case PB_PROTOCOL_ACTION_REMOVE:
 		dev_id = pb_protocol_deserialise_string(client, message);
@@ -147,7 +148,7 @@ int discover_client_process(struct discover_client *client)
 			pb_log("%s: no device id?\n", __func__);
 			return 0;
 		}
-		remove_device(client, dev_id);
+		device_remove(client, dev_id);
 		break;
 	default:
 		pb_log("%s: unknown action %d\n", __func__, message->action);