X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=lib%2Fprocess%2Fprocess.c;h=c1606a52b342406de99d44d9cd07a678a327ba29;hp=081a48ca36ba27ac37eb1a83888eaec281d635b0;hb=2914110af0cc490566446f18c929452368121b98;hpb=ffb84fc1bf1d138d1ac1bb8ece0b7d625f288d97 diff --git a/lib/process/process.c b/lib/process/process.c index 081a48c..c1606a5 100644 --- a/lib/process/process.c +++ b/lib/process/process.c @@ -60,15 +60,22 @@ static struct process_info *get_info(struct process *process) return container_of(process, struct process_info, process); } +struct process *procinfo_get_process(struct process_info *procinfo) +{ + return &procinfo->process; +} + /* Read as much as possible into the currently-allocated stdout buffer, and * possibly realloc it for the next read + * If the line pointer is not NULL, it is set to the start of the latest + * output. * * Returns: * > 0 on success (even though no bytes may have been read) * 0 on EOF (no error, but no more reads can be performed) * < 0 on error **/ -static int process_read_stdout_once(struct process_info *procinfo) +static int process_read_stdout_once(struct process_info *procinfo, char **line) { struct process *process = &procinfo->process; int rc, fd, max_len; @@ -89,6 +96,9 @@ static int process_read_stdout_once(struct process_info *procinfo) return rc; } + if (line) + *line = process->stdout_buf + process->stdout_len; + process->stdout_len += rc; if (process->stdout_len == procinfo->stdout_buf_len - 1) { procinfo->stdout_buf_len *= 2; @@ -104,7 +114,7 @@ static int process_setup_stdout_pipe(struct process_info *procinfo) { int rc; - if (!procinfo->process.keep_stdout) + if (!procinfo->process.keep_stdout || procinfo->process.raw_stdout) return 0; procinfo->stdout_buf_len = 4096; @@ -122,7 +132,7 @@ static int process_setup_stdout_pipe(struct process_info *procinfo) static void process_setup_stdout_parent(struct process_info *procinfo) { - if (!procinfo->process.keep_stdout) + if (!procinfo->process.keep_stdout || procinfo->process.raw_stdout) return; close(procinfo->stdout_pipe[1]); @@ -132,6 +142,9 @@ static void process_setup_stdout_child(struct process_info *procinfo) { int log = fileno(pb_log_get_stream()); + if (procinfo->process.raw_stdout) + return; + if (procinfo->process.keep_stdout) dup2(procinfo->stdout_pipe[1], STDOUT_FILENO); else @@ -157,7 +170,7 @@ static int process_read_stdout(struct process_info *procinfo) return 0; do { - rc = process_read_stdout_once(procinfo); + rc = process_read_stdout_once(procinfo, NULL); } while (rc > 0); process_finish_stdout(procinfo); @@ -170,7 +183,27 @@ static int process_stdout_cb(void *arg) struct process_info *procinfo = arg; int rc; - rc = process_read_stdout_once(procinfo); + rc = process_read_stdout_once(procinfo, NULL); + + /* if we're going to signal to the waitset that we're done (ie, non-zero + * return value), then the waiters will remove us, so we drop the + * reference */ + if (rc < 0) { + talloc_unlink(procset, procinfo); + procinfo->stdout_waiter = NULL; + rc = -1; + } else { + rc = 0; + } + + return rc; +} + +int process_stdout_custom(struct process_info *procinfo, char **line) +{ + int rc; + + rc = process_read_stdout_once(procinfo, line); /* if we're going to signal to the waitset that we're done (ie, non-zero * return value), then the waiters will remove us, so we drop the @@ -387,6 +420,7 @@ int process_run_sync(struct process *process) int process_run_async(struct process *process) { struct process_info *procinfo = get_info(process); + waiter_cb stdout_cb; int rc; rc = process_run_common(procinfo); @@ -394,10 +428,10 @@ int process_run_async(struct process *process) return rc; if (process->keep_stdout) { + stdout_cb = process->stdout_cb ?: process_stdout_cb; procinfo->stdout_waiter = waiter_register_io(procset->waitset, procinfo->stdout_pipe[0], - WAIT_IN, process_stdout_cb, - procinfo); + WAIT_IN, stdout_cb, procinfo); talloc_reference(procset, procinfo); } @@ -409,7 +443,29 @@ int process_run_async(struct process *process) void process_stop_async(struct process *process) { + /* Avoid signalling an old pid */ + if (process->cancelled) + return; + + pb_debug("process: sending SIGTERM to pid %d\n", process->pid); kill(process->pid, SIGTERM); + process->cancelled = true; +} + +void process_stop_async_all(void) +{ + struct process_info *procinfo; + struct process *process = NULL; + + pb_debug("process: cancelling all async jobs\n"); + + list_for_each_entry(&procset->async_list, procinfo, async_list) { + process = &procinfo->process; + /* Ignore the process completion - callbacks may use stale data */ + process->exit_cb = NULL; + process->stdout_cb = NULL; + process_stop_async(process); + } } int process_run_simple_argv(void *ctx, const char *argv[])