X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fyaboot-parser.c;h=4dd1ea5be9648214f7a14b64b837839723fb9e60;hp=22792d4a63b4007bcfc46c400ab88cf8b2adbbc4;hb=a1fb38f17bfa60aac89d0dd21dd8ccc739d794bf;hpb=503d1454f222e2b0c6f8dd433a9e91870a17f460;ds=sidebyside

diff --git a/discover/yaboot-parser.c b/discover/yaboot-parser.c
index 22792d4..4dd1ea5 100644
--- a/discover/yaboot-parser.c
+++ b/discover/yaboot-parser.c
@@ -1,4 +1,6 @@
-#define _GNU_SOURCE
+#if defined(HAVE_CONFIG_H)
+#include "config.h"
+#endif
 
 #include <assert.h>
 #include <stdlib.h>
@@ -14,7 +16,6 @@
 
 struct yaboot_state {
 	int globals_done;
-	const char *const *known_names;
 
 	/* current option data */
 	struct discover_boot_option *opt;
@@ -102,7 +103,8 @@ static void yaboot_finish(struct conf_context *conf)
 	const char *default_label;
 	struct boot_option *opt;
 
-	assert(state->opt);
+	if (!state->opt)
+		return;
 
 	opt = state->opt->option;
 	assert(opt);
@@ -191,14 +193,10 @@ static void yaboot_process_pair(struct conf_context *conf, const char *name,
 	if (!state->globals_done && conf_set_global_option(conf, name, value))
 		return;
 
-	if (!conf_param_in_list(state->known_names, name))
-		return;
-
-	state->globals_done = 1;
-
 	/* image */
-
 	if (streq(name, "image")) {
+		/* an image section finishes our global defintions */
+		state->globals_done = 1;
 
 		/* First finish any previous image. */
 		if (opt)
@@ -242,7 +240,7 @@ static void yaboot_process_pair(struct conf_context *conf, const char *name,
 
 	/* all other processing requires an image */
 	if (!opt) {
-		pb_log("%s: unknown name: %s\n", __func__, name);
+		pb_debug("%s: unknown name: %s\n", __func__, name);
 		return;
 	}
 
@@ -308,7 +306,7 @@ static void yaboot_process_pair(struct conf_context *conf, const char *name,
 		return;
 	}
 
-	pb_log("%s: unknown name: %s\n", __func__, name);
+	pb_debug("%s: unknown name: %s\n", __func__, name);
 }
 
 static struct conf_global_option yaboot_global_options[] = {
@@ -338,33 +336,22 @@ static const char *const yaboot_conf_files[] = {
 	NULL
 };
 
-static const char *yaboot_known_names[] = {
-	"append",
-	"image",
-	"image[64bit]", /* SUSE extension */
-	"image[32bit]", /* SUSE extension */
-	"initrd",
-	"initrd-size",
-	"label",
-	"literal",
-	"ramdisk",
-	"read-only",
-	"read-write",
-	"root",
-	"device",
-	"partition",
-	NULL
-};
-
-static int yaboot_parse(struct discover_context *dc, char *buf, int len)
+static int yaboot_parse(struct discover_context *dc)
 {
-	struct conf_context *conf;
+	const char * const *filename;
 	struct yaboot_state *state;
+	struct conf_context *conf;
+	int len, rc;
+	char *buf;
+
+	/* Support block device boot only at present */
+	if (dc->event)
+		return -1;
 
 	conf = talloc_zero(dc, struct conf_context);
 
 	if (!conf)
-		return 0;
+		return -1;
 
 	conf->dc = dc;
 	conf->global_options = yaboot_global_options,
@@ -374,21 +361,24 @@ static int yaboot_parse(struct discover_context *dc, char *buf, int len)
 	conf->finish = yaboot_finish;
 	conf->parser_info = state = talloc_zero(conf, struct yaboot_state);
 
-	state->known_names = yaboot_known_names;
-
 	state->opt = NULL;
 
-	conf_parse_buf(conf, buf, len);
+	for (filename = yaboot_conf_files; *filename; filename++) {
+		rc = parser_request_file(dc, dc->device, *filename, &buf, &len);
+		if (rc)
+			continue;
+
+		conf_parse_buf(conf, buf, len);
+		talloc_free(buf);
+	}
 
 	talloc_free(conf);
-	return 1;
+	return 0;
 }
 
 static struct parser yaboot_parser = {
 	.name			= "yaboot",
-	.method			= CONF_METHOD_LOCAL_FILE,
 	.parse			= yaboot_parse,
-	.filenames		= yaboot_conf_files,
 	.resolve_resource	= resolve_devpath_resource,
 };