X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fyaboot-parser.c;h=22792d4a63b4007bcfc46c400ab88cf8b2adbbc4;hp=f51d2c61d886b07c0992ba776fb430fce52a63d4;hb=503d1454f222e2b0c6f8dd433a9e91870a17f460;hpb=45e92aa32a80fdbbf5ad3ad64e34b1ac872018ef

diff --git a/discover/yaboot-parser.c b/discover/yaboot-parser.c
index f51d2c6..22792d4 100644
--- a/discover/yaboot-parser.c
+++ b/discover/yaboot-parser.c
@@ -3,6 +3,7 @@
 #include <assert.h>
 #include <stdlib.h>
 #include <string.h>
+#include <ctype.h>
 
 #include "log/log.h"
 #include "talloc/talloc.h"
@@ -12,24 +13,95 @@
 #include "resource.h"
 
 struct yaboot_state {
-	struct discover_boot_option *opt;
-	char *desc_image;
-	char *desc_initrd;
 	int globals_done;
 	const char *const *known_names;
+
+	/* current option data */
+	struct discover_boot_option *opt;
+	const char *device;
+	const char *partition;
+	const char *boot_image;
+	const char *initrd;
+	const char *initrd_size;
+	const char *literal;
+	const char *ramdisk;
+	const char *root;
+	bool read_only;
+	bool read_write;
 };
 
+static struct discover_boot_option *state_start_new_option(
+		struct conf_context *conf,
+		struct yaboot_state *state)
+{
+	state->opt = discover_boot_option_create(conf->dc, conf->dc->device);
+	state->opt->option->boot_args = talloc_strdup(state->opt->option, "");
+
+	/* old allocated values will get freed with the state */
+	state->device = conf_get_global_option(conf, "device");
+	state->partition = conf_get_global_option(conf, "partition");
+	state->initrd_size = conf_get_global_option(conf, "initrd_size");
+	state->literal = conf_get_global_option(conf, "literal");
+	state->ramdisk = conf_get_global_option(conf, "ramdisk");
+	state->root = conf_get_global_option(conf, "root");
+
+	return state->opt;
+}
+
+static struct resource *create_yaboot_devpath_resource(
+		struct yaboot_state *state,
+		struct conf_context *conf,
+		const char *path)
+{
+	struct discover_boot_option *opt = state->opt;
+	const char *dev, *part, *devpos;
+	struct resource *res;
+	char *devpath, *devstr;
+
+	dev = state->device;
+	part = state->partition;
+
+	if (!dev)
+		dev = conf_get_global_option(conf, "device");
+	if (!part)
+		part = conf_get_global_option(conf, "partition");
+
+	if (strchr(path, ':')) {
+		devpath = talloc_strdup(conf, path);
+
+	} else if (dev && part) {
+		devpos = &dev[strlen(dev) - 1];
+		if (isdigit(*devpos)) {
+			while (isdigit(*devpos))
+				devpos--;
+
+			devstr = talloc_strndup(conf, dev, devpos - dev + 1);
+			devpath = talloc_asprintf(conf, "%s%s:%s", devstr,
+					part, path);
+			talloc_free(devstr);
+		} else {
+			devpath = talloc_asprintf(conf,
+					"%s%s:%s", dev, part, path);
+		}
+	} else if (dev) {
+		devpath = talloc_asprintf(conf, "%s:%s", dev, path);
+	} else {
+		devpath = talloc_strdup(conf, path);
+	}
+
+	res = create_devpath_resource(opt, conf->dc->device, devpath);
+
+	talloc_free(devpath);
+
+	return res;
+}
+
 static void yaboot_finish(struct conf_context *conf)
 {
 	struct yaboot_state *state = conf->parser_info;
-	struct device *dev = conf->dc->device->device;
+	const char *default_label;
 	struct boot_option *opt;
 
-	if (!state->desc_image) {
-		pb_log("%s: %s: no image found\n", __func__, dev->id);
-		return;
-	}
-
 	assert(state->opt);
 
 	opt = state->opt->option;
@@ -37,53 +109,60 @@ static void yaboot_finish(struct conf_context *conf)
 	assert(opt->name);
 	assert(opt->boot_args);
 
-	opt->description = talloc_asprintf(opt, "%s %s %s",
-		state->desc_image,
-		(state->desc_initrd ? state->desc_initrd : ""),
-		opt->boot_args);
-
-	talloc_free(state->desc_initrd);
-	state->desc_initrd = NULL;
+	/* populate the boot option from state data */
+	state->opt->boot_image = create_yaboot_devpath_resource(state,
+				conf, state->boot_image);
+	if (state->initrd) {
+		state->opt->initrd = create_yaboot_devpath_resource(state,
+				conf, state->initrd);
+	}
 
-	conf_strip_str(opt->boot_args);
-	conf_strip_str(opt->description);
+	if (state->initrd_size) {
+		opt->boot_args = talloc_asprintf(opt, "ramdisk_size=%s %s",
+					state->initrd_size, opt->boot_args);
+	}
 
-	/* opt is persistent, so must be associated with device */
+	if (state->ramdisk) {
+		opt->boot_args = talloc_asprintf(opt, "ramdisk=%s %s",
+					state->initrd_size, opt->boot_args);
+	}
 
-	discover_context_add_boot_option(conf->dc, state->opt);
+	if (state->root) {
+		opt->boot_args = talloc_asprintf(opt, "root=%s %s",
+					state->root, opt->boot_args);
+	}
 
-	state->opt = discover_boot_option_create(conf->dc, conf->dc->device);
-	state->opt->option->boot_args = talloc_strdup(state->opt->option, "");
-}
+	if (state->read_only && state->read_write) {
+		pb_log("boot option %s specified both 'ro' and 'rw', "
+				"using 'rw'\n", opt->name);
+		state->read_only = false;
+	}
 
-static struct resource *create_yaboot_devpath_resource(
-		struct conf_context *conf,
-		const char *path, char **desc_str)
-{
-	const char *g_boot = conf_get_global_option(conf, "boot");
-	const char *g_part = conf_get_global_option(conf, "partition");
-	struct resource *res;
-	char *devpath;
+	if (state->read_only || state->read_write) {
+		opt->boot_args = talloc_asprintf(opt, "%s %s",
+					state->read_only ? "ro" : "rw",
+					opt->boot_args);
+	}
 
-	if (g_boot && g_part) {
-		devpath = talloc_asprintf(conf,
-				"%s%s:%s", g_boot, g_part, path);
-	} else if (g_boot) {
-		devpath = talloc_asprintf(conf, "%s:%s", g_boot, path);
-	} else {
-		devpath = talloc_strdup(conf, path);
+	if (state->literal) {
+		opt->boot_args = talloc_strdup(opt, state->literal);
 	}
 
-	res = create_devpath_resource(conf->dc, conf->dc->device, devpath);
+	opt->description = talloc_asprintf(opt, "%s %s %s",
+		state->boot_image,
+		(state->initrd ? state->initrd : ""),
+		opt->boot_args ? opt->boot_args : "");
 
-	if (desc_str)
-		*desc_str = devpath;
-	else
-		talloc_free(devpath);
+	conf_strip_str(opt->boot_args);
+	conf_strip_str(opt->description);
 
-	return res;
-}
+	default_label = conf_get_global_option(conf, "default");
+	if (default_label &&
+			!strcasecmp(state->opt->option->name, default_label))
+		state->opt->option->is_default = true;
 
+	discover_context_add_boot_option(conf->dc, state->opt);
+}
 
 static void yaboot_process_pair(struct conf_context *conf, const char *name,
 		char *value)
@@ -122,12 +201,13 @@ static void yaboot_process_pair(struct conf_context *conf, const char *name,
 	if (streq(name, "image")) {
 
 		/* First finish any previous image. */
-		if (opt->boot_image)
+		if (opt)
 			yaboot_finish(conf);
 
 		/* Then start the new image. */
-		opt->boot_image = create_yaboot_devpath_resource(conf,
-				value, &state->desc_image);
+		opt = state_start_new_option(conf, state);
+
+		state->boot_image = talloc_strdup(state, value);
 
 		return;
 	}
@@ -143,49 +223,36 @@ static void yaboot_process_pair(struct conf_context *conf, const char *name,
 
 	if (suse_fp) {
 		/* First finish any previous image. */
-
-		if (opt->boot_image)
+		if (opt)
 			yaboot_finish(conf);
 
 		/* Then start the new image. */
+		opt = state_start_new_option(conf, state);
 
 		if (*value == '/') {
-			opt->boot_image = create_yaboot_devpath_resource(
-					conf, value, &state->desc_image);
+			state->boot_image = talloc_strdup(state, value);
 		} else {
-			char *tmp;
-
-			opt->boot_image = create_yaboot_devpath_resource(
-					conf, suse_fp->image,
-					&state->desc_image);
-
-			opt->initrd = create_yaboot_devpath_resource(
-					conf, suse_fp->initrd, &tmp);
-
-			state->desc_initrd = talloc_asprintf(opt,
-				"initrd=%s", tmp);
-			talloc_free(tmp);
+			state->boot_image = talloc_strdup(state,
+							suse_fp->image);
+			state->initrd = talloc_strdup(state, suse_fp->initrd);
 		}
 
 		return;
 	}
 
-	if (!opt->boot_image) {
+	/* all other processing requires an image */
+	if (!opt) {
 		pb_log("%s: unknown name: %s\n", __func__, name);
 		return;
 	}
 
 	/* initrd */
-
 	if (streq(name, "initrd")) {
-		opt->initrd = create_yaboot_devpath_resource(conf,
-				value, &state->desc_image);
-
+		state->initrd = talloc_strdup(state, value);
 		return;
 	}
 
 	/* label */
-
 	if (streq(name, "label")) {
 		opt->option->id = talloc_asprintf(opt->option, "%s#%s",
 			conf->dc->device->device->id, value);
@@ -194,6 +261,16 @@ static void yaboot_process_pair(struct conf_context *conf, const char *name,
 	}
 
 	/* args */
+	if (streq(name, "device")) {
+		printf("option device : %s", value);
+		state->device = talloc_strdup(state, value);
+		return;
+	}
+
+	if (streq(name, "parititon")) {
+		state->partition = talloc_strdup(state, value);
+		return;
+	}
 
 	if (streq(name, "append")) {
 		opt->option->boot_args = talloc_asprintf_append(
@@ -202,42 +279,32 @@ static void yaboot_process_pair(struct conf_context *conf, const char *name,
 	}
 
 	if (streq(name, "initrd-size")) {
-		opt->option->boot_args = talloc_asprintf_append(
-			opt->option->boot_args, "ramdisk_size=%s ", value);
+		state->initrd_size = talloc_strdup(state, value);
 		return;
 	}
 
 	if (streq(name, "literal")) {
-		if (*opt->option->boot_args) {
-			pb_log("%s: literal over writes '%s'\n", __func__,
-				opt->option->boot_args);
-			talloc_free(opt->option->boot_args);
-		}
-		talloc_asprintf(opt->option, "%s ", value);
+		state->literal = talloc_strdup(state, value);
 		return;
 	}
 
 	if (streq(name, "ramdisk")) {
-		opt->option->boot_args = talloc_asprintf_append(
-			opt->option->boot_args, "ramdisk=%s ", value);
+		state->ramdisk = talloc_strdup(state, value);
 		return;
 	}
 
 	if (streq(name, "read-only")) {
-		opt->option->boot_args = talloc_asprintf_append(
-			opt->option->boot_args, "ro ");
+		state->read_only = true;
 		return;
 	}
 
 	if (streq(name, "read-write")) {
-		opt->option->boot_args = talloc_asprintf_append(
-			opt->option->boot_args, "rw ");
+		state->read_write = true;
 		return;
 	}
 
 	if (streq(name, "root")) {
-		opt->option->boot_args = talloc_asprintf_append(
-			opt->option->boot_args, "root=%s ", value);
+		state->root = talloc_strdup(state, value);
 		return;
 	}
 
@@ -245,10 +312,15 @@ static void yaboot_process_pair(struct conf_context *conf, const char *name,
 }
 
 static struct conf_global_option yaboot_global_options[] = {
-	{ .name = "boot" },
-	{ .name = "initrd" },
+	{ .name = "root" },
+	{ .name = "device" },
 	{ .name = "partition" },
+	{ .name = "initrd" },
+	{ .name = "initrd_size" },
 	{ .name = "video" },
+	{ .name = "literal" },
+	{ .name = "ramdisk" },
+	{ .name = "default" },
 	{ .name = NULL },
 };
 
@@ -279,6 +351,8 @@ static const char *yaboot_known_names[] = {
 	"read-only",
 	"read-write",
 	"root",
+	"device",
+	"partition",
 	NULL
 };
 
@@ -302,10 +376,7 @@ static int yaboot_parse(struct discover_context *dc, char *buf, int len)
 
 	state->known_names = yaboot_known_names;
 
-	/* opt is persistent, so must be associated with device */
-
-	state->opt = discover_boot_option_create(conf->dc, conf->dc->device);
-	state->opt->option->boot_args = talloc_strdup(state->opt->option, "");
+	state->opt = NULL;
 
 	conf_parse_buf(conf, buf, len);
 
@@ -314,9 +385,11 @@ static int yaboot_parse(struct discover_context *dc, char *buf, int len)
 }
 
 static struct parser yaboot_parser = {
-	.name		= "yaboot",
-	.parse		= yaboot_parse,
-	.filenames	= yaboot_conf_files,
+	.name			= "yaboot",
+	.method			= CONF_METHOD_LOCAL_FILE,
+	.parse			= yaboot_parse,
+	.filenames		= yaboot_conf_files,
+	.resolve_resource	= resolve_devpath_resource,
 };
 
 register_parser(yaboot_parser);