X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fuser-event.c;h=fb3fddb5c4bc5f7390f114ec7820f33d7ec45e77;hp=7350b6c3c4ef558927097c53066e81759d0a0a1f;hb=0d3caaf8e9a75e9b6ebc9427c75ed2914c60439d;hpb=83a587b79e9a5a5279f1c7a26918fc8c08523a7f;ds=sidebyside

diff --git a/discover/user-event.c b/discover/user-event.c
index 7350b6c..fb3fddb 100644
--- a/discover/user-event.c
+++ b/discover/user-event.c
@@ -37,6 +37,7 @@
 #include "resource.h"
 #include "event.h"
 #include "user-event.h"
+#include "sysinfo.h"
 
 
 #define MAC_ADDR_SIZE	6
@@ -82,7 +83,7 @@ static void user_event_print_event(struct event __attribute__((unused)) *event)
 }
 
 static struct resource *user_event_resource(struct discover_boot_option *opt,
-		struct event *event)
+		struct event *event, bool gen_boot_args_sigfile)
 {
 	const char *siaddr, *boot_file;
 	struct resource *res;
@@ -101,7 +102,16 @@ static struct resource *user_event_resource(struct discover_boot_option *opt,
 		return NULL;
 	}
 
-	url_str = talloc_asprintf(opt, "%s%s/%s", "tftp://", siaddr, boot_file);
+	if (gen_boot_args_sigfile) {
+		char* args_sigfile_default = talloc_asprintf(opt,
+			"%s.cmdline.sig", boot_file);
+		url_str = talloc_asprintf(opt, "%s%s/%s", "tftp://", siaddr,
+			args_sigfile_default);
+		talloc_free(args_sigfile_default);
+	}
+	else
+		url_str = talloc_asprintf(opt, "%s%s/%s", "tftp://", siaddr,
+			boot_file);
 	url = pb_url_parse(opt, url_str);
 	talloc_free(url_str);
 
@@ -143,12 +153,13 @@ static int parse_user_event(struct discover_context *ctx, struct event *event)
 	opt->id = talloc_asprintf(opt, "%s#%s", dev->id, val);
 	opt->name = talloc_strdup(opt, val);
 
-	d_opt->boot_image = user_event_resource(d_opt, event);
+	d_opt->boot_image = user_event_resource(d_opt, event, false);
 	if (!d_opt->boot_image) {
 		pb_log("%s: no boot image found for %s!\n", __func__,
 				opt->name);
 		goto fail_opt;
 	}
+	d_opt->args_sig_file = user_event_resource(d_opt, event, true);
 
 	val = event_get_param(event, "rootpath");
 	if (val) {
@@ -375,31 +386,20 @@ static int user_event_dhcp(struct user_event *uev, struct event *event)
 	struct device_handler *handler = uev->handler;
 	struct discover_device *dev;
 
-	dev = discover_device_create(handler, event->device);
-
-	device_handler_dhcp(handler, dev, event);
-
-	return 0;
-}
-
-static int user_event_conf(struct user_event *uev, struct event *event)
-{
-	struct device_handler *handler = uev->handler;
-	struct discover_device *dev;
-	struct pb_url *url;
-	const char *val;
+	uint8_t hwaddr[MAC_ADDR_SIZE];
 
-	val = event_get_param(event, "url");
-	if (!val)
-		return 0;
+	sscanf(event_get_param(event, "mac"),
+	       "%hhX:%hhX:%hhX:%hhX:%hhX:%hhX",
+	       hwaddr, hwaddr + 1, hwaddr + 2,
+	       hwaddr + 3, hwaddr + 4, hwaddr + 5);
 
-	url = pb_url_parse(event, val);
-	if (!url)
-		return 0;
+	system_info_set_interface_address(sizeof(hwaddr), hwaddr,
+					  event_get_param(event, "ip"));
 
-	dev = discover_device_create(handler, event->device);
+	dev = discover_device_create(handler, event_get_param(event, "mac"),
+					event->device);
 
-	device_handler_conf(handler, dev, url);
+	device_handler_dhcp(handler, dev, event);
 
 	return 0;
 }
@@ -410,7 +410,10 @@ static int user_event_add(struct user_event *uev, struct event *event)
 	struct discover_context *ctx;
 	struct discover_device *dev;
 
-	dev = discover_device_create(handler, event->device);
+	/* In case this is a network interface, try to refer to it by UUID */
+	dev = discover_device_create(handler, event_get_param(event, "mac"),
+					event->device);
+	dev->device->id = talloc_strdup(dev, event->device);
 	ctx = device_handler_discover_context_create(handler, dev);
 
 	parse_user_event(ctx, event);
@@ -426,8 +429,13 @@ static int user_event_remove(struct user_event *uev, struct event *event)
 {
 	struct device_handler *handler = uev->handler;
 	struct discover_device *dev;
+	const char *mac = event_get_param(event, "mac");
+
+	if (mac)
+		dev = device_lookup_by_uuid(handler, event_get_param(event, "mac"));
+	else
+		dev = device_lookup_by_id(handler, event->device);
 
-	dev = device_lookup_by_id(handler, event->device);
 	if (!dev)
 		return 0;
 
@@ -503,13 +511,10 @@ static void user_event_handle_message(struct user_event *uev, char *buf,
 		break;
 	case EVENT_ACTION_URL:
 		result = user_event_url(uev, event);
-		break;
-	case EVENT_ACTION_CONF:
-		result = user_event_conf(uev, event);
-		break;
+		goto out;
 	case EVENT_ACTION_DHCP:
 		result = user_event_dhcp(uev, event);
-		break;
+		goto out;
 	case EVENT_ACTION_BOOT:
 		result = user_event_boot(uev, event);
 		break;
@@ -520,8 +525,10 @@ static void user_event_handle_message(struct user_event *uev, char *buf,
 		break;
 	}
 
+	/* user_event_url() and user_event_dhcp() will steal the event context,
+	 * but all others still need to free */
 	talloc_free(event);
-
+out:
 	return;
 }