X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fpaths.c;h=0d414ebaac0833a075b0f65532734e1620e46649;hp=0c8cc8b0d4c1a84596c66ab1f27073cff5446435;hb=dcc2bd8913d3741614e971b0be12f490d8334538;hpb=66bf929fa97fabb70198455f9eec2e9ccf0661fa diff --git a/discover/paths.c b/discover/paths.c index 0c8cc8b..0d414eb 100644 --- a/discover/paths.c +++ b/discover/paths.c @@ -86,7 +86,7 @@ static void load_url_process_exit(struct process *process) if (result->status == LOAD_CANCELLED) { load_url_result_cleanup_local(result); - } else if (process->exit_status == 0) { + } else if (process_exit_ok(process)) { result->status = LOAD_OK; } else { result->status = LOAD_ERROR; @@ -131,7 +131,10 @@ static void load_process_to_local_file(struct load_task *task, task->result->status = rc ? LOAD_ERROR : LOAD_ASYNC; } else { rc = process_run_sync(task->process); - task->result->status = rc ? LOAD_ERROR : LOAD_OK; + if (rc || !process_exit_ok(task->process)) + task->result->status = LOAD_ERROR; + else + task->result->status = LOAD_OK; process_release(task->process); task->process = NULL; } @@ -222,6 +225,7 @@ static enum tftp_type check_tftp_type(void *ctx) process->path = pb_system_apps.tftp; process->argv = argv; process->keep_stdout = true; + process->add_stderr = true; process_run_sync(process); if (!process->stdout_buf || process->stdout_len == 0) { @@ -306,8 +310,9 @@ static void load_wget(struct load_task *task, int flags) pb_system_apps.wget, "-O", NULL, /* 2: local file */ - NULL, - NULL, + NULL, /* 3 (optional): --quiet */ + NULL, /* 4 (optional): --no-check-certificate */ + NULL, /* 5: URL */ NULL, }; int i;