X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fparser.c;h=b0668808cd859cfe7706ad5df870005878639a4e;hp=11728b779ce66f1af15900857e4d33168a1cc3a8;hb=b16b116422f1fb817924f4d2c3d9b1354da35614;hpb=4fee70ab7c67e268eff0ba16b42a71d36c11e727

diff --git a/discover/parser.c b/discover/parser.c
index 11728b7..b066880 100644
--- a/discover/parser.c
+++ b/discover/parser.c
@@ -12,86 +12,90 @@
 #include "parser.h"
 #include "parser-utils.h"
 #include "paths.h"
+#include "file.h"
 
-static int n_parsers;
-static struct parser **parsers;
+struct p_item {
+	struct list_item list;
+	struct parser *parser;
+};
 
-static const int max_file_size = 1024 * 1024;
+STATIC_LIST(parsers);
 
-static int read_file(struct discover_context *ctx,
-		const char *filename, char **bufp, int *lenp)
+static char *local_path(struct discover_context *ctx,
+		struct discover_device *dev,
+		const char *filename)
 {
-	struct stat statbuf;
-	int rc, fd, i, len;
-	char *buf;
+	return join_paths(ctx, dev->mount_path, filename);
+}
+
+int parser_request_file(struct discover_context *ctx,
+		struct discover_device *dev, const char *filename,
+		char **buf, int *len)
+
+{
+	char *path;
+	int rc;
 
-	fd = open(filename, O_RDONLY);
-	if (fd < 0)
+	/* we only support local files at present */
+	if (!dev->mount_path)
 		return -1;
 
-	rc = fstat(fd, &statbuf);
-	if (rc < 0)
-		goto err_close;
+	path = local_path(ctx, dev, filename);
 
-	len = statbuf.st_size;
-	if (len > max_file_size)
-		goto err_close;
+	rc = read_file(ctx, path, buf, len);
 
-	buf = talloc_array(ctx, char, len);
-	if (!buf)
-		goto err_close;
+	talloc_free(path);
 
-	for (i = 0; i < len; i += rc) {
-		rc = read(fd, buf + i, len - i);
+	return rc;
+}
 
-		/* unexpected EOF: trim and return */
-		if (rc == 0) {
-			len = i;
-			break;
-		}
+int parser_replace_file(struct discover_context *ctx,
+		struct discover_device *dev, const char *filename,
+		char *buf, int len)
+{
+	bool release;
+	char *path;
+	int rc;
 
-		if (rc < 0)
-			goto err_free;
+	if (!dev->mounted)
+		return -1;
 
+	rc = device_request_write(dev, &release);
+	if (rc) {
+		pb_log("Can't write file %s: device doesn't allow write\n",
+				dev->device_path);
+		return -1;
 	}
 
-	close(fd);
-	*bufp = buf;
-	*lenp = len;
-	return 0;
+	path = local_path(ctx, dev, filename);
 
-err_free:
-	talloc_free(buf);
-err_close:
-	close(fd);
-	return -1;
-}
+	rc = replace_file(path, buf, len);
 
-static char *local_path(struct discover_context *ctx,
-		const char *filename)
-{
-	return join_paths(ctx, ctx->device->mount_path, filename);
+	talloc_free(path);
+
+	device_release_write(dev, release);
+
+	return rc;
 }
 
 static int download_config(struct discover_context *ctx, char **buf, int *len)
 {
-	unsigned tempfile;
-	const char *file;
+	struct load_url_result *result;
 	int rc;
 
-	file = load_url(ctx, ctx->conf_url, &tempfile);
-	if (!file)
+	result = load_url(ctx, ctx->conf_url);
+	if (!result)
 		return -1;
 
-	rc = read_file(ctx, file, buf, len);
+	rc = read_file(ctx, result->local, buf, len);
 	if (rc)
 		goto out_clean;
 
 	return 0;
 
 out_clean:
-	if (tempfile)
-		unlink(file);
+	if (result->cleanup_local)
+		unlink(result->local);
 	return -1;
 }
 
@@ -108,12 +112,14 @@ static void iterate_parser_files(struct discover_context *ctx,
 		int rc, len;
 		char *buf;
 
-		path = local_path(ctx, *filename);
+		path = local_path(ctx, ctx->device, *filename);
 		if (!path)
 			continue;
 
 		rc = read_file(ctx, path, &buf, &len);
 		if (!rc) {
+			pb_log("Running parser %s on file %s\n",
+					parser->name, *filename);
 			parser->parse(ctx, buf, len);
 			talloc_free(buf);
 		}
@@ -122,19 +128,20 @@ static void iterate_parser_files(struct discover_context *ctx,
 
 void iterate_parsers(struct discover_context *ctx, enum conf_method method)
 {
-	int rc, i, len;
+	struct p_item* i;
+	int rc, len;
 	char *buf;
 
 	pb_log("trying parsers for %s\n", ctx->device->device->id);
 
 	switch (method) {
 	case CONF_METHOD_LOCAL_FILE:
-		for (i = 0; i < n_parsers; i++) {
-			if (parsers[i]->method != CONF_METHOD_LOCAL_FILE)
+		list_for_each_entry(&parsers, i, list) {
+			if (i->parser->method != CONF_METHOD_LOCAL_FILE)
 				continue;
 
-			pb_log("\ttrying parser '%s'\n", parsers[i]->name);
-			ctx->parser = parsers[i];
+			pb_log("\ttrying parser '%s'\n", i->parser->name);
+			ctx->parser = i->parser;
 			iterate_parser_files(ctx, ctx->parser);
 		}
 		ctx->parser = NULL;
@@ -147,13 +154,13 @@ void iterate_parsers(struct discover_context *ctx, enum conf_method method)
 			return;
 		}
 
-		for (i = 0; i < n_parsers; i++) {
-			if (parsers[i]->method != method)
+		list_for_each_entry(&parsers, i, list) {
+			if (i->parser->method != method)
 				continue;
 
-			pb_log("\ttrying parser '%s'\n", parsers[i]->name);
-			ctx->parser = parsers[i];
-			parsers[i]->parse(ctx, buf, len);
+			pb_log("\ttrying parser '%s'\n", i->parser->name);
+			ctx->parser = i->parser;
+			i->parser->parse(ctx, buf, len);
 		}
 
 		break;
@@ -166,9 +173,10 @@ void iterate_parsers(struct discover_context *ctx, enum conf_method method)
 
 void __register_parser(struct parser *parser)
 {
-	parsers = talloc_realloc(NULL, parsers, struct parser *, n_parsers + 1);
-	parsers[n_parsers] = parser;
-	n_parsers++;
+	struct p_item* i = talloc(NULL, struct p_item);
+
+	i->parser = parser;
+	list_add(&parsers, &i->list);
 }
 
 void parser_init(void)