X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fgrub2%2Fenv.c;h=1336824d1d92fb2bbc9d16945b4d3330135db6e1;hp=c887c7511297c9829dab795c6cc9d84adce3401a;hb=893cfce3e9ea91a68e678829fb8e7e37102e2b41;hpb=dd8fe077022138d1f6aca7e6d6cceec61f56ce95

diff --git a/discover/grub2/env.c b/discover/grub2/env.c
index c887c75..1336824 100644
--- a/discover/grub2/env.c
+++ b/discover/grub2/env.c
@@ -3,12 +3,12 @@
 #include <string.h>
 
 #include <log/log.h>
+#include <file/file.h>
 #include <types/types.h>
 #include <talloc/talloc.h>
 #include <util/util.h>
 
 #include <discover/parser.h>
-#include <discover/file.h>
 
 #include "grub2.h"
 
@@ -17,7 +17,7 @@ static const char *signature = "# GRUB Environment Block\n";
 
 static int parse_buf_to_env(struct grub2_script *script, void *buf, int len)
 {
-	char *tmp, *line, *sep;
+	char *tmp = NULL, *line, *sep;
 	int siglen;
 
 	siglen = strlen(signature);
@@ -84,10 +84,10 @@ int builtin_load_env(struct grub2_script *script,
 
 	rc = parser_request_file(script->ctx, dev, envpath, &buf, &len);
 
-	if (!rc)
+	if (!rc) {
 		rc = parse_buf_to_env(script, buf, len);
-
-	talloc_free(buf);
+		talloc_free(buf);
+	}
 
 	return 0;
 }