X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fdevice-handler.c;h=d95a37cb0c7c41ae420001d4c227cfa012c33b2f;hp=6a27f15780a5a4ae290e2ddf6d1b95f789dadb02;hb=120855d64d783aa3b3b0af23923da0169319c338;hpb=b8122dc9340e2f208220f0c88b4d71f91b78774f

diff --git a/discover/device-handler.c b/discover/device-handler.c
index 6a27f15..d95a37c 100644
--- a/discover/device-handler.c
+++ b/discover/device-handler.c
@@ -1,55 +1,350 @@
-
 #include <assert.h>
 #include <stdlib.h>
+#include <stdbool.h>
 #include <unistd.h>
 #include <string.h>
 #include <errno.h>
+#include <mntent.h>
+#include <locale.h>
 #include <sys/stat.h>
 #include <sys/wait.h>
+#include <sys/mount.h>
 
 #include <talloc/talloc.h>
 #include <list/list.h>
 #include <log/log.h>
 #include <types/types.h>
 #include <system/system.h>
+#include <process/process.h>
+#include <url/url.h>
+#include <i18n/i18n.h>
+
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <netdb.h>
+#include <arpa/inet.h>
 
 #include "device-handler.h"
 #include "discover-server.h"
+#include "user-event.h"
+#include "platform.h"
 #include "event.h"
 #include "parser.h"
-#include "udev.h"
+#include "resource.h"
 #include "paths.h"
+#include "sysinfo.h"
 #include "boot.h"
+#include "udev.h"
+#include "network.h"
+#include "ipmi.h"
+
+enum default_priority {
+	DEFAULT_PRIORITY_REMOTE		= 1,
+	DEFAULT_PRIORITY_LOCAL_FIRST	= 2,
+	DEFAULT_PRIORITY_LOCAL_LAST	= 0xfe,
+	DEFAULT_PRIORITY_DISABLED	= 0xff,
+};
 
 struct device_handler {
-	struct discover_server *server;
+	struct discover_server	*server;
+	int			dry_run;
+
+	struct pb_udev		*udev;
+	struct network		*network;
+	struct user_event	*user_event;
+
+	struct discover_device	**devices;
+	unsigned int		n_devices;
+
+	struct waitset		*waitset;
+	struct waiter		*timeout_waiter;
+	bool			autoboot_enabled;
+	unsigned int		sec_to_boot;
 
-	struct device **devices;
-	unsigned int n_devices;
+	struct discover_boot_option *default_boot_option;
+	int			default_boot_option_priority;
 
-	struct list contexts;
+	struct list		unresolved_boot_options;
+
+	struct boot_task	*pending_boot;
+	bool			pending_boot_is_default;
 };
 
+static int mount_device(struct discover_device *dev);
+static int umount_device(struct discover_device *dev);
+
+static int device_handler_init_sources(struct device_handler *handler);
+static void device_handler_reinit_sources(struct device_handler *handler);
+
+static void device_handler_update_lang(const char *lang);
+
+void discover_context_add_boot_option(struct discover_context *ctx,
+		struct discover_boot_option *boot_option)
+{
+	boot_option->source = ctx->parser;
+	list_add_tail(&ctx->boot_options, &boot_option->list);
+	talloc_steal(ctx, boot_option);
+}
+
 /**
- * device_handler_add - Add a device to the handler device array.
+ * device_handler_get_device_count - Get the count of current handler devices.
  */
 
-static void device_handler_add(struct device_handler *handler,
-	struct device *device)
+int device_handler_get_device_count(const struct device_handler *handler)
 {
-	handler->n_devices++;
-	handler->devices = talloc_realloc(handler, handler->devices,
-		struct device *, handler->n_devices);
-	handler->devices[handler->n_devices - 1] = device;
+	return handler->n_devices;
 }
 
 /**
- * device_handler_remove - Remove a device from the handler device array.
+ * device_handler_get_device - Get a handler device by index.
  */
 
-static void device_handler_remove(struct device_handler *handler,
-	struct device *device)
+const struct discover_device *device_handler_get_device(
+	const struct device_handler *handler, unsigned int index)
+{
+	if (index >= handler->n_devices) {
+		assert(0 && "bad index");
+		return NULL;
+	}
+
+	return handler->devices[index];
+}
+
+struct discover_boot_option *discover_boot_option_create(
+		struct discover_context *ctx,
+		struct discover_device *device)
+{
+	struct discover_boot_option *opt;
+
+	opt = talloc_zero(ctx, struct discover_boot_option);
+	opt->option = talloc_zero(opt, struct boot_option);
+	opt->device = device;
+
+	return opt;
+}
+
+static int device_match_uuid(struct discover_device *dev, const char *uuid)
+{
+	return dev->uuid && !strcmp(dev->uuid, uuid);
+}
+
+static int device_match_label(struct discover_device *dev, const char *label)
+{
+	return dev->label && !strcmp(dev->label, label);
+}
+
+static int device_match_id(struct discover_device *dev, const char *id)
+{
+	return !strcmp(dev->device->id, id);
+}
+
+static int device_match_serial(struct discover_device *dev, const char *serial)
+{
+	const char *val = discover_device_get_param(dev, "ID_SERIAL");
+	return val && !strcmp(val, serial);
+}
+
+static struct discover_device *device_lookup(
+		struct device_handler *device_handler,
+		int (match_fn)(struct discover_device *, const char *),
+		const char *str)
 {
+	struct discover_device *dev;
+	unsigned int i;
+
+	if (!str)
+		return NULL;
+
+	for (i = 0; i < device_handler->n_devices; i++) {
+		dev = device_handler->devices[i];
+
+		if (match_fn(dev, str))
+			return dev;
+	}
+
+	return NULL;
+}
+
+struct discover_device *device_lookup_by_name(struct device_handler *handler,
+		const char *name)
+{
+	if (!strncmp(name, "/dev/", strlen("/dev/")))
+		name += strlen("/dev/");
+
+	return device_lookup_by_id(handler, name);
+}
+
+struct discover_device *device_lookup_by_uuid(
+		struct device_handler *device_handler,
+		const char *uuid)
+{
+	return device_lookup(device_handler, device_match_uuid, uuid);
+}
+
+struct discover_device *device_lookup_by_label(
+		struct device_handler *device_handler,
+		const char *label)
+{
+	return device_lookup(device_handler, device_match_label, label);
+}
+
+struct discover_device *device_lookup_by_id(
+		struct device_handler *device_handler,
+		const char *id)
+{
+	return device_lookup(device_handler, device_match_id, id);
+}
+
+struct discover_device *device_lookup_by_serial(
+		struct device_handler *device_handler,
+		const char *serial)
+{
+	return device_lookup(device_handler, device_match_serial, serial);
+}
+
+void device_handler_destroy(struct device_handler *handler)
+{
+	talloc_free(handler);
+}
+
+static int destroy_device(void *arg)
+{
+	struct discover_device *dev = arg;
+
+	umount_device(dev);
+
+	return 0;
+}
+
+struct discover_device *discover_device_create(struct device_handler *handler,
+		const char *id)
+{
+	struct discover_device *dev;
+
+	dev = device_lookup_by_id(handler, id);
+	if (dev)
+		return dev;
+
+	dev = talloc_zero(handler, struct discover_device);
+	dev->device = talloc_zero(dev, struct device);
+	dev->device->id = talloc_strdup(dev->device, id);
+	list_init(&dev->params);
+	list_init(&dev->boot_options);
+
+	talloc_set_destructor(dev, destroy_device);
+
+	return dev;
+}
+
+struct discover_device_param {
+	char			*name;
+	char			*value;
+	struct list_item	list;
+};
+
+void discover_device_set_param(struct discover_device *device,
+		const char *name, const char *value)
+{
+	struct discover_device_param *param;
+	bool found = false;
+
+	list_for_each_entry(&device->params, param, list) {
+		if (!strcmp(param->name, name)) {
+			found = true;
+			break;
+		}
+	}
+
+	if (!found) {
+		if (!value)
+			return;
+		param = talloc(device, struct discover_device_param);
+		param->name = talloc_strdup(param, name);
+		list_add(&device->params, &param->list);
+	} else {
+		if (!value) {
+			list_remove(&param->list);
+			talloc_free(param);
+			return;
+		}
+		talloc_free(param->value);
+	}
+
+	param->value = talloc_strdup(param, value);
+}
+
+const char *discover_device_get_param(struct discover_device *device,
+		const char *name)
+{
+	struct discover_device_param *param;
+
+	list_for_each_entry(&device->params, param, list) {
+		if (!strcmp(param->name, name))
+			return param->value;
+	}
+	return NULL;
+}
+
+struct device_handler *device_handler_init(struct discover_server *server,
+		struct waitset *waitset, int dry_run)
+{
+	struct device_handler *handler;
+	int rc;
+
+	handler = talloc_zero(NULL, struct device_handler);
+	handler->server = server;
+	handler->waitset = waitset;
+	handler->dry_run = dry_run;
+	handler->autoboot_enabled = config_get()->autoboot_enabled;
+
+	list_init(&handler->unresolved_boot_options);
+
+	/* set up our mount point base */
+	pb_mkdir_recursive(mount_base());
+
+	parser_init();
+
+	if (config_get()->safe_mode)
+		return handler;
+
+	rc = device_handler_init_sources(handler);
+	if (rc) {
+		talloc_free(handler);
+		return NULL;
+	}
+
+	return handler;
+}
+
+void device_handler_reinit(struct device_handler *handler)
+{
+	struct discover_boot_option *opt, *tmp;
+	unsigned int i;
+
+	device_handler_cancel_default(handler);
+
+	/* free unresolved boot options */
+	list_for_each_entry_safe(&handler->unresolved_boot_options,
+			opt, tmp, list)
+		talloc_free(opt);
+	list_init(&handler->unresolved_boot_options);
+
+	/* drop all devices */
+	for (i = 0; i < handler->n_devices; i++)
+		discover_server_notify_device_remove(handler->server,
+				handler->devices[i]->device);
+
+	talloc_free(handler->devices);
+	handler->devices = NULL;
+	handler->n_devices = 0;
+
+	device_handler_reinit_sources(handler);
+}
+
+void device_handler_remove(struct device_handler *handler,
+		struct discover_device *device)
+{
+	struct discover_boot_option *opt, *tmp;
 	unsigned int i;
 
 	for (i = 0; i < handler->n_devices; i++)
@@ -57,403 +352,1021 @@ static void device_handler_remove(struct device_handler *handler,
 			break;
 
 	if (i == handler->n_devices) {
-		assert(0 && "unknown device");
+		talloc_free(device);
 		return;
 	}
 
+	/* Free any unresolved options, as they're currently allocated
+	 * against the handler */
+	list_for_each_entry_safe(&handler->unresolved_boot_options,
+			opt, tmp, list) {
+		if (opt->device != device)
+			continue;
+		list_remove(&opt->list);
+		talloc_free(opt);
+	}
+
+	/* if this is a network device, we have to unregister it from the
+	 * network code */
+	if (device->device->type == DEVICE_TYPE_NETWORK)
+		network_unregister_device(handler->network, device);
+
 	handler->n_devices--;
 	memmove(&handler->devices[i], &handler->devices[i + 1],
 		(handler->n_devices - i) * sizeof(handler->devices[0]));
 	handler->devices = talloc_realloc(handler, handler->devices,
-		struct device *, handler->n_devices);
+		struct discover_device *, handler->n_devices);
+
+	if (device->notified)
+		discover_server_notify_device_remove(handler->server,
+							device->device);
+
+	talloc_free(device);
 }
 
-/**
- * device_handler_find - Find a handler device by id.
- */
+static void boot_status(void *arg, struct boot_status *status)
+{
+	struct device_handler *handler = arg;
 
-static struct device *device_handler_find(struct device_handler *handler,
-	const char *id)
+	discover_server_notify_boot_status(handler->server, status);
+}
+
+static void countdown_status(struct device_handler *handler,
+		struct discover_boot_option *opt, unsigned int sec)
 {
-	unsigned int i;
+	struct boot_status status;
 
-	assert(id);
+	status.type = BOOT_STATUS_INFO;
+	status.progress = -1;
+	status.detail = NULL;
+	status.message = talloc_asprintf(handler,
+			_("Booting in %d sec: %s"), sec, opt->option->name);
 
-	for (i = 0; i < handler->n_devices; i++)
-		if (handler->devices[i]->id
-			&& streq(handler->devices[i]->id, id))
-			return handler->devices[i];
+	discover_server_notify_boot_status(handler->server, &status);
 
-	pb_log("%s: unknown device: %s\n", __func__, id);
-	return NULL;
+	talloc_free(status.message);
 }
 
-/**
- * device_handler_get_device_count - Get the count of current handler devices.
- */
+static int default_timeout(void *arg)
+{
+	struct device_handler *handler = arg;
+	struct discover_boot_option *opt;
 
-int device_handler_get_device_count(const struct device_handler *handler)
+	if (!handler->default_boot_option)
+		return 0;
+
+	if (handler->pending_boot)
+		return 0;
+
+	opt = handler->default_boot_option;
+
+	if (handler->sec_to_boot) {
+		countdown_status(handler, opt, handler->sec_to_boot);
+		handler->sec_to_boot--;
+		handler->timeout_waiter = waiter_register_timeout(
+						handler->waitset, 1000,
+						default_timeout, handler);
+		return 0;
+	}
+
+	handler->timeout_waiter = NULL;
+
+	pb_log("Timeout expired, booting default option %s\n", opt->option->id);
+
+	handler->pending_boot = boot(handler, handler->default_boot_option,
+			NULL, handler->dry_run, boot_status, handler);
+	handler->pending_boot_is_default = true;
+	return 0;
+}
+
+struct {
+	enum ipmi_bootdev	ipmi_type;
+	enum device_type	device_type;
+} device_type_map[] = {
+	{ IPMI_BOOTDEV_NETWORK, DEVICE_TYPE_NETWORK },
+	{ IPMI_BOOTDEV_DISK, DEVICE_TYPE_DISK },
+	{ IPMI_BOOTDEV_CDROM, DEVICE_TYPE_OPTICAL },
+};
+
+static bool ipmi_device_type_matches(enum ipmi_bootdev ipmi_type,
+		enum device_type device_type)
 {
-	return handler->n_devices;
+	unsigned int i;
+
+	for (i = 0; i < ARRAY_SIZE(device_type_map); i++) {
+		if (device_type_map[i].device_type == device_type)
+			return device_type_map[i].ipmi_type == ipmi_type;
+	}
+
+	return false;
 }
 
-/**
- * device_handler_get_device - Get a handler device by index.
- */
+static int autoboot_option_priority(const struct config *config,
+				struct discover_boot_option *opt)
+{
+	enum device_type type = opt->device->device->type;
+	const char *uuid = opt->device->uuid;
+	struct autoboot_option *auto_opt;
+	unsigned int i;
 
-const struct device *device_handler_get_device(
-	const struct device_handler *handler, unsigned int index)
+	for (i = 0; i < config->n_autoboot_opts; i++) {
+		auto_opt = &config->autoboot_opts[i];
+		if (auto_opt->boot_type == BOOT_DEVICE_UUID)
+			if (!strcmp(auto_opt->uuid, uuid))
+				return DEFAULT_PRIORITY_LOCAL_FIRST + i;
+
+		if (auto_opt->boot_type == BOOT_DEVICE_TYPE)
+			if (auto_opt->type == type ||
+			    auto_opt->type == DEVICE_TYPE_ANY)
+				return DEFAULT_PRIORITY_LOCAL_FIRST + i;
+	}
+
+	return -1;
+}
+
+/*
+ * We have different priorities to resolve conflicts between boot options that
+ * report to be the default for their device. This function assigns a priority
+ * for these options.
+ */
+static enum default_priority default_option_priority(
+		struct discover_boot_option *opt)
 {
-	if (index >= handler->n_devices) {
-		assert(0 && "bad index");
-		return NULL;
+	const struct config *config;
+
+	config = config_get();
+
+	/* We give highest priority to IPMI-configured boot options. If
+	 * we have an IPMI bootdev configuration set, then we don't allow
+	 * any other defaults */
+	if (config->ipmi_bootdev) {
+		bool ipmi_match = ipmi_device_type_matches(config->ipmi_bootdev,
+				opt->device->device->type);
+		if (ipmi_match)
+			return DEFAULT_PRIORITY_REMOTE;
+
+		pb_debug("handler: disabled default priority due to "
+				"non-matching IPMI type %x\n",
+				config->ipmi_bootdev);
+		return DEFAULT_PRIORITY_DISABLED;
 	}
 
-	return handler->devices[index];
+	/* Next, try to match the option against the user-defined autoboot
+	 * options, either by device UUID or type. */
+	if (config->n_autoboot_opts) {
+		int boot_match = autoboot_option_priority(config, opt);
+		if (boot_match > 0)
+			return boot_match;
+	}
+
+	/* If the option didn't match any entry in the array, it is disabled */
+	pb_debug("handler: disabled default priority due to "
+			"non-matching UUID or type\n");
+	return DEFAULT_PRIORITY_DISABLED;
 }
 
-static void setup_device_links(struct discover_context *ctx)
-{
-	struct link {
-		char *env, *dir;
-	} *link, links[] = {
-		{
-			.env = "ID_FS_UUID",
-			.dir = "disk/by-uuid"
-		},
-		{
-			.env = "ID_FS_LABEL",
-			.dir = "disk/by-label"
-		},
-		{
-			.env = NULL
-		}
-	};
+static void set_default(struct device_handler *handler,
+		struct discover_boot_option *opt)
+{
+	enum default_priority cur_prio, new_prio;
 
-	for (link = links; link->env; link++) {
-		char *enc, *dir, *path;
-		const char *value;
+	if (!handler->autoboot_enabled)
+		return;
 
-		value = event_get_param(ctx->event, link->env);
-		if (!value || !*value)
-			continue;
+	pb_debug("handler: new default option: %s\n", opt->option->id);
 
-		enc = encode_label(ctx, value);
-		dir = join_paths(ctx, mount_base(), link->dir);
-		path = join_paths(ctx, dir, value);
-
-		if (!pb_mkdir_recursive(dir)) {
-			unlink(path);
-			if (symlink(ctx->mount_path, path)) {
-				pb_log("symlink(%s,%s): %s\n",
-						ctx->mount_path, path,
-						strerror(errno));
-				talloc_free(path);
-			} else {
-				int i = ctx->n_links++;
-				ctx->links = talloc_realloc(ctx,
-						ctx->links, char *,
-						ctx->n_links);
-				ctx->links[i] = path;
-			}
+	new_prio = default_option_priority(opt);
+
+	/* Anything outside our range prevents a default boot */
+	if (new_prio >= DEFAULT_PRIORITY_DISABLED)
+		return;
 
+	pb_debug("handler: calculated priority %d\n", new_prio);
+
+	/* Resolve any conflicts: if we have a new default option, it only
+	 * replaces the current if it has a higher priority. */
+	if (handler->default_boot_option) {
+
+		cur_prio = handler->default_boot_option_priority;
+
+		if (new_prio < cur_prio) {
+			pb_log("handler: new prio %d beats "
+					"old prio %d for %s\n",
+					new_prio, cur_prio,
+					handler->default_boot_option
+						->option->id);
+			handler->default_boot_option = opt;
+			handler->default_boot_option_priority = new_prio;
+			/* extend the timeout a little, so the user sees some
+			 * indication of the change */
+			handler->sec_to_boot += 2;
 		}
 
-		talloc_free(dir);
-		talloc_free(enc);
+		return;
 	}
+
+	handler->sec_to_boot = config_get()->autoboot_timeout_sec;
+	handler->default_boot_option = opt;
+	handler->default_boot_option_priority = new_prio;
+
+	pb_log("handler: boot option %s set as default, timeout %u sec.\n",
+	       opt->option->id, handler->sec_to_boot);
+
+	default_timeout(handler);
 }
 
-static void remove_device_links(struct discover_context *ctx)
+static bool resource_is_resolved(struct resource *res)
 {
-	int i;
+	return !res || res->resolved;
+}
 
-	for (i = 0; i < ctx->n_links; i++)
-		unlink(ctx->links[i]);
+/* We only use this in an assert, which will disappear if we're compiling
+ * with NDEBUG, so we need the 'used' attribute for these builds */
+static bool __attribute__((used)) boot_option_is_resolved(
+		struct discover_boot_option *opt)
+{
+	return resource_is_resolved(opt->boot_image) &&
+		resource_is_resolved(opt->initrd) &&
+		resource_is_resolved(opt->dtb) &&
+		resource_is_resolved(opt->icon);
 }
 
-static int mount_device(struct discover_context *ctx)
+static bool resource_resolve(struct resource *res, const char *name,
+		struct discover_boot_option *opt,
+		struct device_handler *handler)
 {
-	const char *mountpoint;
-	const char *argv[6];
+	struct parser *parser = opt->source;
 
-	if (!ctx->mount_path) {
-		mountpoint = mountpoint_for_device(ctx->device_path);
-		ctx->mount_path = talloc_strdup(ctx, mountpoint);
-	}
+	if (resource_is_resolved(res))
+		return true;
 
-	if (pb_mkdir_recursive(ctx->mount_path))
-		pb_log("couldn't create mount directory %s: %s\n",
-				ctx->mount_path, strerror(errno));
+	pb_debug("Attempting to resolve resource %s->%s with parser %s\n",
+			opt->option->id, name, parser->name);
+	parser->resolve_resource(handler, res);
 
-	argv[0] = pb_system_apps.mount;
-	argv[1] = ctx->device_path;
-	argv[2] = ctx->mount_path;
-	argv[3] = "-o";
-	argv[4] = "ro";
-	argv[5] = NULL;
+	return res->resolved;
+}
 
-	if (pb_run_cmd(argv, 1, 0)) {
+static bool boot_option_resolve(struct discover_boot_option *opt,
+		struct device_handler *handler)
+{
+	return resource_resolve(opt->boot_image, "boot_image", opt, handler) &&
+		resource_resolve(opt->initrd, "initrd", opt, handler) &&
+		resource_resolve(opt->dtb, "dtb", opt, handler) &&
+		resource_resolve(opt->icon, "icon", opt, handler);
+}
 
-		/* Retry mount without ro option. */
+static void boot_option_finalise(struct device_handler *handler,
+		struct discover_boot_option *opt)
+{
+	assert(boot_option_is_resolved(opt));
+
+	/* check that the parsers haven't set any of the final data */
+	assert(!opt->option->boot_image_file);
+	assert(!opt->option->initrd_file);
+	assert(!opt->option->dtb_file);
+	assert(!opt->option->icon_file);
+	assert(!opt->option->device_id);
+
+	if (opt->boot_image)
+		opt->option->boot_image_file = opt->boot_image->url->full;
+	if (opt->initrd)
+		opt->option->initrd_file = opt->initrd->url->full;
+	if (opt->dtb)
+		opt->option->dtb_file = opt->dtb->url->full;
+	if (opt->icon)
+		opt->option->icon_file = opt->icon->url->full;
+
+	opt->option->device_id = opt->device->device->id;
+
+	if (opt->option->is_default)
+		set_default(handler, opt);
+}
 
-		argv[0] = pb_system_apps.mount;
-		argv[1] = ctx->device_path;
-		argv[2] = ctx->mount_path;
-		argv[3] = NULL;
+static void notify_boot_option(struct device_handler *handler,
+		struct discover_boot_option *opt)
+{
+	struct discover_device *dev = opt->device;
 
-		if (pb_run_cmd(argv, 1, 0))
-			goto out_rmdir;
-	}
+	if (!dev->notified)
+		discover_server_notify_device_add(handler->server,
+						  opt->device->device);
+	dev->notified = true;
+	discover_server_notify_boot_option_add(handler->server, opt->option);
+}
 
-	setup_device_links(ctx);
-	return 0;
+static void process_boot_option_queue(struct device_handler *handler)
+{
+	struct discover_boot_option *opt, *tmp;
 
-out_rmdir:
-	pb_rmdir_recursive(mount_base(), ctx->mount_path);
-	return -1;
+	list_for_each_entry_safe(&handler->unresolved_boot_options,
+			opt, tmp, list) {
+
+		pb_debug("queue: attempting resolution for %s\n",
+				opt->option->id);
+
+		if (!boot_option_resolve(opt, handler))
+			continue;
+
+		pb_debug("\tresolved!\n");
+
+		list_remove(&opt->list);
+		list_add_tail(&opt->device->boot_options, &opt->list);
+		talloc_steal(opt->device, opt);
+		boot_option_finalise(handler, opt);
+		notify_boot_option(handler, opt);
+	}
 }
 
-static int umount_device(struct discover_context *ctx)
+struct discover_context *device_handler_discover_context_create(
+		struct device_handler *handler,
+		struct discover_device *device)
 {
-	int status;
-	pid_t pid;
+	struct discover_context *ctx;
 
-	remove_device_links(ctx);
+	ctx = talloc_zero(handler, struct discover_context);
+	ctx->device = device;
+	ctx->network = handler->network;
+	list_init(&ctx->boot_options);
 
-	pid = fork();
-	if (pid == -1) {
-		pb_log("%s: fork failed: %s\n", __func__, strerror(errno));
-		return -1;
-	}
+	return ctx;
+}
 
-	if (pid == 0) {
-		execl(pb_system_apps.umount, pb_system_apps.umount,
-						ctx->mount_path, NULL);
-		exit(EXIT_FAILURE);
+/**
+ * context_commit - Commit a temporary discovery context to the handler,
+ * and notify the clients about any new options / devices
+ */
+void device_handler_discover_context_commit(struct device_handler *handler,
+		struct discover_context *ctx)
+{
+	struct discover_device *dev = ctx->device;
+	struct discover_boot_option *opt, *tmp;
+
+	if (!device_lookup_by_id(handler, dev->device->id))
+		device_handler_add_device(handler, dev);
+
+	/* move boot options from the context to the device */
+	list_for_each_entry_safe(&ctx->boot_options, opt, tmp, list) {
+		list_remove(&opt->list);
+
+		if (boot_option_resolve(opt, handler)) {
+			pb_log("boot option %s is resolved, "
+					"sending to clients\n",
+					opt->option->id);
+			list_add_tail(&dev->boot_options, &opt->list);
+			talloc_steal(dev, opt);
+			boot_option_finalise(handler, opt);
+			notify_boot_option(handler, opt);
+		} else {
+			if (!opt->source->resolve_resource) {
+				pb_log("parser %s gave us an unresolved "
+					"resource (%s), but no way to "
+					"resolve it\n",
+					opt->source->name, opt->option->id);
+				talloc_free(opt);
+			} else {
+				pb_log("boot option %s is unresolved, "
+						"adding to queue\n",
+						opt->option->id);
+				list_add(&handler->unresolved_boot_options,
+						&opt->list);
+				talloc_steal(handler, opt);
+			}
+		}
 	}
+}
 
-	if (waitpid(pid, &status, 0) == -1) {
-		pb_log("%s: waitpid failed: %s\n", __func__,
-				strerror(errno));
-		return -1;
-	}
+void device_handler_add_device(struct device_handler *handler,
+		struct discover_device *device)
+{
+	handler->n_devices++;
+	handler->devices = talloc_realloc(handler, handler->devices,
+				struct discover_device *, handler->n_devices);
+	handler->devices[handler->n_devices - 1] = device;
 
-	if (!WIFEXITED(status) || WEXITSTATUS(status) != 0)
-		return -1;
+	if (device->device->type == DEVICE_TYPE_NETWORK)
+		network_register_device(handler->network, device);
+}
+
+/* Start discovery on a hotplugged device. The device will be in our devices
+ * array, but has only just been initialised by the hotplug source.
+ */
+int device_handler_discover(struct device_handler *handler,
+		struct discover_device *dev)
+{
+	struct discover_context *ctx;
+	struct boot_status *status;
+	int rc;
+
+	status = talloc_zero(handler, struct boot_status);
+	status->type = BOOT_STATUS_INFO;
+	status->message = talloc_asprintf(status, "Processing %s device %s",
+				device_type_display_name(dev->device->type),
+				dev->device->id);
+	boot_status(handler, status);
+
+	process_boot_option_queue(handler);
+
+	/* create our context */
+	ctx = device_handler_discover_context_create(handler, dev);
+
+	rc = mount_device(dev);
+	if (rc)
+		goto out;
 
-	pb_rmdir_recursive(mount_base(), ctx->mount_path);
+	/* add this device to our system info */
+	system_info_register_blockdev(dev->device->id, dev->uuid,
+			dev->mount_path);
+
+	/* run the parsers. This will populate the ctx's boot_option list. */
+	iterate_parsers(ctx);
+
+	/* add discovered stuff to the handler */
+	device_handler_discover_context_commit(handler, ctx);
+
+out:
+	status->message = talloc_asprintf(status,"Processing %s complete\n",
+				dev->device->id);
+	boot_status(handler, status);
+
+	talloc_free(status);
+	talloc_free(ctx);
 
 	return 0;
 }
 
-static struct discover_context *find_context(struct device_handler *handler,
-		const char *id)
+/* Incoming dhcp event */
+int device_handler_dhcp(struct device_handler *handler,
+		struct discover_device *dev, struct event *event)
 {
 	struct discover_context *ctx;
+	struct boot_status *status;
+
+	status = talloc_zero(handler, struct boot_status);
+	status->type = BOOT_STATUS_INFO;
+	status->message = talloc_asprintf(status, "Processing dhcp event on %s",
+				dev->device->id);
+	boot_status(handler, status);
+
+	/* create our context */
+	ctx = device_handler_discover_context_create(handler, dev);
+	ctx->event = event;
+
+	iterate_parsers(ctx);
+
+	device_handler_discover_context_commit(handler, ctx);
+
+	status->message = talloc_asprintf(status,"Processing %s complete\n",
+				dev->device->id);
+	boot_status(handler, status);
+
+	talloc_free(status);
+	talloc_free(ctx);
+
+	return 0;
+}
+
+/* incoming conf event */
+int device_handler_conf(struct device_handler *handler,
+		struct discover_device *dev, struct pb_url *url)
+{
+        struct discover_context *ctx;
+	struct boot_status *status;
+
+	status = talloc_zero(handler, struct boot_status);
+	status->type = BOOT_STATUS_INFO;
+	status->message = talloc_asprintf(status, "Processing user config");
+	boot_status(handler, status);
+
+        /* create our context */
+        ctx = device_handler_discover_context_create(handler, dev);
+        ctx->conf_url = url;
+
+        iterate_parsers(ctx);
+
+        device_handler_discover_context_commit(handler, ctx);
+
+	status->message = talloc_asprintf(status,
+				"Processing user config complete");
+	boot_status(handler, status);
+
+	talloc_free(status);
+        talloc_free(ctx);
+
+        return 0;
+}
 
-	list_for_each_entry(&handler->contexts, ctx, list) {
-		if (!strcmp(ctx->id, id))
-			return ctx;
+static struct discover_boot_option *find_boot_option_by_id(
+		struct device_handler *handler, const char *id)
+{
+	unsigned int i;
+
+	for (i = 0; i < handler->n_devices; i++) {
+		struct discover_device *dev = handler->devices[i];
+		struct discover_boot_option *opt;
+
+		list_for_each_entry(&dev->boot_options, opt, list)
+			if (!strcmp(opt->option->id, id))
+				return opt;
 	}
 
 	return NULL;
 }
 
-static int destroy_context(void *arg)
+void device_handler_boot(struct device_handler *handler,
+		struct boot_command *cmd)
 {
-	struct discover_context *ctx = arg;
+	struct discover_boot_option *opt = NULL;
 
-	list_remove(&ctx->list);
-	umount_device(ctx);
+	if (cmd->option_id && strlen(cmd->option_id))
+		opt = find_boot_option_by_id(handler, cmd->option_id);
 
-	return 0;
+	if (handler->pending_boot)
+		boot_cancel(handler->pending_boot);
+
+	platform_pre_boot();
+
+	handler->pending_boot = boot(handler, opt, cmd, handler->dry_run,
+			boot_status, handler);
+	handler->pending_boot_is_default = false;
 }
 
-static int handle_add_udev_event(struct device_handler *handler,
-		struct event *event)
+void device_handler_cancel_default(struct device_handler *handler)
+{
+	struct boot_status status;
+
+	if (handler->timeout_waiter)
+		waiter_remove(handler->timeout_waiter);
+
+	handler->timeout_waiter = NULL;
+	handler->autoboot_enabled = false;
+
+	/* we only send status if we had a default boot option queued */
+	if (!handler->default_boot_option)
+		return;
+
+	pb_log("Cancelling default boot option\n");
+
+	if (handler->pending_boot && handler->pending_boot_is_default) {
+		boot_cancel(handler->pending_boot);
+		handler->pending_boot = NULL;
+		handler->pending_boot_is_default = false;
+	}
+
+	handler->default_boot_option = NULL;
+
+	status.type = BOOT_STATUS_INFO;
+	status.progress = -1;
+	status.detail = NULL;
+	status.message = _("Default boot cancelled");
+
+	discover_server_notify_boot_status(handler->server, &status);
+}
+
+void device_handler_update_config(struct device_handler *handler,
+		struct config *config)
 {
-	struct discover_context *ctx;
-	const char *devname;
 	int rc;
 
-	/* create our context */
-	ctx = talloc(handler, struct discover_context);
-	ctx->event = event;
-	ctx->mount_path = NULL;
-	ctx->links = NULL;
-	ctx->n_links = 0;
+	rc = config_set(config);
+	if (rc)
+		return;
 
-	ctx->id = talloc_strdup(ctx, event->device);
+	discover_server_notify_config(handler->server, config);
+	device_handler_update_lang(config->lang);
+	device_handler_reinit(handler);
+}
 
-	devname = event_get_param(ctx->event, "DEVNAME");
-	assert(devname);
-	ctx->device_path = talloc_strdup(ctx, devname);
+static char *device_from_addr(void *ctx, struct pb_url *url)
+{
+	char *ipaddr, *buf, *tok, *dev = NULL;
+	const char *delim = " ";
+	struct sockaddr_in *ip;
+	struct sockaddr_in si;
+	struct addrinfo *res;
+	struct process *p;
+	int rc;
 
-	rc = mount_device(ctx);
-	if (rc) {
-		talloc_free(ctx);
-		return 0;
+	/* Note: IPv4 only */
+	rc = inet_pton(AF_INET, url->host, &(si.sin_addr));
+	if (rc > 0) {
+		ipaddr = url->host;
+	} else {
+		/* need to turn hostname into a valid IP */
+		rc = getaddrinfo(url->host, NULL, NULL, &res);
+		if (rc) {
+			pb_debug("%s: Invalid URL\n",__func__);
+			return NULL;
+		}
+		ipaddr = talloc_array(ctx,char,INET_ADDRSTRLEN);
+		ip = (struct sockaddr_in *) res->ai_addr;
+		inet_ntop(AF_INET, &(ip->sin_addr), ipaddr, INET_ADDRSTRLEN);
+		freeaddrinfo(res);
 	}
 
-	list_add(&handler->contexts, &ctx->list);
-	talloc_set_destructor(ctx, destroy_context);
+	const char *argv[] = {
+		pb_system_apps.ip,
+		"route", "show", "to", "match",
+		ipaddr,
+		NULL
+	};
 
-	/* set up the top-level device */
-	ctx->device = talloc_zero(ctx, struct device);
-	ctx->device->id = talloc_strdup(ctx->device, ctx->id);
-	list_init(&ctx->device->boot_options);
+	p = process_create(ctx);
 
-	/* run the parsers */
-	iterate_parsers(ctx);
+	p->path = pb_system_apps.ip;
+	p->argv = argv;
+	p->keep_stdout = true;
 
-	/* add device to handler device array */
-	device_handler_add(handler, ctx->device);
+	rc = process_run_sync(p);
 
-	discover_server_notify_add(handler->server, ctx->device);
+	if (rc) {
+		/* ip has complained for some reason; most likely
+		 * there is no route to the host - bail out */
+		pb_debug("%s: No route to %s\n",__func__,url->host);
+		return NULL;
+	}
 
-	return 0;
+	buf = p->stdout_buf;
+	/* If a route is found, ip-route output will be of the form
+	 * "... dev DEVNAME ... " */
+	tok = strtok(buf, delim);
+	while (tok) {
+		if (!strcmp(tok, "dev")) {
+			tok = strtok(NULL, delim);
+			dev = talloc_strdup(ctx, tok);
+			break;
+		}
+		tok = strtok(NULL, delim);
+	}
+
+	process_release(p);
+	if (dev)
+		pb_debug("%s: Found interface '%s'\n", __func__,dev);
+	return dev;
 }
 
-static int handle_remove_udev_event(struct device_handler *handler,
-		struct event *event)
+
+void device_handler_process_url(struct device_handler *handler,
+		const char *url)
 {
 	struct discover_context *ctx;
+	struct discover_device *dev;
+	struct boot_status *status;
+	struct pb_url *pb_url;
+	struct event *event;
+	struct param *param;
+
+	status = talloc(handler, struct boot_status);
+
+	status->type = BOOT_STATUS_ERROR;
+	status->progress = 0;
+	status->detail = talloc_asprintf(status,
+			_("Received config URL %s"), url);
+
+	if (!handler->network) {
+		status->message = talloc_asprintf(handler,
+					_("No network configured"));
+		goto msg;
+	}
 
-	ctx = find_context(handler, event->device);
-	if (!ctx)
-		return 0;
+	event = talloc(handler, struct event);
+	event->type = EVENT_TYPE_USER;
+	event->action = EVENT_ACTION_CONF;
+
+	event->params = talloc_array(event, struct param, 1);
+	param = &event->params[0];
+	param->name = talloc_strdup(event, "pxeconffile");
+	param->value = talloc_strdup(event, url);
+	event->n_params = 1;
+
+	pb_url = pb_url_parse(event, event->params->value);
+	if (!pb_url || !pb_url->host) {
+		status->message = talloc_asprintf(handler,
+					_("Invalid config URL!"));
+		goto msg;
+	}
+
+	event->device = device_from_addr(event, pb_url);
+	if (!event->device) {
+		status->message = talloc_asprintf(status,
+					_("Unable to route to host %s"),
+					pb_url->host);
+		goto msg;
+	}
 
-	discover_server_notify_remove(handler->server, ctx->device);
+	dev = discover_device_create(handler, event->device);
+	ctx = device_handler_discover_context_create(handler, dev);
+	ctx->event = event;
+
+	iterate_parsers(ctx);
 
-	/* remove device from handler device array */
-	device_handler_remove(handler, ctx->device);
+	device_handler_discover_context_commit(handler, ctx);
 
 	talloc_free(ctx);
 
+	status->type = BOOT_STATUS_INFO;
+	status->message = talloc_asprintf(status, _("Config file %s parsed"),
+					pb_url->file);
+msg:
+	boot_status(handler, status);
+	talloc_free(status);
+}
+
+#ifndef PETITBOOT_TEST
+
+static void device_handler_update_lang(const char *lang)
+{
+	const char *cur_lang;
+
+	if (!lang)
+		return;
+
+	cur_lang = setlocale(LC_ALL, NULL);
+	if (cur_lang && !strcmp(cur_lang, lang))
+		return;
+
+	setlocale(LC_ALL, lang);
+}
+
+static int device_handler_init_sources(struct device_handler *handler)
+{
+	/* init our device sources: udev, network and user events */
+	handler->udev = udev_init(handler, handler->waitset);
+	if (!handler->udev)
+		return -1;
+
+	handler->network = network_init(handler, handler->waitset,
+			handler->dry_run);
+	if (!handler->network)
+		return -1;
+
+	handler->user_event = user_event_init(handler, handler->waitset);
+	if (!handler->user_event)
+		return -1;
+
 	return 0;
 }
 
-static int handle_add_user_event(struct device_handler *handler,
-		struct event *event)
+static void device_handler_reinit_sources(struct device_handler *handler)
 {
-	struct device *device;
+	/* if we haven't initialised sources previously (becuase we started in
+	 * safe mode), then init once here. */
+	if (!(handler->udev || handler->network || handler->user_event)) {
+		device_handler_init_sources(handler);
+		return;
+	}
 
-	assert(event->device);
+	udev_reinit(handler->udev);
 
-	device = talloc_zero(handler, struct device);
+	network_shutdown(handler->network);
+	handler->network = network_init(handler, handler->waitset,
+			handler->dry_run);
+}
 
-	if (!device)
-		goto fail;
+static const char *fs_parameters(unsigned int rw_flags, const char *fstype)
+{
+	if ((rw_flags | MS_RDONLY) != MS_RDONLY)
+		return "";
 
-	device->id = talloc_strdup(device, event->device);
-	list_init(&device->boot_options);
+	/* Avoid writing back to the disk on journaled filesystems */
+	if (!strncmp(fstype, "ext4", strlen("ext4")))
+		return "norecovery";
+	if (!strncmp(fstype, "xfs", strlen("xfs")))
+		return "norecovery";
 
-	parse_user_event(device, event);
+	return "";
+}
 
-	discover_server_notify_add(handler->server, device);
+static bool check_existing_mount(struct discover_device *dev)
+{
+	struct stat devstat, mntstat;
+	struct mntent *mnt;
+	FILE *fp;
+	int rc;
 
-	/* add device to handler device array */
-	device_handler_add(handler, device);
+	rc = stat(dev->device_path, &devstat);
+	if (rc) {
+		pb_debug("%s: stat failed: %s\n", __func__, strerror(errno));
+		return false;
+	}
 
-	return 0;
+	if (!S_ISBLK(devstat.st_mode)) {
+		pb_debug("%s: %s isn't a block device?\n", __func__,
+				dev->device_path);
+		return false;
+	}
 
-fail:
-	talloc_free(device);
-	return 0;
+	fp = fopen("/proc/self/mounts", "r");
+
+	for (;;) {
+		mnt = getmntent(fp);
+		if (!mnt)
+			break;
+
+		if (!mnt->mnt_fsname || mnt->mnt_fsname[0] != '/')
+			continue;
+
+		rc = stat(mnt->mnt_fsname, &mntstat);
+		if (rc)
+			continue;
+
+		if (!S_ISBLK(mntstat.st_mode))
+			continue;
+
+		if (mntstat.st_rdev == devstat.st_rdev) {
+			dev->mount_path = talloc_strdup(dev, mnt->mnt_dir);
+			dev->mounted_rw = !!hasmntopt(mnt, "rw");
+			dev->mounted = true;
+			dev->unmount = false;
+
+			pb_debug("%s: %s is already mounted (r%c) at %s\n",
+					__func__, dev->device_path,
+					dev->mounted_rw ? 'w' : 'o',
+					mnt->mnt_dir);
+			break;
+		}
+	}
+
+	fclose(fp);
+
+	return mnt != NULL;
 }
 
-static int handle_remove_user_event(struct device_handler *handler,
-		struct event *event)
+static int mount_device(struct discover_device *dev)
 {
-	struct device *device = device_handler_find(handler, event->device);
+	const char *fstype;
+	int rc;
+
+	if (!dev->device_path)
+		return -1;
 
-	if (!device)
+	if (dev->mounted)
 		return 0;
 
-	discover_server_notify_remove(handler->server, device);
+	if (check_existing_mount(dev))
+		return 0;
 
-	/* remove device from handler device array */
-	device_handler_remove(handler, device);
+	fstype = discover_device_get_param(dev, "ID_FS_TYPE");
+	if (!fstype)
+		return 0;
 
-	talloc_free(device);
-	return 0;
-}
+	/* ext3 treats the norecovery option as an error, so mount the device
+	 * as an ext4 filesystem instead */
+	if (!strncmp(fstype, "ext3", strlen("ext3"))) {
+		pb_debug("Mounting ext3 filesystem as ext4\n");
+		fstype = talloc_asprintf(dev, "ext4");
+	}
 
-typedef int (*event_handler)(struct device_handler *, struct event *);
+	dev->mount_path = join_paths(dev, mount_base(),
+					dev->device_path);
 
-static event_handler handlers[EVENT_TYPE_MAX][EVENT_ACTION_MAX] = {
-	[EVENT_TYPE_UDEV] = {
-		[EVENT_ACTION_ADD]	= handle_add_udev_event,
-		[EVENT_ACTION_REMOVE]	= handle_remove_udev_event,
-	},
-	[EVENT_TYPE_USER] = {
-		[EVENT_ACTION_ADD]	= handle_add_user_event,
-		[EVENT_ACTION_REMOVE]	= handle_remove_user_event,
+	if (pb_mkdir_recursive(dev->mount_path)) {
+		pb_log("couldn't create mount directory %s: %s\n",
+				dev->mount_path, strerror(errno));
+		goto err_free;
 	}
-};
 
-int device_handler_event(struct device_handler *handler,
-		struct event *event)
-{
-	if (event->type >= EVENT_TYPE_MAX ||
-			event->action >= EVENT_ACTION_MAX ||
-			!handlers[event->type][event->action]) {
-		pb_log("%s unknown type/action: %d/%d\n", __func__,
-				event->type, event->action);
+	pb_log("mounting device %s read-only\n", dev->device_path);
+	errno = 0;
+	rc = mount(dev->device_path, dev->mount_path, fstype,
+			MS_RDONLY | MS_SILENT,
+			fs_parameters(MS_RDONLY, fstype));
+	if (!rc) {
+		dev->mounted = true;
+		dev->mounted_rw = false;
+		dev->unmount = true;
 		return 0;
 	}
 
-	return handlers[event->type][event->action](handler, event);
+	pb_log("couldn't mount device %s: mount failed: %s\n",
+			dev->device_path, strerror(errno));
+
+	pb_rmdir_recursive(mount_base(), dev->mount_path);
+err_free:
+	talloc_free(dev->mount_path);
+	dev->mount_path = NULL;
+	return -1;
 }
 
-struct device_handler *device_handler_init(struct discover_server *server)
+static int umount_device(struct discover_device *dev)
 {
-	struct device_handler *handler;
+	int rc;
 
-	handler = talloc(NULL, struct device_handler);
-	handler->devices = NULL;
-	handler->n_devices = 0;
-	handler->server = server;
+	if (!dev->mounted || !dev->unmount)
+		return 0;
 
-	list_init(&handler->contexts);
+	pb_log("unmounting device %s\n", dev->device_path);
+	rc = umount(dev->mount_path);
+	if (rc)
+		return -1;
 
-	/* set up our mount point base */
-	pb_mkdir_recursive(mount_base());
+	dev->mounted = false;
 
-	parser_init();
+	pb_rmdir_recursive(mount_base(), dev->mount_path);
 
-	return handler;
+	talloc_free(dev->mount_path);
+	dev->mount_path = NULL;
+
+	return 0;
 }
 
-void device_handler_destroy(struct device_handler *handler)
+int device_request_write(struct discover_device *dev, bool *release)
 {
-	talloc_free(handler);
+	const char *fstype;
+	int rc;
+
+	*release = false;
+
+	if (!dev->mounted)
+		return -1;
+
+	if (dev->mounted_rw)
+		return 0;
+
+	fstype = discover_device_get_param(dev, "ID_FS_TYPE");
+
+	pb_log("remounting device %s read-write\n", dev->device_path);
+
+	rc = umount(dev->mount_path);
+	if (rc) {
+		pb_log("Failed to unmount %s\n", dev->mount_path);
+		return -1;
+	}
+	rc = mount(dev->device_path, dev->mount_path, fstype,
+			MS_SILENT,
+			fs_parameters(MS_REMOUNT, fstype));
+	if (rc)
+		goto mount_ro;
+
+	dev->mounted_rw = true;
+	*release = true;
+	return 0;
+
+mount_ro:
+	pb_log("Unable to remount device %s read-write\n", dev->device_path);
+	rc = mount(dev->device_path, dev->mount_path, fstype,
+			MS_RDONLY | MS_SILENT,
+			fs_parameters(MS_RDONLY, fstype));
+	if (rc)
+		pb_log("Unable to recover mount for %s\n", dev->device_path);
+	return -1;
 }
 
-static struct boot_option *find_boot_option_by_id(
-		struct device_handler *handler, const char *id)
+void device_release_write(struct discover_device *dev, bool release)
 {
-	unsigned int i;
+	const char *fstype;
 
-	for (i = 0; i < handler->n_devices; i++) {
-		struct device *dev = handler->devices[i];
-		struct boot_option *opt;
+	if (!release)
+		return;
 
-		list_for_each_entry(&dev->boot_options, opt, list)
-			if (!strcmp(opt->id, id))
-				return opt;
-	}
+	fstype = discover_device_get_param(dev, "ID_FS_TYPE");
 
-	return NULL;
+	pb_log("remounting device %s read-only\n", dev->device_path);
+	mount(dev->device_path, dev->mount_path, "",
+			MS_REMOUNT | MS_RDONLY | MS_SILENT,
+			fs_parameters(MS_RDONLY, fstype));
+	dev->mounted_rw = false;
 }
 
-void device_handler_boot(struct device_handler *handler,
-		struct boot_command *cmd)
+#else
+
+static void device_handler_update_lang(const char *lang __attribute__((unused)))
 {
-	struct boot_option *opt;
+}
 
-	opt = find_boot_option_by_id(handler, cmd->option_id);
+static int device_handler_init_sources(
+		struct device_handler *handler __attribute__((unused)))
+{
+	return 0;
+}
 
-	boot(handler, opt, cmd, 0);
+static void device_handler_reinit_sources(
+		struct device_handler *handler __attribute__((unused)))
+{
 }
+
+static int umount_device(struct discover_device *dev __attribute__((unused)))
+{
+	return 0;
+}
+
+static int __attribute__((unused)) mount_device(
+		struct discover_device *dev __attribute__((unused)))
+{
+	return 0;
+}
+
+int device_request_write(struct discover_device *dev __attribute__((unused)),
+		bool *release)
+{
+	*release = true;
+	return 0;
+}
+
+void device_release_write(struct discover_device *dev __attribute__((unused)),
+	bool release __attribute__((unused)))
+{
+}
+
+#endif
+