X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fdevice-handler.c;h=02ae6884db47876cffb740d86841c6f9c40afc82;hp=0fc6d75b0e64db0ce0a01773a779fd269663acfc;hb=e39c5ad541830cecbd331f877ef43ded738a9251;hpb=d70b3460fbbcc9acb4a80e1e6fe51d564ae607aa

diff --git a/discover/device-handler.c b/discover/device-handler.c
index 0fc6d75..02ae688 100644
--- a/discover/device-handler.c
+++ b/discover/device-handler.c
@@ -7,11 +7,13 @@
 #include <sys/stat.h>
 #include <sys/wait.h>
 
+#include <pb-config/pb-config.h>
 #include <talloc/talloc.h>
 #include <list/list.h>
 #include <log/log.h>
 #include <types/types.h>
 #include <system/system.h>
+#include <process/process.h>
 #include <url/url.h>
 
 #include "device-handler.h"
@@ -19,7 +21,6 @@
 #include "event.h"
 #include "parser.h"
 #include "resource.h"
-#include "udev.h"
 #include "paths.h"
 #include "boot.h"
 
@@ -30,157 +31,235 @@ struct device_handler {
 	struct discover_device	**devices;
 	unsigned int		n_devices;
 
+	struct waitset		*waitset;
+	struct waiter		*timeout_waiter;
+	bool			autoboot_enabled;
+	unsigned int		sec_to_boot;
+
+	struct discover_boot_option *default_boot_option;
 	struct list		unresolved_boot_options;
 };
 
-static bool resource_is_resolved(struct resource *res)
+static int mount_device(struct discover_device *dev);
+static int umount_device(struct discover_device *dev);
+
+void discover_context_add_boot_option(struct discover_context *ctx,
+		struct discover_boot_option *boot_option)
 {
-	return !res || res->resolved;
+	boot_option->source = ctx->parser;
+	list_add_tail(&ctx->boot_options, &boot_option->list);
+	talloc_steal(ctx, boot_option);
 }
 
-/* We only use this in an assert, which will disappear if we're compiling
- * with NDEBUG, so we need the 'used' attribute for these builds */
-static bool __attribute__((used)) boot_option_is_resolved(
-		struct discover_boot_option *opt)
+/**
+ * device_handler_get_device_count - Get the count of current handler devices.
+ */
+
+int device_handler_get_device_count(const struct device_handler *handler)
 {
-	return resource_is_resolved(opt->boot_image) &&
-		resource_is_resolved(opt->initrd) &&
-		resource_is_resolved(opt->icon);
+	return handler->n_devices;
 }
 
-static bool resource_resolve(struct resource *res, struct parser *parser,
-		struct device_handler *handler)
-{
-	if (resource_is_resolved(res))
-		return true;
+/**
+ * device_handler_get_device - Get a handler device by index.
+ */
 
-	parser->resolve_resource(handler, res);
+const struct discover_device *device_handler_get_device(
+	const struct device_handler *handler, unsigned int index)
+{
+	if (index >= handler->n_devices) {
+		assert(0 && "bad index");
+		return NULL;
+	}
 
-	return res->resolved;
+	return handler->devices[index];
 }
 
-static bool boot_option_resolve(struct discover_boot_option *opt,
-		struct device_handler *handler)
+struct discover_boot_option *discover_boot_option_create(
+		struct discover_context *ctx,
+		struct discover_device *device)
 {
-	return resource_resolve(opt->boot_image, opt->source, handler) &&
-		resource_resolve(opt->initrd, opt->source, handler) &&
-		resource_resolve(opt->icon, opt->source, handler);
+	struct discover_boot_option *opt;
+
+	opt = talloc_zero(ctx, struct discover_boot_option);
+	opt->option = talloc_zero(opt, struct boot_option);
+	opt->device = device;
+
+	return opt;
 }
 
-static void boot_option_finalise(struct discover_boot_option *opt)
+static int device_match_uuid(struct discover_device *dev, const char *uuid)
 {
-	assert(boot_option_is_resolved(opt));
+	return dev->uuid && !strcmp(dev->uuid, uuid);
+}
 
-	/* check that the parsers haven't set any of the final data */
-	assert(!opt->option->boot_image_file);
-	assert(!opt->option->initrd_file);
-	assert(!opt->option->icon_file);
+static int device_match_label(struct discover_device *dev, const char *label)
+{
+	return dev->label && !strcmp(dev->label, label);
+}
 
-	if (opt->boot_image)
-		opt->option->boot_image_file = opt->boot_image->url->full;
-	if (opt->initrd)
-		opt->option->initrd_file = opt->initrd->url->full;
-	if (opt->icon)
-		opt->option->icon_file = opt->icon->url->full;
+static int device_match_id(struct discover_device *dev, const char *id)
+{
+	return !strcmp(dev->device->id, id);
 }
 
-static void process_boot_option_queue(struct device_handler *handler)
+static struct discover_device *device_lookup(
+		struct device_handler *device_handler,
+		int (match_fn)(struct discover_device *, const char *),
+		const char *str)
 {
-	struct discover_boot_option *opt, *tmp;
+	struct discover_device *dev;
+	unsigned int i;
 
-	list_for_each_entry_safe(&handler->unresolved_boot_options,
-			opt, tmp, list) {
+	if (!str)
+		return NULL;
 
-		if (!boot_option_resolve(opt, handler))
-			continue;
+	for (i = 0; i < device_handler->n_devices; i++) {
+		dev = device_handler->devices[i];
 
-		list_remove(&opt->list);
-		list_add(&opt->device->boot_options, &opt->list);
-		talloc_steal(opt->device, opt);
-		boot_option_finalise(opt);
-		discover_server_notify_boot_option_add(handler->server,
-							opt->option);
+		if (match_fn(dev, str))
+			return dev;
 	}
+
+	return NULL;
 }
 
-/**
- * context_commit - Commit a temporary discovery context to the handler,
- * and notify the clients about any new options / devices
- */
-static void context_commit(struct device_handler *handler,
-		struct discover_context *ctx)
+struct discover_device *device_lookup_by_name(struct device_handler *handler,
+		const char *name)
 {
-	struct discover_device *dev = ctx->device;
-	struct discover_boot_option *opt, *tmp;
-	unsigned int i, existing_device = 0;
+	if (!strncmp(name, "/dev/", strlen("/dev/")))
+		name += strlen("/dev/");
 
-	/* do we already have this device? */
-	for (i = 0; i < handler->n_devices; i++) {
-		if (ctx->device == handler->devices[i]) {
-			existing_device = 1;
-			break;
-		}
-	}
+	return device_lookup_by_id(handler, name);
+}
 
-	/* if not already present, add the device to the handler's array */
-	if (!existing_device) {
-		handler->n_devices++;
-		handler->devices = talloc_realloc(handler, handler->devices,
-			struct discover_device *, handler->n_devices);
-		handler->devices[handler->n_devices - 1] = dev;
-		talloc_steal(handler, dev);
+struct discover_device *device_lookup_by_uuid(
+		struct device_handler *device_handler,
+		const char *uuid)
+{
+	return device_lookup(device_handler, device_match_uuid, uuid);
+}
 
-		discover_server_notify_device_add(handler->server, dev->device);
+struct discover_device *device_lookup_by_label(
+		struct device_handler *device_handler,
+		const char *label)
+{
+	return device_lookup(device_handler, device_match_label, label);
+}
 
-		/* this new device might be able to resolve existing boot
-		 * options */
-		process_boot_option_queue(handler);
-	}
+struct discover_device *device_lookup_by_id(
+		struct device_handler *device_handler,
+		const char *id)
+{
+	return device_lookup(device_handler, device_match_id, id);
+}
 
+void device_handler_destroy(struct device_handler *handler)
+{
+	talloc_free(handler);
+}
 
-	/* move boot options from the context to the device */
-	list_for_each_entry_safe(&ctx->boot_options, opt, tmp, list) {
-		list_remove(&opt->list);
+static int destroy_device(void *arg)
+{
+	struct discover_device *dev = arg;
 
-		if (boot_option_resolve(opt, handler)) {
-			list_add(&dev->boot_options, &opt->list);
-			talloc_steal(dev, opt);
-			boot_option_finalise(opt);
-			discover_server_notify_boot_option_add(handler->server,
-								opt->option);
-		} else {
-			if (!opt->source->resolve_resource) {
-				pb_log("parser %s gave us an unresolved "
-					"resource (%s), but no way to "
-					"resolve it\n",
-					opt->source->name, opt->option->id);
-				talloc_free(opt);
-			} else {
-				pb_log("boot option %s is unresolved, "
-						"adding to queue\n",
-						opt->option->id);
-				list_add(&handler->unresolved_boot_options,
-						&opt->list);
-				talloc_steal(handler, opt);
-			}
+	umount_device(dev);
+
+	return 0;
+}
+
+struct discover_device *discover_device_create(struct device_handler *handler,
+		const char *id)
+{
+	struct discover_device *dev;
+
+	dev = device_lookup_by_id(handler, id);
+	if (dev)
+		return dev;
+
+	dev = talloc_zero(handler, struct discover_device);
+	dev->device = talloc_zero(dev, struct device);
+	dev->device->id = talloc_strdup(dev->device, id);
+	list_init(&dev->params);
+	list_init(&dev->boot_options);
+
+	talloc_set_destructor(dev, destroy_device);
+
+	return dev;
+}
+
+struct discover_device_param {
+	char			*name;
+	char			*value;
+	struct list_item	list;
+};
+
+void discover_device_set_param(struct discover_device *device,
+		const char *name, const char *value)
+{
+	struct discover_device_param *param;
+	bool found = false;
+
+	list_for_each_entry(&device->params, param, list) {
+		if (!strcmp(param->name, name)) {
+			found = true;
+			break;
 		}
 	}
+
+	if (!found) {
+		if (!value)
+			return;
+		param = talloc(device, struct discover_device_param);
+		param->name = talloc_strdup(param, name);
+		list_add(&device->params, &param->list);
+	} else {
+		if (!value) {
+			list_remove(&param->list);
+			talloc_free(param);
+			return;
+		}
+		talloc_free(param->value);
+	}
+
+	param->value = talloc_strdup(param, value);
 }
 
-void discover_context_add_boot_option(struct discover_context *ctx,
-		struct discover_boot_option *boot_option)
+const char *discover_device_get_param(struct discover_device *device,
+		const char *name)
 {
-	boot_option->source = ctx->parser;
-	list_add_tail(&ctx->boot_options, &boot_option->list);
-	talloc_steal(ctx, boot_option);
+	struct discover_device_param *param;
+
+	list_for_each_entry(&device->params, param, list) {
+		if (!strcmp(param->name, name))
+			return param->name;
+	}
+	return NULL;
 }
 
-/**
- * device_handler_remove - Remove a device from the handler device array.
- */
+struct device_handler *device_handler_init(struct discover_server *server,
+		struct waitset *waitset, int dry_run)
+{
+	struct device_handler *handler;
+
+	handler = talloc_zero(NULL, struct device_handler);
+	handler->server = server;
+	handler->waitset = waitset;
+	handler->dry_run = dry_run;
+	handler->autoboot_enabled = config_get()->autoboot_enabled;
 
-static void device_handler_remove(struct device_handler *handler,
-	struct discover_device *device)
+	list_init(&handler->unresolved_boot_options);
+
+	/* set up our mount point base */
+	pb_mkdir_recursive(mount_base());
+
+	parser_init();
+
+	return handler;
+}
+
+void device_handler_remove(struct device_handler *handler,
+		struct discover_device *device)
 {
 	unsigned int i;
 
@@ -189,7 +268,7 @@ static void device_handler_remove(struct device_handler *handler,
 			break;
 
 	if (i == handler->n_devices) {
-		assert(0 && "unknown device");
+		talloc_free(device);
 		return;
 	}
 
@@ -199,495 +278,452 @@ static void device_handler_remove(struct device_handler *handler,
 	handler->devices = talloc_realloc(handler, handler->devices,
 		struct discover_device *, handler->n_devices);
 
-	discover_server_notify_device_remove(handler->server, device->device);
+	if (device->notified)
+		discover_server_notify_device_remove(handler->server,
+							device->device);
 
 	talloc_free(device);
 }
 
-/**
- * device_handler_get_device_count - Get the count of current handler devices.
- */
-
-int device_handler_get_device_count(const struct device_handler *handler)
-{
-	return handler->n_devices;
-}
-
-/**
- * device_handler_get_device - Get a handler device by index.
- */
-
-const struct discover_device *device_handler_get_device(
-	const struct device_handler *handler, unsigned int index)
+static void boot_status(void *arg, struct boot_status *status)
 {
-	if (index >= handler->n_devices) {
-		assert(0 && "bad index");
-		return NULL;
-	}
+	struct device_handler *handler = arg;
 
-	return handler->devices[index];
+	discover_server_notify_boot_status(handler->server, status);
 }
 
-static int mount_device(struct discover_device *dev)
+static void countdown_status(struct device_handler *handler,
+		struct discover_boot_option *opt, unsigned int sec)
 {
-	const char *argv[6];
-
-	if (!dev->mount_path)
-		dev->mount_path = join_paths(dev, mount_base(),
-						dev->device_path);
-
-	if (pb_mkdir_recursive(dev->mount_path))
-		pb_log("couldn't create mount directory %s: %s\n",
-				dev->mount_path, strerror(errno));
+	struct boot_status status;
 
-	argv[0] = pb_system_apps.mount;
-	argv[1] = dev->device_path;
-	argv[2] = dev->mount_path;
-	argv[3] = "-o";
-	argv[4] = "ro";
-	argv[5] = NULL;
+	status.type = BOOT_STATUS_INFO;
+	status.progress = -1;
+	status.detail = NULL;
+	status.message = talloc_asprintf(handler,
+			"Booting %s in %u sec", opt->option->name, sec);
 
-	if (pb_run_cmd(argv, 1, 0)) {
+	discover_server_notify_boot_status(handler->server, &status);
 
-		/* Retry mount without ro option. */
-
-		argv[0] = pb_system_apps.mount;
-		argv[1] = dev->device_path;
-		argv[2] = dev->mount_path;
-		argv[3] = NULL;
-
-		if (pb_run_cmd(argv, 1, 0))
-			goto out_rmdir;
-	}
-
-	return 0;
-
-out_rmdir:
-	pb_rmdir_recursive(mount_base(), dev->mount_path);
-	return -1;
+	talloc_free(status.message);
 }
 
-static int umount_device(struct discover_device *dev)
+static int default_timeout(void *arg)
 {
-	int status;
-	pid_t pid;
+	struct device_handler *handler = arg;
+	struct discover_boot_option *opt;
 
-	if (!dev->mount_path)
+	if (!handler->default_boot_option)
 		return 0;
 
-	pid = fork();
-	if (pid == -1) {
-		pb_log("%s: fork failed: %s\n", __func__, strerror(errno));
-		return -1;
-	}
-
-	if (pid == 0) {
-		execl(pb_system_apps.umount, pb_system_apps.umount,
-						dev->mount_path, NULL);
-		exit(EXIT_FAILURE);
-	}
+	opt = handler->default_boot_option;
 
-	if (waitpid(pid, &status, 0) == -1) {
-		pb_log("%s: waitpid failed: %s\n", __func__,
-				strerror(errno));
-		return -1;
+	if (handler->sec_to_boot) {
+		countdown_status(handler, opt, handler->sec_to_boot);
+		handler->sec_to_boot--;
+		handler->timeout_waiter = waiter_register_timeout(
+						handler->waitset, 1000,
+						default_timeout, handler);
+		return 0;
 	}
 
-	if (!WIFEXITED(status) || WEXITSTATUS(status) != 0)
-		return -1;
-
-	pb_rmdir_recursive(mount_base(), dev->mount_path);
+	pb_log("Timeout expired, booting default option %s\n", opt->option->id);
 
+	boot(handler, handler->default_boot_option, NULL,
+			handler->dry_run, boot_status, handler);
 	return 0;
 }
 
-static struct discover_device *find_device(struct device_handler *handler,
-		const char *id)
+static bool priority_match(struct boot_priority *prio,
+		struct discover_boot_option *opt)
 {
-	struct discover_device *dev;
-	unsigned int i;
-
-	for (i = 0; i < handler->n_devices; i++) {
-		dev = handler->devices[i];
-		if (!strcmp(dev->device->id, id))
-			return dev;
-	}
-
-	return NULL;
+	return prio->type == opt->device->device->type;
 }
 
-static int destroy_device(void *arg)
+static int default_option_priority(struct discover_boot_option *opt)
 {
-	struct discover_device *dev = arg;
+	const struct config *config;
+	struct boot_priority *prio;
+	int i;
 
-	umount_device(dev);
+	config = config_get();
 
-	return 0;
+	for (i = 0; i < config->n_boot_priorities; i++) {
+		prio = &config->boot_priorities[i];
+		if (priority_match(prio, opt))
+			break;
+	}
+
+	return i;
 }
 
-static struct discover_device *discover_device_create(
-		struct device_handler *handler,
-		struct discover_context *ctx,
-		struct event *event)
+static void set_default(struct device_handler *handler,
+		struct discover_boot_option *opt)
 {
-	struct discover_device *dev;
-	const char *devname;
+	if (!handler->autoboot_enabled)
+		return;
 
-	dev = find_device(handler, event->device);
-	if (dev)
-		return dev;
+	/* Resolve any conflicts: if we have a new default option, it only
+	 * replaces the current if it has a higher priority. */
+	if (handler->default_boot_option) {
+		int new_prio, cur_prio;
 
-	dev = talloc_zero(ctx, struct discover_device);
-	dev->device = talloc_zero(dev, struct device);
-	list_init(&dev->boot_options);
+		new_prio = default_option_priority(opt);
+		cur_prio = default_option_priority(
+					handler->default_boot_option);
+
+		if (new_prio < cur_prio) {
+			handler->default_boot_option = opt;
+			/* extend the timeout a little, so the user sees some
+			 * indication of the change */
+			handler->sec_to_boot += 2;
+		}
 
-	devname = event_get_param(ctx->event, "DEVNAME");
-	if (devname)
-		dev->device_path = talloc_strdup(dev, devname);
+		return;
+	}
 
-	dev->device->id = talloc_strdup(dev, event->device);
+	handler->sec_to_boot = config_get()->autoboot_timeout_sec;
+	handler->default_boot_option = opt;
 
-	talloc_set_destructor(dev, destroy_device);
+	pb_log("Boot option %s set as default, timeout %u sec.\n",
+	       opt->option->id, handler->sec_to_boot);
 
-	return dev;
+	default_timeout(handler);
 }
 
-struct discover_boot_option *discover_boot_option_create(
-		struct discover_context *ctx,
-		struct discover_device *device)
+static bool resource_is_resolved(struct resource *res)
 {
-	struct discover_boot_option *opt;
-
-	opt = talloc_zero(ctx, struct discover_boot_option);
-	opt->option = talloc_zero(opt, struct boot_option);
-	opt->device = device;
-
-	return opt;
+	return !res || res->resolved;
 }
 
+/* We only use this in an assert, which will disappear if we're compiling
+ * with NDEBUG, so we need the 'used' attribute for these builds */
+static bool __attribute__((used)) boot_option_is_resolved(
+		struct discover_boot_option *opt)
+{
+	return resource_is_resolved(opt->boot_image) &&
+		resource_is_resolved(opt->initrd) &&
+		resource_is_resolved(opt->dtb) &&
+		resource_is_resolved(opt->icon);
+}
 
-static int handle_add_udev_event(struct device_handler *handler,
-		struct event *event)
+static bool resource_resolve(struct resource *res, const char *name,
+		struct discover_boot_option *opt,
+		struct device_handler *handler)
 {
-	struct discover_context *ctx;
-	struct discover_device *dev;
-	const char *param;
-	int rc;
+	struct parser *parser = opt->source;
+
+	if (resource_is_resolved(res))
+		return true;
 
-	/* create our context */
-	ctx = talloc(handler, struct discover_context);
-	ctx->event = event;
-	list_init(&ctx->boot_options);
+	pb_log("Attempting to resolve resource %s->%s with parser %s\n",
+			opt->option->id, name, parser->name);
+	parser->resolve_resource(handler, res);
 
-	/* create our top-level device */
-	dev = discover_device_create(handler, ctx, event);
+	return res->resolved;
+}
 
-	ctx->device = dev;
+static bool boot_option_resolve(struct discover_boot_option *opt,
+		struct device_handler *handler)
+{
+	return resource_resolve(opt->boot_image, "boot_image", opt, handler) &&
+		resource_resolve(opt->initrd, "initrd", opt, handler) &&
+		resource_resolve(opt->dtb, "dtb", opt, handler) &&
+		resource_resolve(opt->icon, "icon", opt, handler);
+}
 
-	/* try to parse UUID and labels */
-	param = event_get_param(ctx->event, "ID_FS_UUID");
-	if (param)
-		dev->uuid = talloc_strdup(dev, param);
+static void boot_option_finalise(struct device_handler *handler,
+		struct discover_boot_option *opt)
+{
+	assert(boot_option_is_resolved(opt));
 
-	param = event_get_param(ctx->event, "ID_FS_LABEL");
-	if (param)
-		dev->label = talloc_strdup(dev, param);
+	/* check that the parsers haven't set any of the final data */
+	assert(!opt->option->boot_image_file);
+	assert(!opt->option->initrd_file);
+	assert(!opt->option->dtb_file);
+	assert(!opt->option->icon_file);
+	assert(!opt->option->device_id);
 
-	rc = mount_device(dev);
-	if (rc) {
-		talloc_free(ctx);
-		return 0;
-	}
+	if (opt->boot_image)
+		opt->option->boot_image_file = opt->boot_image->url->full;
+	if (opt->initrd)
+		opt->option->initrd_file = opt->initrd->url->full;
+	if (opt->dtb)
+		opt->option->dtb_file = opt->dtb->url->full;
+	if (opt->icon)
+		opt->option->icon_file = opt->icon->url->full;
 
-	/* run the parsers. This will populate the ctx's boot_option list. */
-	iterate_parsers(ctx, CONF_METHOD_LOCAL_FILE);
+	opt->option->device_id = opt->device->device->id;
 
-	/* add discovered stuff to the handler */
-	context_commit(handler, ctx);
+	if (opt->option->is_default)
+		set_default(handler, opt);
+}
 
-	talloc_free(ctx);
+static void notify_boot_option(struct device_handler *handler,
+		struct discover_boot_option *opt)
+{
+	struct discover_device *dev = opt->device;
 
-	return 0;
+	if (!dev->notified)
+		discover_server_notify_device_add(handler->server,
+						  opt->device->device);
+	dev->notified = true;
+	discover_server_notify_boot_option_add(handler->server, opt->option);
 }
 
-static int handle_remove_udev_event(struct device_handler *handler,
-		struct event *event)
+static void process_boot_option_queue(struct device_handler *handler)
 {
-	struct discover_device *dev;
+	struct discover_boot_option *opt, *tmp;
 
-	dev = find_device(handler, event->device);
-	if (!dev)
-		return 0;
+	list_for_each_entry_safe(&handler->unresolved_boot_options,
+			opt, tmp, list) {
 
-	/* remove device from handler device array */
-	device_handler_remove(handler, dev);
+		pb_log("queue: attempting resolution for %s\n",
+				opt->option->id);
 
-	return 0;
+		if (!boot_option_resolve(opt, handler))
+			continue;
+
+		pb_log("\tresolved!\n");
+
+		list_remove(&opt->list);
+		list_add_tail(&opt->device->boot_options, &opt->list);
+		talloc_steal(opt->device, opt);
+		boot_option_finalise(handler, opt);
+		notify_boot_option(handler, opt);
+	}
 }
 
-static int handle_add_user_event(struct device_handler *handler,
-		struct event *event)
+struct discover_context *device_handler_discover_context_create(
+		struct device_handler *handler,
+		struct discover_device *device)
 {
 	struct discover_context *ctx;
-	struct discover_device *dev;
-	int rc;
-
-	assert(event->device);
 
 	ctx = talloc(handler, struct discover_context);
-	ctx->event = event;
+	ctx->device = device;
+	ctx->conf_url = NULL;
 	list_init(&ctx->boot_options);
 
-	dev = discover_device_create(handler, ctx, event);
-	ctx->device = dev;
-
-	rc = parse_user_event(ctx, event);
-
-	if (!rc)
-		context_commit(handler, ctx);
-
-	return rc;
+	return ctx;
 }
 
-static int handle_remove_user_event(struct device_handler *handler,
-		struct event *event)
+/**
+ * context_commit - Commit a temporary discovery context to the handler,
+ * and notify the clients about any new options / devices
+ */
+void device_handler_discover_context_commit(struct device_handler *handler,
+		struct discover_context *ctx)
 {
-	struct discover_device *dev = find_device(handler, event->device);
+	struct discover_device *dev = ctx->device;
+	struct discover_boot_option *opt, *tmp;
 
-	if (!dev)
-		return 0;
+	if (!device_lookup_by_id(handler, dev->device->id))
+		device_handler_add_device(handler, dev);
 
-	/* remove device from handler device array */
-	device_handler_remove(handler, dev);
+	/* move boot options from the context to the device */
+	list_for_each_entry_safe(&ctx->boot_options, opt, tmp, list) {
+		list_remove(&opt->list);
 
-	return 0;
+		if (boot_option_resolve(opt, handler)) {
+			pb_log("boot option %s is resolved, "
+					"sending to clients\n",
+					opt->option->id);
+			list_add_tail(&dev->boot_options, &opt->list);
+			talloc_steal(dev, opt);
+			boot_option_finalise(handler, opt);
+			notify_boot_option(handler, opt);
+		} else {
+			if (!opt->source->resolve_resource) {
+				pb_log("parser %s gave us an unresolved "
+					"resource (%s), but no way to "
+					"resolve it\n",
+					opt->source->name, opt->option->id);
+				talloc_free(opt);
+			} else {
+				pb_log("boot option %s is unresolved, "
+						"adding to queue\n",
+						opt->option->id);
+				list_add(&handler->unresolved_boot_options,
+						&opt->list);
+				talloc_steal(handler, opt);
+			}
+		}
+	}
 }
 
-static enum conf_method parse_conf_method(const char *str)
+void device_handler_add_device(struct device_handler *handler,
+		struct discover_device *device)
 {
+	handler->n_devices++;
+	handler->devices = talloc_realloc(handler, handler->devices,
+				struct discover_device *, handler->n_devices);
+	handler->devices[handler->n_devices - 1] = device;
 
-	if (!strcasecmp(str, "dhcp")) {
-		return CONF_METHOD_DHCP;
-	}
-	return CONF_METHOD_UNKNOWN;
 }
 
-static int handle_conf_user_event(struct device_handler *handler,
-		struct event *event)
+/* Start discovery on a hotplugged device. The device will be in our devices
+ * array, but has only just been initialised by the hotplug source.
+ */
+int device_handler_discover(struct device_handler *handler,
+		struct discover_device *dev, enum conf_method method)
 {
 	struct discover_context *ctx;
-	struct discover_device *dev;
-	enum conf_method method;
-	const char *val;
-
-	ctx = talloc(handler, struct discover_context);
-	ctx->event = event;
-	list_init(&ctx->boot_options);
 
-	val = event_get_param(event, "url");
-	if (!val) {
-		talloc_free(ctx);
-		return 0;
-	}
-
-	ctx->conf_url = pb_url_parse(ctx, val);
-	if (!ctx->conf_url) {
-		talloc_free(ctx);
-		return 0;
-	}
-
-	val = event_get_param(event, "method");
-	if (!val) {
-		talloc_free(ctx);
-		return 0;
-	}
+	process_boot_option_queue(handler);
 
-	method = parse_conf_method(val);
-	if (method == CONF_METHOD_UNKNOWN) {
-		talloc_free(ctx);
-		return 0;
-	}
+	/* create our context */
+	ctx = device_handler_discover_context_create(handler, dev);
 
-	dev = discover_device_create(handler, ctx, event);
-	ctx->device = dev;
+	mount_device(dev);
 
+	/* run the parsers. This will populate the ctx's boot_option list. */
 	iterate_parsers(ctx, method);
 
-	context_commit(handler, ctx);
+	/* add discovered stuff to the handler */
+	device_handler_discover_context_commit(handler, ctx);
+
+	talloc_free(ctx);
 
 	return 0;
 }
 
-typedef int (*event_handler)(struct device_handler *, struct event *);
+/* incoming conf event */
+int device_handler_conf(struct device_handler *handler,
+		struct discover_device *dev, struct pb_url *url,
+		enum conf_method method)
+{
+	struct discover_context *ctx;
+
+	/* create our context */
+	ctx = device_handler_discover_context_create(handler, dev);
+	ctx->conf_url = url;
 
-static event_handler handlers[EVENT_TYPE_MAX][EVENT_ACTION_MAX] = {
-	[EVENT_TYPE_UDEV] = {
-		[EVENT_ACTION_ADD]	= handle_add_udev_event,
-		[EVENT_ACTION_REMOVE]	= handle_remove_udev_event,
-	},
-	[EVENT_TYPE_USER] = {
-		[EVENT_ACTION_ADD]	= handle_add_user_event,
-		[EVENT_ACTION_REMOVE]	= handle_remove_user_event,
-		[EVENT_ACTION_CONF]	= handle_conf_user_event,
-	}
-};
+	iterate_parsers(ctx, method);
 
-int device_handler_event(struct device_handler *handler,
-		struct event *event)
-{
-	if (event->type >= EVENT_TYPE_MAX ||
-			event->action >= EVENT_ACTION_MAX ||
-			!handlers[event->type][event->action]) {
-		pb_log("%s unknown type/action: %d/%d\n", __func__,
-				event->type, event->action);
-		return 0;
-	}
+	device_handler_discover_context_commit(handler, ctx);
+
+	talloc_free(ctx);
 
-	return handlers[event->type][event->action](handler, event);
+	return 0;
 }
 
-struct device_handler *device_handler_init(struct discover_server *server,
-		int dry_run)
+static struct discover_boot_option *find_boot_option_by_id(
+		struct device_handler *handler, const char *id)
 {
-	struct device_handler *handler;
-
-	handler = talloc(NULL, struct device_handler);
-	handler->devices = NULL;
-	handler->n_devices = 0;
-	handler->server = server;
-	handler->dry_run = dry_run;
-	list_init(&handler->unresolved_boot_options);
+	unsigned int i;
 
-	/* set up our mount point base */
-	pb_mkdir_recursive(mount_base());
+	for (i = 0; i < handler->n_devices; i++) {
+		struct discover_device *dev = handler->devices[i];
+		struct discover_boot_option *opt;
 
-	parser_init();
+		list_for_each_entry(&dev->boot_options, opt, list)
+			if (!strcmp(opt->option->id, id))
+				return opt;
+	}
 
-	return handler;
+	return NULL;
 }
 
-void device_handler_destroy(struct device_handler *handler)
+void device_handler_boot(struct device_handler *handler,
+		struct boot_command *cmd)
 {
-	talloc_free(handler);
-}
+	struct discover_boot_option *opt;
 
-static int device_match_path(struct discover_device *dev, const char *path)
-{
-	return !strcmp(dev->device_path, path);
-}
+	opt = find_boot_option_by_id(handler, cmd->option_id);
 
-static int device_match_uuid(struct discover_device *dev, const char *uuid)
-{
-	return dev->uuid && !strcmp(dev->uuid, uuid);
+	boot(handler, opt, cmd, handler->dry_run, boot_status, handler);
 }
 
-static int device_match_label(struct discover_device *dev, const char *label)
+void device_handler_cancel_default(struct device_handler *handler)
 {
-	return dev->label && !strcmp(dev->label, label);
-}
+	struct boot_status status;
 
-static int device_match_id(struct discover_device *dev, const char *id)
-{
-	return !strcmp(dev->device->id, id);
-}
+	if (handler->timeout_waiter)
+		waiter_remove(handler->timeout_waiter);
 
-static struct discover_device *device_lookup(
-		struct device_handler *device_handler,
-		int (match_fn)(struct discover_device *, const char *),
-		const char *str)
-{
-	struct discover_device *dev;
-	unsigned int i;
+	handler->timeout_waiter = NULL;
+	handler->autoboot_enabled = false;
 
-	if (!str)
-		return NULL;
+	/* we only send status if we had a default boot option queued */
+	if (!handler->default_boot_option)
+		return;
 
-	for (i = 0; i < device_handler->n_devices; i++) {
-		dev = device_handler->devices[i];
+	pb_log("Cancelling default boot option\n");
 
-		if (match_fn(dev, str))
-			return dev;
-	}
+	handler->default_boot_option = NULL;
 
-	return NULL;
+	status.type = BOOT_STATUS_INFO;
+	status.progress = -1;
+	status.detail = NULL;
+	status.message = "Default boot cancelled";
+
+	discover_server_notify_boot_status(handler->server, &status);
 }
 
-struct discover_device *device_lookup_by_name(struct device_handler *handler,
-		const char *name)
+#ifndef PETITBOOT_TEST
+static int mount_device(struct discover_device *dev)
 {
-	struct discover_device *dev;
-	char *path;
+	int rc;
+
+	if (!dev->device_path)
+		return -1;
+
+	if (!dev->mount_path)
+		dev->mount_path = join_paths(dev, mount_base(),
+						dev->device_path);
 
-	if (strncmp(name, "/dev/", strlen("/dev/")))
-		path = talloc_asprintf(NULL, "/dev/%s", name);
-	else
-		path = talloc_strdup(NULL, name);
+	if (pb_mkdir_recursive(dev->mount_path))
+		pb_log("couldn't create mount directory %s: %s\n",
+				dev->mount_path, strerror(errno));
 
-	dev = device_lookup_by_path(handler, path);
+	rc = process_run_simple(dev, pb_system_apps.mount,
+			dev->device_path, dev->mount_path,
+			"-o", "ro", NULL);
 
-	talloc_free(path);
+	if (!rc)
+		return 0;
 
-	return dev;
-}
+	/* Retry mount without ro option. */
+	rc = process_run_simple(dev, pb_system_apps.mount,
+			dev->device_path, dev->mount_path, NULL);
 
-struct discover_device *device_lookup_by_path(
-		struct device_handler *device_handler,
-		const char *path)
-{
-	return device_lookup(device_handler, device_match_path, path);
-}
+	if (!rc)
+		return 0;
 
-struct discover_device *device_lookup_by_uuid(
-		struct device_handler *device_handler,
-		const char *uuid)
-{
-	return device_lookup(device_handler, device_match_uuid, uuid);
+	pb_rmdir_recursive(mount_base(), dev->mount_path);
+	return -1;
 }
 
-struct discover_device *device_lookup_by_label(
-		struct device_handler *device_handler,
-		const char *label)
+static int umount_device(struct discover_device *dev)
 {
-	return device_lookup(device_handler, device_match_label, label);
-}
+	int status;
 
-struct discover_device *device_lookup_by_id(
-		struct device_handler *device_handler,
-		const char *id)
-{
-	return device_lookup(device_handler, device_match_id, id);
-}
+	if (!dev->mount_path)
+		return 0;
 
-static struct discover_boot_option *find_boot_option_by_id(
-		struct device_handler *handler, const char *id)
-{
-	unsigned int i;
+	status = process_run_simple(dev, pb_system_apps.umount,
+			dev->mount_path, NULL);
 
-	for (i = 0; i < handler->n_devices; i++) {
-		struct discover_device *dev = handler->devices[i];
-		struct discover_boot_option *opt;
+	if (!WIFEXITED(status) || WEXITSTATUS(status) != 0)
+		return -1;
 
-		list_for_each_entry(&dev->boot_options, opt, list)
-			if (!strcmp(opt->option->id, id))
-				return opt;
-	}
+	pb_rmdir_recursive(mount_base(), dev->mount_path);
 
-	return NULL;
+	return 0;
 }
+#else
 
-static void boot_status(void *arg, struct boot_status *status)
+static int umount_device(struct discover_device *dev __attribute__((unused)))
 {
-	struct device_handler *handler = arg;
-
-	discover_server_notify_boot_status(handler->server, status);
+	return 0;
 }
 
-void device_handler_boot(struct device_handler *handler,
-		struct boot_command *cmd)
+static int __attribute__((unused)) mount_device(
+		struct discover_device *dev __attribute__((unused)))
 {
-	struct discover_boot_option *opt;
+	return 0;
+}
 
-	opt = find_boot_option_by_id(handler, cmd->option_id);
+#endif
 
-	boot(handler, opt, cmd, handler->dry_run, boot_status, handler);
-}