X-Git-Url: http://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fboot.c;h=f52a91c1c8c18ee405bc0659c4d8847c1280ee99;hp=e7a72d4330c67d4586912cfb2e2c2994f3095203;hb=5c6c8ea8ca66fe70563143cb226852a10b1a98fb;hpb=4926cde5c97d09794ec33cca1321bb05a8d43304 diff --git a/discover/boot.c b/discover/boot.c index e7a72d4..f52a91c 100644 --- a/discover/boot.c +++ b/discover/boot.c @@ -121,17 +121,23 @@ static int kexec_reboot(struct boot_task *task) return result; } -static void update_status(boot_status_fn fn, void *arg, int type, - char *message) +static void __attribute__((format(__printf__, 4, 5))) update_status( + boot_status_fn fn, void *arg, int type, char *fmt, ...) { struct boot_status status; + va_list ap; + + va_start(ap, fmt); + status.message = talloc_vasprintf(NULL, fmt, ap); + va_end(ap); status.type = type; - status.message = message; status.progress = -1; status.detail = NULL; fn(arg, &status); + + talloc_free(status.message); } static void boot_hook_update_param(void *ctx, struct boot_task *task, @@ -279,18 +285,31 @@ int boot(void *ctx, struct discover_boot_option *opt, struct boot_command *cmd, unsigned int clean_image = 0; unsigned int clean_initrd = 0; unsigned int clean_dtb = 0; + const char *boot_desc; int result; image = NULL; initrd = NULL; dtb = NULL; + if (opt && opt->option->name) + boot_desc = opt->option->name; + else if (cmd && cmd->boot_image_file) + boot_desc = cmd->boot_image_file; + else + boot_desc = "(unknown)"; + + update_status(status_fn, status_arg, BOOT_STATUS_INFO, + "Booting %s.", boot_desc); + if (cmd && cmd->boot_image_file) { image = pb_url_parse(opt, cmd->boot_image_file); } else if (opt && opt->boot_image) { image = opt->boot_image->url; } else { - pb_log("%s: no image specified", __func__); + pb_log("%s: no image specified\n", __func__); + update_status(status_fn, status_arg, BOOT_STATUS_INFO, + "Boot failed: no image specified"); return -1; }