]> git.ozlabs.org Git - petitboot/blobdiff - ui/ncurses/nc-boot-editor.c
ncurses/nc-cui: musl libc fixes
[petitboot] / ui / ncurses / nc-boot-editor.c
index 274bd9d2fa1b4df079eb050c10524bc46abad5b1..5b098a4bc6f87eb2c987c1aa691a29989424640b 100644 (file)
@@ -22,7 +22,6 @@
 
 #include <assert.h>
 #include <string.h>
-#include <stdlib.h>
 
 #include "log/log.h"
 #include "talloc/talloc.h"
@@ -45,6 +44,7 @@ struct boot_editor {
                                        struct pmenu_item *item,
                                        struct pb_boot_data *bd);
        bool                    need_redraw;
+       bool                    need_update;
 
        int                     label_x;
        int                     field_x;
@@ -63,6 +63,8 @@ struct boot_editor {
                struct nc_widget_textbox        *dtb_f;
                struct nc_widget_label          *args_l;
                struct nc_widget_textbox        *args_f;
+               struct nc_widget_label          *args_sig_file_l;
+               struct nc_widget_textbox        *args_sig_file_f;
                struct nc_widget_button         *ok_b;
                struct nc_widget_button         *help_b;
                struct nc_widget_button         *cancel_b;
@@ -73,6 +75,9 @@ struct boot_editor {
        char                    *initrd;
        char                    *dtb;
        char                    *args;
+       char                    *args_sig_file;
+
+       bool                    use_signature_files;
 };
 
 extern const struct help_text boot_editor_help_text;
@@ -110,7 +115,14 @@ static struct boot_editor *boot_editor_from_arg(void *arg)
 static int boot_editor_post(struct nc_scr *scr)
 {
        struct boot_editor *boot_editor = boot_editor_from_scr(scr);
-       widgetset_post(boot_editor->widgetset);
+
+       if (boot_editor->need_update) {
+               boot_editor_update(boot_editor, boot_editor->cui->sysinfo);
+               boot_editor->need_update = false;
+       } else {
+               widgetset_post(boot_editor->widgetset);
+       }
+
        nc_scr_frame_draw(scr);
        if (boot_editor->need_redraw) {
                redrawwin(scr->main_ncw);
@@ -150,7 +162,8 @@ static char *conditional_prefix(struct pb_boot_data *ctx,
        sep = "";
        if (!prefix)
                prefix = "";
-       else if (prefix[strlen(prefix)] != '/')
+       else if ((prefix[strlen(prefix) - 1] != '/') &&
+                               (value[0] != '/'))
                sep = "/";
 
        return talloc_asprintf(ctx, "%s%s%s", prefix, sep, value);
@@ -191,6 +204,15 @@ static struct pb_boot_data *boot_editor_prepare_data(
        s = widget_textbox_get_value(boot_editor->widgets.args_f);
        bd->args = *s ? talloc_strdup(bd, s) : NULL;
 
+       if (boot_editor->use_signature_files) {
+               s = widget_textbox_get_value(
+                       boot_editor->widgets.args_sig_file_f);
+               bd->args_sig_file = conditional_prefix(bd, prefix, s);
+       }
+       else {
+               bd->args_sig_file = NULL;
+       }
+
        return bd;
 }
 
@@ -288,7 +310,7 @@ static int layout_pair(struct boot_editor *boot_editor, int y,
 
 static int pad_height(int blockdevs_height)
 {
-       return 10 + blockdevs_height;
+       return 10 + (2 * blockdevs_height);
 }
 
 static void boot_editor_layout_widgets(struct boot_editor *boot_editor)
@@ -316,11 +338,20 @@ static void boot_editor_layout_widgets(struct boot_editor *boot_editor)
        y += layout_pair(boot_editor, y, boot_editor->widgets.args_l,
                                         boot_editor->widgets.args_f);
 
+       if (boot_editor->use_signature_files) {
+               y += layout_pair(boot_editor, y,
+                                       boot_editor->widgets.args_sig_file_l,
+                                       boot_editor->widgets.args_sig_file_f);
+       }
+
 
        y++;
-       widget_move(widget_button_base(boot_editor->widgets.ok_b), y, 9);
-       widget_move(widget_button_base(boot_editor->widgets.help_b), y, 19);
-       widget_move(widget_button_base(boot_editor->widgets.cancel_b), y, 33);
+       widget_move(widget_button_base(boot_editor->widgets.ok_b), y,
+                   boot_editor->field_x);
+       widget_move(widget_button_base(boot_editor->widgets.help_b), y,
+                   boot_editor->field_x + 14);
+       widget_move(widget_button_base(boot_editor->widgets.cancel_b), y,
+                   boot_editor->field_x + 28);
 }
 
 static void boot_editor_widget_focus(struct nc_widget *widget, void *arg)
@@ -435,6 +466,11 @@ static void boot_editor_find_device(struct boot_editor *boot_editor,
        if (bd->dtb && !path_on_device(bd_info, bd->dtb))
                return;
 
+       if (boot_editor->use_signature_files)
+               if (bd->args_sig_file && !path_on_device(bd_info,
+                       bd->args_sig_file))
+                       return;
+
        /* ok, we match; preselect the device option, and remove the common
         * prefix */
        boot_editor->selected_device = bd_info->name;
@@ -444,6 +480,9 @@ static void boot_editor_find_device(struct boot_editor *boot_editor,
                boot_editor->initrd += len;
        if (boot_editor->dtb)
                boot_editor->dtb += len;
+       if (boot_editor->use_signature_files)
+               if (boot_editor->args_sig_file)
+                       boot_editor->args_sig_file += len;
 }
 
 static void boot_editor_setup_widgets(struct boot_editor *boot_editor,
@@ -491,7 +530,18 @@ static void boot_editor_setup_widgets(struct boot_editor *boot_editor,
        boot_editor->widgets.args_f = widget_new_textbox(set, 0, 0,
                                        field_size, boot_editor->args);
 
-       boot_editor->widgets.ok_b = widget_new_button(set, 0, 0, 6,
+       if (boot_editor->use_signature_files) {
+               boot_editor->widgets.args_sig_file_l = widget_new_label(set,
+                               0, 0, _("Argument signature file:"));
+               boot_editor->widgets.args_sig_file_f = widget_new_textbox(set,
+                               0, 0, field_size, boot_editor->args_sig_file);
+       }
+       else {
+               boot_editor->widgets.args_sig_file_l = NULL;
+               boot_editor->widgets.args_sig_file_f = NULL;
+       }
+
+       boot_editor->widgets.ok_b = widget_new_button(set, 0, 0, 10,
                                        _("OK"), ok_click, boot_editor);
        boot_editor->widgets.help_b = widget_new_button(set, 0, 0, 10,
                                        _("Help"), help_click, boot_editor);
@@ -504,6 +554,11 @@ void boot_editor_update(struct boot_editor *boot_editor,
 {
        int height;
 
+       if (boot_editor->cui->current != boot_editor_scr(boot_editor)) {
+               boot_editor->need_update = true;
+               return;
+       }
+
        widgetset_unpost(boot_editor->widgetset);
 
        height = pad_height(sysinfo ? sysinfo->n_blockdevs : 0);
@@ -524,36 +579,6 @@ void boot_editor_update(struct boot_editor *boot_editor,
        pad_refresh(boot_editor);
 }
 
-/* Return the number of columns required to display a localised string */
-static int strncols(const char *str)
-{
-       int i, wlen, ncols = 0;
-       wchar_t *wstr;
-
-       wlen = mbstowcs(NULL, str, 0);
-       if (wlen <= 0)
-               return wlen;
-
-       wstr = malloc(sizeof(wchar_t) * wlen + 1);
-       if (!wstr)
-               return -1;
-
-       wlen = mbstowcs(wstr, str, wlen);
-       if (wlen <= 0) {
-               free(wstr);
-               return wlen;
-       }
-
-       /* Processing each character individually lets us use the same
-        * check for all languages */
-       for (i = 0; i < wlen; i++) {
-               ncols += wcwidth(wstr[i]);
-       }
-
-       free(wstr);
-       return ncols;
-}
-
 struct boot_editor *boot_editor_init(struct cui *cui,
                struct pmenu_item *item,
                const struct system_info *sysinfo,
@@ -562,24 +587,39 @@ struct boot_editor *boot_editor_init(struct cui *cui,
                                struct pb_boot_data *bd))
 {
        struct boot_editor *boot_editor;
+       int ncols1, ncols2, ncols3;
 
        boot_editor = talloc_zero(cui, struct boot_editor);
 
        if (!boot_editor)
                return NULL;
 
+#if defined(HAVE_LIBGPGME)
+       if (access(LOCKDOWN_FILE, F_OK) == -1)
+               boot_editor->use_signature_files = false;
+       else
+               boot_editor->use_signature_files = true;
+#else
+       boot_editor->use_signature_files = false;
+#endif
+
        talloc_set_destructor(boot_editor, boot_editor_destructor);
        boot_editor->cui = cui;
        boot_editor->item = item;
        boot_editor->on_exit = on_exit;
        boot_editor->state = STATE_EDIT;
        boot_editor->need_redraw = false;
+       boot_editor->need_update = false;
 
-       int ncols1 = strncols(_("Device tree:"));
-       int ncols2 = strncols(_("Boot arguments:"));
+       ncols1 = strncols(_("Device tree:"));
+       ncols2 = strncols(_("Boot arguments:"));
+       if (boot_editor->use_signature_files)
+               ncols3 = strncols(_("Argument signature file:"));
+       else
+               ncols3 = 0;
 
        boot_editor->label_x = 1;
-       boot_editor->field_x = 2 + max(ncols1, ncols2);
+       boot_editor->field_x = 2 + max(max(ncols1, ncols2), ncols3);
 
        nc_scr_init(&boot_editor->scr, pb_boot_editor_sig, 0,
                        cui, boot_editor_process_key,
@@ -598,10 +638,15 @@ struct boot_editor *boot_editor_init(struct cui *cui,
                boot_editor->initrd = bd->initrd;
                boot_editor->dtb = bd->dtb;
                boot_editor->args = bd->args;
+               if (boot_editor->use_signature_files)
+                       boot_editor->args_sig_file = bd->args_sig_file;
+               else
+                       boot_editor->args_sig_file = talloc_strdup(bd, "");
                boot_editor_find_device(boot_editor, bd, sysinfo);
        } else {
                boot_editor->image = boot_editor->initrd =
-                       boot_editor->dtb = boot_editor->args = "";
+                       boot_editor->dtb = boot_editor->args =
+                       boot_editor->args_sig_file = "";
        }
 
        boot_editor->pad = newpad(