From f7ead5da96bfb5ce3ebffe11256bbcb5f4b4f750 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Fri, 4 Oct 2019 14:37:14 +0930 Subject: [PATCH] failtest, rbuf: fix up incorrect lseek arg order. SEEK_SET == 0, so it's not hurting anyone now, but when I cut & paste it elsewhere... Signed-off-by: Rusty Russell --- ccan/failtest/test/run-open.c | 2 +- ccan/rbuf/test/run-partial-read.c | 2 +- ccan/rbuf/test/run-term-eof.c | 6 +++--- ccan/rbuf/test/run.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ccan/failtest/test/run-open.c b/ccan/failtest/test/run-open.c index 01665064..8b31ff71 100644 --- a/ccan/failtest/test/run-open.c +++ b/ccan/failtest/test/run-open.c @@ -29,7 +29,7 @@ int main(void) } /* Check it is read-write. */ ok1(write(fd, buf, strlen(buf)) == strlen(buf)); - lseek(fd, SEEK_SET, 0); + lseek(fd, 0, SEEK_SET); ok1(read(fd, buf, strlen("Hello world!")) == strlen("Hello world!")); ok1(strcmp(buf, "Hello world!") == 0); diff --git a/ccan/rbuf/test/run-partial-read.c b/ccan/rbuf/test/run-partial-read.c index 7ecf79d3..8b5d9018 100644 --- a/ccan/rbuf/test/run-partial-read.c +++ b/ccan/rbuf/test/run-partial-read.c @@ -31,7 +31,7 @@ int main(void) /* Grab ourselves for comparison. */ buf[full_read(fd, buf, sizeof(buf))] = '\0'; - lseek(fd, SEEK_SET, 0); + lseek(fd, 0, SEEK_SET); for (i = 0, p = buf; *p; i++) { lines[i] = p; diff --git a/ccan/rbuf/test/run-term-eof.c b/ccan/rbuf/test/run-term-eof.c index 86d7c18d..0c346d7e 100644 --- a/ccan/rbuf/test/run-term-eof.c +++ b/ccan/rbuf/test/run-term-eof.c @@ -27,7 +27,7 @@ int main(void) /* Grab ourselves for comparison. */ len = read(fd, buf, sizeof(buf)); buf[len] = '\0'; - lseek(fd, SEEK_SET, 0); + lseek(fd, 0, SEEK_SET); /* We have exact-size buffer, which causes problems adding term. */ rbuf_init(&in, fd, malloc(len), len, test_realloc); @@ -44,7 +44,7 @@ int main(void) free(rbuf_cleanup(&in)); /* Try again. */ - lseek(fd, SEEK_SET, 0); + lseek(fd, 0, SEEK_SET); rbuf_init(&in, fd, malloc(len), len, test_realloc); p = rbuf_read_str(&in, 64); ok1(p); @@ -53,7 +53,7 @@ int main(void) free(rbuf_cleanup(&in)); /* Normal case, we get rbuf_start after nul */ - lseek(fd, SEEK_SET, 0); + lseek(fd, 0, SEEK_SET); rbuf_init(&in, fd, NULL, 0, test_realloc); p = rbuf_read_str(&in, '^'); ok1(p); diff --git a/ccan/rbuf/test/run.c b/ccan/rbuf/test/run.c index 593ef270..0f0e7d29 100644 --- a/ccan/rbuf/test/run.c +++ b/ccan/rbuf/test/run.c @@ -28,7 +28,7 @@ int main(void) /* Grab ourselves for comparison. */ len = read(fd, buf, sizeof(buf)); buf[len] = '\0'; - lseek(fd, SEEK_SET, 0); + lseek(fd, 0, SEEK_SET); for (i = 0, p = buf; *p; i++) { lines[i] = p; @@ -62,7 +62,7 @@ int main(void) free(rbuf_cleanup(&in)); /* Another way of reading the entire (text) file. */ - lseek(fd, SEEK_SET, 0); + lseek(fd, 0, SEEK_SET); rbuf_init(&in, fd, NULL, 0, test_realloc); p = rbuf_read_str(&in, 0); ok1(p); -- 2.39.2