From 441a3cb13e428cfa4973d83acb68e231a7cd4cf4 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Tue, 15 Nov 2011 12:42:25 +1030 Subject: [PATCH] ccanlint: make fewer tests compulsory. Compulsory means "malformed", we might get rid of it altogether, since any test can mark "fail" and make ccanlint exit with non-zero status. Now we only have four compulsory tests: info_exists Module has _info file depends_exist Module's CCAN dependencies can be found objects_build Module object files can be built module_builds Module can be built from object files --- tools/ccanlint/{compulsory_tests => tests}/depends_build.c | 2 +- .../ccanlint/{compulsory_tests => tests}/main_header_compiles.c | 0 tools/ccanlint/{compulsory_tests => tests}/main_header_exists.c | 2 +- tools/ccanlint/{compulsory_tests => tests}/module_links.c | 0 4 files changed, 2 insertions(+), 2 deletions(-) rename tools/ccanlint/{compulsory_tests => tests}/depends_build.c (98%) rename tools/ccanlint/{compulsory_tests => tests}/main_header_compiles.c (100%) rename tools/ccanlint/{compulsory_tests => tests}/main_header_exists.c (99%) rename tools/ccanlint/{compulsory_tests => tests}/module_links.c (100%) diff --git a/tools/ccanlint/compulsory_tests/depends_build.c b/tools/ccanlint/tests/depends_build.c similarity index 98% rename from tools/ccanlint/compulsory_tests/depends_build.c rename to tools/ccanlint/tests/depends_build.c index ea5c3926..e7faa1f1 100644 --- a/tools/ccanlint/compulsory_tests/depends_build.c +++ b/tools/ccanlint/tests/depends_build.c @@ -13,7 +13,7 @@ #include #include #include -#include "build.h" +#include "../compulsory_tests/build.h" static const char *can_build(struct manifest *m) { diff --git a/tools/ccanlint/compulsory_tests/main_header_compiles.c b/tools/ccanlint/tests/main_header_compiles.c similarity index 100% rename from tools/ccanlint/compulsory_tests/main_header_compiles.c rename to tools/ccanlint/tests/main_header_compiles.c diff --git a/tools/ccanlint/compulsory_tests/main_header_exists.c b/tools/ccanlint/tests/main_header_exists.c similarity index 99% rename from tools/ccanlint/compulsory_tests/main_header_exists.c rename to tools/ccanlint/tests/main_header_exists.c index 68ea1359..b6150dc8 100644 --- a/tools/ccanlint/compulsory_tests/main_header_exists.c +++ b/tools/ccanlint/tests/main_header_exists.c @@ -24,7 +24,7 @@ static void check_has_main_header(struct manifest *m, score->pass = true; score->score = score->total; return; - } + } } score->error = talloc_asprintf(score, "You have no %s/%s.h header file.\n\n" diff --git a/tools/ccanlint/compulsory_tests/module_links.c b/tools/ccanlint/tests/module_links.c similarity index 100% rename from tools/ccanlint/compulsory_tests/module_links.c rename to tools/ccanlint/tests/module_links.c -- 2.39.2