From: Rusty Russell <rusty@rustcorp.com.au>
Date: Sat, 25 Sep 2010 04:27:51 +0000 (+0930)
Subject: tdb2: don't use probe arg to oob()
X-Git-Url: http://git.ozlabs.org/?p=ccan;a=commitdiff_plain;h=86028553af9bac5bca6aebf5f9d29b1494c8c446;ds=sidebyside

tdb2: don't use probe arg to oob()

We want it to complain if it's wrong...
---

diff --git a/ccan/tdb2/check.c b/ccan/tdb2/check.c
index 1ce75be0..cb864ab7 100644
--- a/ccan/tdb2/check.c
+++ b/ccan/tdb2/check.c
@@ -287,8 +287,8 @@ static bool check_free(struct tdb_context *tdb,
 		return false;
 	}
 	if (tdb->methods->oob(tdb, off
-			      + frec->data_len-sizeof(struct tdb_used_record),
-			      true))
+			      + frec->data_len+sizeof(struct tdb_used_record),
+			      false))
 		return false;
 	if (off < zone_off || off >= zone_off + (1ULL<<frec_zone_bits(frec))) {
 		tdb->log(tdb, TDB_DEBUG_ERROR, tdb->log_priv,
@@ -487,7 +487,6 @@ int tdb_check(struct tdb_context *tdb,
 	unsigned max_zone_bits = INITIAL_ZONE_BITS;
 	uint8_t tailer;
 
-	/* This always ensures the header is uptodate. */
 	if (tdb_allrecord_lock(tdb, F_RDLCK, TDB_LOCK_WAIT, false) != 0)
 		return -1;