From: Rusty Russell Date: Sun, 29 Mar 2009 05:53:19 +0000 (+1030) Subject: Patch from Joey Adams: X-Git-Url: http://git.ozlabs.org/?p=ccan;a=commitdiff_plain;h=7c71ddab47d9b06aa140f305c956e454d711e66e Patch from Joey Adams: (15:27:11) joeyadams: ccanlint's handle_no_tests apparently has a bug. It makes the test directory with 0600 permissions, so it can't be used. the x bit provides directory listing privilege (15:27:25) joeyadams: this gives me Permission denied when I try to run it (15:28:34) joeyadams: Changing the opcode to 0700 makes the creation of run.c work --- diff --git a/tools/ccanlint/has_tests.c b/tools/ccanlint/has_tests.c index 320478b3..08668695 100644 --- a/tools/ccanlint/has_tests.c +++ b/tools/ccanlint/has_tests.c @@ -80,7 +80,7 @@ static void handle_no_tests(struct manifest *m, void *check_result) if (!ask("Should I create a template test/run.c file for you?")) return; - if (mkdir("test", 0600) != 0) { + if (mkdir("test", 0700) != 0) { if (errno != EEXIST) err(1, "Creating test/ directory"); }