From: Joey Adams <joeyadams3.14159@gmail.com>
Date: Thu, 6 Jan 2011 20:12:18 +0000 (-0500)
Subject: ccanlint: fix segfault caused by tests not depending on the "info" test.
X-Git-Url: http://git.ozlabs.org/?p=ccan;a=commitdiff_plain;h=5f4051eaef69310d43dfdc66bb60a5979638d74c

ccanlint: fix segfault caused by tests not depending on the "info" test.

These tests:

	"depends-exist"      (compulsory_tests/check_depends_exist.c)
	"info-documentation" (tests/has_info_documentation.c)

used m->info_file without checking if it was NULL,
leading to a segfault when no _info file was present.

Some other tests also used m->info_file without depending on "info",
but are taken care of indirectly by this patch.
---

diff --git a/tools/ccanlint/compulsory_tests/check_depends_exist.c b/tools/ccanlint/compulsory_tests/check_depends_exist.c
index d1f33b64..1423b40f 100644
--- a/tools/ccanlint/compulsory_tests/check_depends_exist.c
+++ b/tools/ccanlint/compulsory_tests/check_depends_exist.c
@@ -74,4 +74,4 @@ struct ccanlint depends_exist = {
 	.check = check_depends_exist,
 };
 
-REGISTER_TEST(depends_exist, NULL);
+REGISTER_TEST(depends_exist, &has_info, NULL);
diff --git a/tools/ccanlint/tests/has_info_documentation.c b/tools/ccanlint/tests/has_info_documentation.c
index ee89df9f..0a1788fd 100644
--- a/tools/ccanlint/tests/has_info_documentation.c
+++ b/tools/ccanlint/tests/has_info_documentation.c
@@ -96,4 +96,4 @@ struct ccanlint has_info_documentation = {
 	.check = check_has_info_documentation,
 };
 
-REGISTER_TEST(has_info_documentation, NULL);
+REGISTER_TEST(has_info_documentation, &has_info, NULL);