From: Rusty Russell <rusty@rustcorp.com.au>
Date: Wed, 8 Dec 2010 00:44:21 +0000 (+1030)
Subject: configurator: warnings count as failures too.
X-Git-Url: http://git.ozlabs.org/?p=ccan;a=commitdiff_plain;h=2cae94deeef69742245557d934749235e7508bea;ds=inline

configurator: warnings count as failures too.

Unfortunately, gcc only warns if it sees an unknown attribute (in this case, gcc 4.1 vs "cold").
---

diff --git a/tools/configurator/configurator.c b/tools/configurator/configurator.c
index 426a2ad7..ffa188d7 100644
--- a/tools/configurator/configurator.c
+++ b/tools/configurator/configurator.c
@@ -267,9 +267,10 @@ static bool run_test(const char *cmd, struct test *test)
 		if (system("cat " INPUT_FILE) == -1);
 
 	output = run(cmd, &status);
-	if (status != 0) {
+	if (status != 0 || strstr(output, "warning")) {
 		if (verbose)
-			printf("Compile fail for %s, status %i: %s\n",
+			printf("Compile %s for %s, status %i: %s\n",
+			       status ? "fail" : "warning",
 			       test->name, status, output);
 		if (test->style == EXECUTE)
 			errx(1, "Test for %s did not compile:\n%s",