]> git.ozlabs.org Git - ccan/commitdiff
opt: Fix -Wmissing-field-initializers warning
authorJoel Stanley <joel@jms.id.au>
Mon, 7 Feb 2011 04:06:15 +0000 (14:36 +1030)
committerRusty Russell <rusty@rustcorp.com.au>
Mon, 7 Feb 2011 04:34:52 +0000 (15:04 +1030)
OPT_ENDTABLE does not initalise all the elements in stuct opt_table.
When compliling with -Wextra -Wmissing-field-initializers is enabled,
which produces the following warning:

        iviewiir.c:299:9: error: missing field 'cb' initializer
              [-Wmissing-field-initializers]
                OPT_ENDTABLE
                ^
        In file included from iviewiir.c:12:
        ./ccan/opt/opt.h:82:38: note: instantiated from:
        #define OPT_ENDTABLE { NULL, OPT_END }
                                             ^
By changing the definition of OPT_ENDTABLE to initalise all 7 elements
of struct opt_table, the warning is silenced.

ccan/opt/opt.h

index 8796752a133f9f8d70854af0d99ba52af4d8b51c..a1adc41d2bfa6953067d41f3e5343f2a03398241 100644 (file)
@@ -79,7 +79,7 @@ struct opt_table;
  *
  * This must be the final element in the opt_table array.
  */
-#define OPT_ENDTABLE { NULL, OPT_END }
+#define OPT_ENDTABLE { NULL, OPT_END, NULL, NULL, NULL, NULL, NULL }
 
 /**
  * opt_register_table - register a table of options